From patchwork Thu Mar 3 15:36:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugen Hristev X-Patchwork-Id: 12767639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAE88C433EF for ; Thu, 3 Mar 2022 15:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+mAUzbmZEG/OqyiM9oStyS3/HIUT00vhffwiaM8gdjU=; b=V4WIAoNbCnX7b3 PzfqsaoD8iQXv4qc+Y6bidRtMrbGrS5U1yzB3sQRuX+QHGtUuCmWbs6Ph1YTiIBo6j+HZqvPmVXJK 2IsIa1xf1dOn3l+WOFLBdrIoNljcHZXZOwHcdYpihODtGmphrJHQ6FTBh2sVS4BglOybTjbRj/Y+N i90xDNB/mMiJVT/s7bN0p1bQ8++vlqlKc+ZehKm6O/+vv+EQ1sqyyNL4vZIyk+9s22PM+GHWnDxEQ KARYHvzUA6eo36J4ZLHXipx8WrsD7KnLOHrFOtdwON1hOXAQyz1lLp4/Maljx6smuYCrXswactxGe JJRgIda+dtFbHGphrSiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPnW3-006rh1-5M; Thu, 03 Mar 2022 15:37:19 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPnVS-006rX4-HE for linux-arm-kernel@lists.infradead.org; Thu, 03 Mar 2022 15:36:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1646321802; x=1677857802; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8pGmp/P6DW09QNCZnxhFBr88c90cP0y+5hBJacUv2zo=; b=sDF6iQG6KdOTcodtrm+cVRaDMoeYaPtsJFG5iXA/5/Uk+UYZWyqfsWdZ iFPdAhbKFCkInGgVZQHI2OP1HkTrgwOGBH+2YHPM+tkut1KRbgCFgvqyq FfowX3KI3mbMHpMnyB+RXSuTePqQqaM6sduXftm2nc9swYpw+vkk8TUYC Jhn7IebQKdLSnDz3lZregmv0BoD1+taz8FzUObvmGReWrI4cqg3jdzIL3 F0MSh82SjktYRDIj4s03yrZ0gcV4/4YKt2mVj08imZ61+LRAKk5WY1S8+ hLp1370DbCW52QYIKUW/C12qmXUVeil19DTB5LGjzo9/aD0phXg2tJg0h Q==; X-IronPort-AV: E=Sophos;i="5.90,151,1643698800"; d="scan'208";a="164401714" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 Mar 2022 08:36:42 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Thu, 3 Mar 2022 08:36:40 -0700 Received: from ROB-ULT-M18282.microchip.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Thu, 3 Mar 2022 08:36:35 -0700 From: Eugen Hristev To: , Subject: [PATCH v6 01/13] media: atmel: atmel-isc-base: use streaming status when queueing buffers Date: Thu, 3 Mar 2022 17:36:06 +0200 Message-ID: <20220303153618.2084156-2-eugen.hristev@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220303153618.2084156-1-eugen.hristev@microchip.com> References: <20220303153618.2084156-1-eugen.hristev@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220303_073642_614810_80CA7DE3 X-CRM114-Status: GOOD ( 14.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Eugen Hristev , claudiu.beznea@microchip.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org During experiments with libcamera, it looks like vb2_is_streaming returns true before our start streaming is called. Order of operations is streamon -> queue -> start_streaming ISC would have started the DMA immediately when a buffer is being added to the vbqueue if the queue is streaming. It is more safe to start the DMA after the start streaming of the driver is called. Thus, even if vb2queue is streaming, add the buffer to the dma queue of the driver instead of actually starting the DMA process, if the start streaming has not been called yet. Tho achieve this, we have to use vb2_start_streaming_called instead of vb2_is_streaming. Signed-off-by: Eugen Hristev Reviewed-by: Jacopo Mondi --- drivers/media/platform/atmel/atmel-isc-base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c index db15770d5b88..d2cc6c99984f 100644 --- a/drivers/media/platform/atmel/atmel-isc-base.c +++ b/drivers/media/platform/atmel/atmel-isc-base.c @@ -442,7 +442,7 @@ static void isc_buffer_queue(struct vb2_buffer *vb) spin_lock_irqsave(&isc->dma_queue_lock, flags); if (!isc->cur_frm && list_empty(&isc->dma_queue) && - vb2_is_streaming(vb->vb2_queue)) { + vb2_start_streaming_called(vb->vb2_queue)) { isc->cur_frm = buf; isc_start_dma(isc); } else