From patchwork Fri Mar 4 01:10:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 12768381 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10295C433F5 for ; Fri, 4 Mar 2022 01:11:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=jaZZZaTFjGt+IWt5DFkznBqto9tNLW9uq19LJVVD0is=; b=AjxdCRcf1KsgV6 yAuxmu1ZsDzH6zwAsIdPGvYszagRULTnD8QlW5InIikg4AZ+/TOaI0F/JdSnLObBM0cYMXJzdKzBc f2aJemK7cUUSGXjyuC/7KrqxFbdEoBJUpICdkA2kHuGGI67VIp3vL6XdnjXH7Z3rEL25iuEkUIUWt BwYbxjbQABgaSsymtQSWJu0ZqSAsU1rVLxApbdLyMWaNIPbWw4cAYZ36DYxGXoriMbqAjKmOLBeHQ aqGfdQVokm5CkwjSt9O+9bPtDEWihlIHCmI4syZ1ewI+1RPctL7p0JdPyUCp8JIMyfnAuxbnJUPBr t5t9UDulJE0mEjZ62t/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPwSg-008DM3-Kl; Fri, 04 Mar 2022 01:10:26 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPwSc-008DL5-97 for linux-arm-kernel@lists.infradead.org; Fri, 04 Mar 2022 01:10:24 +0000 Received: by mail-pf1-x432.google.com with SMTP id a5so6236329pfv.9 for ; Thu, 03 Mar 2022 17:10:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wL/NSCoP7H388ddvlil8j+YJYi6ash7ezNgkxiwgWlI=; b=IJ0swrJnzm09mnOdENnboYPU0mXe5nnMaFOODhd0igitoGEjY2OB+M6XkyKwdelb4b MaFoHPhfPtzD2VGDK/7Njzj9JIXAVwr3r9E7T1xyIx4/kzgjXjsCJjeVs+HEhO5mHvmx PfQmMnyWwQphbZOr2Lagb4npf4NtPSPkflA83H0VnyyJMFn3PrrtC++iWZzzhjuWX3lj cKj8MJmskRLmsOmjODnpuFdXIeGr0PIpcOd2kxhHi/HcmImJgkcleGwGEAvKDjnCg3MP fS5jkk+cEHNXKlk+KQpi30OQ9vQKSjdk/ztWmR0p70WFbQQkOXVF6MtuOq4CyEYzSRj9 tcJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=wL/NSCoP7H388ddvlil8j+YJYi6ash7ezNgkxiwgWlI=; b=SKOE0JHn3L8esSy5bZuGn5U72odZsd5IrOaPNfhgjojQSuF1TWBX5WVjhD+dBrvDhB SRzbrBzP2txkYQoudfGgU06hC8N2JyMeNHRQJrymOvlobcgAdSb9dHORReSvo9JmfMkn /7umFJHbcyEEvdIQcl5iY2RRPa3IYVhvTcpJjDVFv8S0u5HQTUOcPnCR97aSzZXuW+eb ap2+9mI+1yW8sO49XJkL+VqTNr9oWeAJClJaJ2/F68g8oif17akn3vP+YQ7sUk2bJyM6 XkF97PaXyYLFq5+E57Oe1nCx2A7oG1gc3Ua3Oorj/0u+h+MC00a5PLjjtVOEXnlPnY2l GK8Q== X-Gm-Message-State: AOAM531JJgeoqXOmZ/OksBcwXieFEARb0RTh1KnDuW55QERwX1/Mq8YD L1J8M13HiIYPgON5mpaX7HpaI7uK8/xYmP2+ X-Google-Smtp-Source: ABdhPJwboBncI+6LWWacKEp45Ai5uNZhsXYA5RfMj8/mVXJcn6gUkkXxbDOBWWPmAVcL5en7SE9mnQ== X-Received: by 2002:a63:ab47:0:b0:375:5d05:9f79 with SMTP id k7-20020a63ab47000000b003755d059f79mr32569913pgp.192.1646356220418; Thu, 03 Mar 2022 17:10:20 -0800 (PST) Received: from localhost.localdomain ([45.124.203.14]) by smtp.gmail.com with ESMTPSA id d2-20020a056a0024c200b004f6b6817549sm165765pfv.173.2022.03.03.17.10.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Mar 2022 17:10:19 -0800 (PST) From: Joel Stanley To: Andrew Jeffery Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Subject: [PATCH] ARM: dts: aspeed: Fix AST2600 quad spi group Date: Fri, 4 Mar 2022 11:40:10 +1030 Message-Id: <20220304011010.974863-1-joel@jms.id.au> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220303_171022_353999_8E92F869 X-CRM114-Status: GOOD ( 13.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Requesting quad mode for the FMC resulted in an error: &fmc { status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_fwqspi_default>' [ 0.742963] aspeed-g6-pinctrl 1e6e2000.syscon:pinctrl: invalid function FWQSPID in map table  This is because the quad mode pins are a group of pins, not a function. After applying this patch we can request the pins and the QSPI data lines are muxed: # cat /sys/kernel/debug/pinctrl/1e6e2000.syscon\:pinctrl-aspeed-g6-pinctrl/pinmux-pins |grep 1e620000.spi pin 196 (AE12): device 1e620000.spi function FWSPID group FWQSPID pin 197 (AF12): device 1e620000.spi function FWSPID group FWQSPID pin 240 (Y1): device 1e620000.spi function FWSPID group FWQSPID pin 241 (Y2): device 1e620000.spi function FWSPID group FWQSPID pin 242 (Y3): device 1e620000.spi function FWSPID group FWQSPID pin 243 (Y4): device 1e620000.spi function FWSPID group FWQSPID Fixes: f510f04c8c83 ("ARM: dts: aspeed: Add AST2600 pinmux nodes") Signed-off-by: Joel Stanley Reviewed-by: Andrew Jeffery --- arch/arm/boot/dts/aspeed-g6-pinctrl.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/aspeed-g6-pinctrl.dtsi b/arch/arm/boot/dts/aspeed-g6-pinctrl.dtsi index 6dde51c2aed3..e4775bbceecc 100644 --- a/arch/arm/boot/dts/aspeed-g6-pinctrl.dtsi +++ b/arch/arm/boot/dts/aspeed-g6-pinctrl.dtsi @@ -118,7 +118,7 @@ pinctrl_fwspid_default: fwspid_default { }; pinctrl_fwqspid_default: fwqspid_default { - function = "FWQSPID"; + function = "FWSPID"; groups = "FWQSPID"; };