diff mbox series

arm64: dts: imx8qm: Correct SCU clock controller's compatible property

Message ID 20220304080443.1733924-1-victor.liu@nxp.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: imx8qm: Correct SCU clock controller's compatible property | expand

Commit Message

Liu Ying March 4, 2022, 8:04 a.m. UTC 
The fsl,scu.txt dt-binding documentation explicitly mentions
that the compatible string should be either "fsl,imx8qm-clock"
or "fsl,imx8qxp-clock", followed by "fsl,scu-clk".  Also, i.MX8qm
SCU clocks and i.MX8qxp SCU clocks are really not the same, so
we have to set the compatible property according to SoC name.
Let's correct the i.MX8qm clock controller's compatible property
from
"fsl,imx8qxp-clk", "fsl,scu-clk"
to
"fsl,imx8qm-clk", "fsl,scu-clk" .

Fixes: f2180be18a63 ("arm64: dts: imx: add imx8qm common dts file")
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8qm.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shawn Guo April 9, 2022, 2:59 a.m. UTC | #1 
On Fri, Mar 04, 2022 at 04:04:43PM +0800, Liu Ying wrote:
> The fsl,scu.txt dt-binding documentation explicitly mentions
> that the compatible string should be either "fsl,imx8qm-clock"
> or "fsl,imx8qxp-clock", followed by "fsl,scu-clk".  Also, i.MX8qm
> SCU clocks and i.MX8qxp SCU clocks are really not the same, so
> we have to set the compatible property according to SoC name.
> Let's correct the i.MX8qm clock controller's compatible property
> from
> "fsl,imx8qxp-clk", "fsl,scu-clk"
> to
> "fsl,imx8qm-clk", "fsl,scu-clk" .
> 
> Fixes: f2180be18a63 ("arm64: dts: imx: add imx8qm common dts file")
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
index be8c76a0554c..4f767012f1f5 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
@@ -196,7 +196,7 @@  pd: imx8qx-pd {
 		};
 
 		clk: clock-controller {
-			compatible = "fsl,imx8qxp-clk", "fsl,scu-clk";
+			compatible = "fsl,imx8qm-clk", "fsl,scu-clk";
 			#clock-cells = <2>;
 		};