From patchwork Mon Mar 7 10:51:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12771536 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA863C433F5 for ; Mon, 7 Mar 2022 10:53:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=A5O/g93jJwNDqaH7vCQoo8G6wOkAcEeEsJp94ezrmrA=; b=IGrcjdNbU8JlsT 2NxQ6ZV/UMFvBn2tT9K27enlTuLHVQJlHs9y6mZ0Af5DntX0b8+5XN9VL3pR3cxQRa9qYH9tG7H2k xwdW06sqARk5IrAMlUfV4LA8lXzQZyYz1izM56lMkV7XTUkuC7l6p7HCLp/qrmXf5/zM8jrFxHw4j B70d6ogJqzF57/+qSisIss4+qqYlKZ8B2F5j7Txq9xQDp7DkQRYb1Hvbfx8gkjwGdTxNQAWDbcnFI 7ksrwcR3YgOf6p8eXk5ZyfGKFk4z+w5ma7CZsXL4JKQuhL56nx3uBdu2RFPHZ+T4m824TFtlz9ETo 0dmC7XsDIjFIIgS0B58g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRAxz-00HDqm-NG; Mon, 07 Mar 2022 10:51:51 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRAxw-00HDps-38; Mon, 07 Mar 2022 10:51:49 +0000 Received: by mail-pj1-x102c.google.com with SMTP id mv5-20020a17090b198500b001bf2a039831so6930777pjb.5; Mon, 07 Mar 2022 02:51:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=j8mgW2tireVLaFShl52ji4HfOgeZjBRmsgnOuKcFd2U=; b=iZkGKeV7nAWcmc5MQ6oH1nL1eOx2fyL3qHrKtLlW2TiU8yYpwHdJSluLmnDFPHA5P3 YEmTWTDKLDkQP+aJPfDPuUqq24X/b2CS6+bDSP+PXDUoNv37AGwjBRsX5+mL2EX386az WF6okfVboABcIyulNol9DXK6ybW90GHTmGdKMAMX9aQIuXOdInXMxY6iOGoZDxFbTu9k PThuffnNj+E3o6Ha/xUh24D4SxBnPAlTd1nTDRqZ7zfNrG9CeWgXZADTYqyveDAroxCE gUWpRyPuSgJnPqs1yvBnziqm8u5FIQWUfU23ct2sN7/rI6ebHHWTEXL22pu6eiolmBk3 2HQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=j8mgW2tireVLaFShl52ji4HfOgeZjBRmsgnOuKcFd2U=; b=eKMD7Ty5DEqE8Uvzb59/6hojt49zWnk9HJ9Qhw9XUm/YGxhyqxSI/WUJ/+I97ikJih kqunbLVTiQnUPfr7nAcNTdh8j6fKlZMdIPyPEJrWCnx9uFWUbGWDgRQ+UHWObZEnM8T7 dkdCbA+8IAff/WWyZxXs7PzT8zzIg46QfVd7/7O0uTUBgX/clBQJ1eSzz+6XluZ/DEGr Mz80oqUgExxY8EPVu+Syn9U4DhLY7DAXCENvBAMRvV5IquelBvNKxquW4nnQ2Ca/xsQz s6b8tpSAm7jIVA+33m2w49bDcLOr2KPJGahzkABgxzY1eCxk7vbwzqwY4wRkwZ1MnuO+ gJ4w== X-Gm-Message-State: AOAM530yolhTEBTrxVE/9Z6JJVmPQydftQQjSkc0aNCJH1LUZORXuzIJ rFyNHrV37qiJK4w7mwOsTIA= X-Google-Smtp-Source: ABdhPJxlWUg0FoiPrnYPoA2ku5qK/koaaqDT8mnDf0zPlnYQ36GpgzCPkzrnnv3qsGnGe6xThjT7yA== X-Received: by 2002:a17:902:6f0f:b0:151:3f2d:8b21 with SMTP id w15-20020a1709026f0f00b001513f2d8b21mr11613033plk.123.1646650306160; Mon, 07 Mar 2022 02:51:46 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id y39-20020a056a00182700b004e19980d6cbsm15619619pfa.210.2022.03.07.02.51.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 02:51:45 -0800 (PST) From: Miaoqian Lin To: Greg Kroah-Hartman , Jiri Slaby , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Amit Singh Tomar , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] tty: serial: owl: Fix missing clk_disable_unprepare() in owl_uart_probe Date: Mon, 7 Mar 2022 10:51:35 +0000 Message-Id: <20220307105135.11698-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220307_025148_156621_09BCC9EE X-CRM114-Status: GOOD ( 10.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix the missing clk_disable_unprepare() before return from owl_uart_probe() in the error handling case. Fixes: abf42d2f333b ("tty: serial: owl: add "much needed" clk_prepare_enable()") Signed-off-by: Miaoqian Lin --- drivers/tty/serial/owl-uart.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/owl-uart.c b/drivers/tty/serial/owl-uart.c index 91f1eb0058d7..9a6611cfc18e 100644 --- a/drivers/tty/serial/owl-uart.c +++ b/drivers/tty/serial/owl-uart.c @@ -731,6 +731,7 @@ static int owl_uart_probe(struct platform_device *pdev) owl_port->port.uartclk = clk_get_rate(owl_port->clk); if (owl_port->port.uartclk == 0) { dev_err(&pdev->dev, "clock rate is zero\n"); + clk_disable_unprepare(owl_port->clk); return -EINVAL; } owl_port->port.flags = UPF_BOOT_AUTOCONF | UPF_IOREMAP | UPF_LOW_LATENCY;