From patchwork Tue Mar 8 02:47:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12772921 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA5DFC433EF for ; Tue, 8 Mar 2022 02:49:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=zmI7leeCFRFOpHUeSCYnEsxenKIbraG1HKtyfVMxVHY=; b=x6Fs/853NmXJ9o xGuIbPc91RAxwjiD6iDuYLh3Ud2coKjwz9l9Rb9E09D3gctWKMOUJkVyE8mPhYU4BDeG7am7mmUCf UYngwHY1Qj38CPpK9JfbEDG1aFYnWyv0Zf2s/QFyJTidzWTZ/7c9l1XWsIqxu2JGN/BlTEhF64Ei1 IMbhrS2KsB1wrXKG2gWNkFevkEU1gHFcwV2lqGC+hbzS9aw/1jsbDsz8nKD5622LADI9w2ydR0Ayh Kmwkb9J09jOOW/ss/IgPwI7SIYel/5f2ehk0Hx06ojAmgHUdCANIzSHQEs6qWilLxv48aNSVqZ7bL l3Trt3uADpF8L0uV11XQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRPtJ-002UDe-51; Tue, 08 Mar 2022 02:48:01 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRPtG-002UD2-0E for linux-arm-kernel@lists.infradead.org; Tue, 08 Mar 2022 02:47:59 +0000 Received: by mail-pl1-x636.google.com with SMTP id s1so15787844plg.12 for ; Mon, 07 Mar 2022 18:47:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id; bh=9+rs02y8/agiJlSLF4WllYH2sVrI0f+W4mxvW+9rYxo=; b=kOsYCvCHrcNK69cLsdd1syJuU5VrntMM29u88/Zofjp5wZ0p+JUKmRoTVMQuCXa5EP x1EAnf6nugh/jSQbzGEpRJSiSnJ8p5qzUNZGg0qMKgKo4evf+xy9phi/bG+nTb474El6 me7DarfDNuPG88ioy57rONUHHnJ1DO9/oQYWGcR/nFSrW/SPhT98Hv7xM+CDvqhFgqZw r4THfZcgwMDAL5lXLSV3ZTVK3bdKNkr/p/XNktZfJ5m3tCfQwogJiyKzdCd3tnEX3bNX 8qAeFmGjbb+94ETj4VE+pKUAt6AAZH+lBipxMNlk0Q+yP58CoYhhqoYwgukRW9SE288c 2DDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id; bh=9+rs02y8/agiJlSLF4WllYH2sVrI0f+W4mxvW+9rYxo=; b=hFomZ2IALFpJiFC8eqMsJDHtervu/DqAtuHVf5emIzXmtGPB31+F6Su5HJ2b2i+/va SOAwqVypwwTpExmwDGo9bfvOczGPp861YqzMdUaZlRvMXlqyHvi2sZ5H9Uwmzg3rB1d8 M/vO/ekxJbxBeAUDx3LOin1dpD4WuG+zNBhl39yAs5KC2qb2ECDeVmaR7jvArCGO2EST +tSjGZraS6wtr110aeuaGMIyFY5eVPKCZisimt3/A41nFkDc6gr711Z5aaL1BtRuJyIg GP+uR+oUB0SpPsSAovm0+/zj3RWLOJf2LaqrnwwipF5V6+W/CT76toeFfHNhkqGe/nMv XkJA== X-Gm-Message-State: AOAM5304vJu0frsOUu/j0SvALi0bXh8+bXVRF85AEcrV0hA0qBR3sGHP F22Aa5Ef3oGWYTFwNOtxQiU= X-Google-Smtp-Source: ABdhPJx5sigmWo+hcAj/lrzhaaBiN7D4kgyoa0sNOMynzTneLnudVl/LjKzXJwdeyHer4Chiqm1Bdg== X-Received: by 2002:a17:902:e2c3:b0:151:d68e:cd0c with SMTP id l3-20020a170902e2c300b00151d68ecd0cmr13249158plc.69.1646707676850; Mon, 07 Mar 2022 18:47:56 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id g18-20020a62e312000000b004f6fe0f4cf2sm5565404pfh.102.2022.03.07.18.47.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 18:47:56 -0800 (PST) From: Miaoqian Lin To: "David S. Miller" , Jakub Kicinski , Michal Simek , Arnd Bergmann , Andrew Lunn , Miaoqian Lin , Michael Walle , Lad Prabhakar , YueHaibing , John Linn , Grant Likely , Sadanand Mutyala , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ethernet: Fix error handling in xemaclite_of_probe Date: Tue, 8 Mar 2022 02:47:49 +0000 Message-Id: <20220308024751.2320-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220307_184758_071351_DA15F121 X-CRM114-Status: GOOD ( 12.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This node pointer is returned by of_parse_phandle() with refcount incremented in this function. Calling of_node_put() to avoid the refcount leak. As the remove function do. Fixes: 5cdaaa12866e ("net: emaclite: adding MDIO and phy lib support") Signed-off-by: Miaoqian Lin Reviewed-by: Andrew Lunn --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 519599480b15..77fa2cb03aca 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -1183,7 +1183,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev) if (rc) { dev_err(dev, "Cannot register network device, aborting\n"); - goto error; + goto put_node; } dev_info(dev, @@ -1191,6 +1191,8 @@ static int xemaclite_of_probe(struct platform_device *ofdev) (unsigned long __force)ndev->mem_start, lp->base_addr, ndev->irq); return 0; +put_node: + of_node_put(lp->phy_node); error: free_netdev(ndev); return rc;