From patchwork Wed Mar 9 10:43:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12774917 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18B2BC433EF for ; Wed, 9 Mar 2022 10:44:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=3nSIsSgFMeOwTeouMCZkaMJj6EE3Q/J69cEw6SAb42k=; b=0Bqx58EWUGNRdt ZcyWvDm50fmX8K1JPxm9s3kY5n7NF3zm8x0KBR8P6hmm/USF3+ySxq9WLC+0Xdaj/jH71GmwzPj87 +Cw/hn8Pvz+vRKVduJnYZ+GCKrIj6yVbIRXHWghUiUuigzLhGbhcJUoIwyrnJag8eFS4sMPa2Mbha zkRChf8suDFQhBaibVaA0rVh6f8z8qnDGzF2tOlLWOlZ2GgAWimFDyR6ijTFLyXIso9UcmeFlMibt 0lB9LXEx2qM4EJjatsbCRJTRMSlg+uPvm7MyP+W/wiff3ZeSELI403Wn/goFV129f0tmwMObm6yXd rQKBmJZpMrfolA9Q/wEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRtmj-008BXz-Qx; Wed, 09 Mar 2022 10:43:13 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRtmg-008BXW-HF for linux-arm-kernel@lists.infradead.org; Wed, 09 Mar 2022 10:43:11 +0000 Received: by mail-pj1-x102b.google.com with SMTP id m22so1996607pja.0 for ; Wed, 09 Mar 2022 02:43:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=bt4ZemLtOjAhYVYN3C3UPz2pvYP7puf8xAJCLiBgkNw=; b=e9B1wDLOf0IBpGci9IPcFDA4oMNKSdRyxP5107p72QEijTIajuJhTQXofC5jCJexCt 7CvG9btzhJBjZhDgvKjoMZyJfZ8Xpx169D/L8PUtQbtKxbQwICizvntN6Mr6pNskNeKS t2yljdxctGr/R8HzFqOh9E9GDU2/AsQZZSVJjGCV1rpj3PiPaC6iwRz6Um/YTUSnntoG eb1jY//ACNfwH1FO90zAQWNVCDOOZHEkmIAxKPktWIg/UGuFmIpe4pSRrXkO8AGEgJPe fjbqGGlAt5VltemmdX9w3DILkVFViRmIuj7Eh9svTu6pnOSwwKvrRg+H0jDDeHPJuaQ6 WF4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bt4ZemLtOjAhYVYN3C3UPz2pvYP7puf8xAJCLiBgkNw=; b=Q7d2E/v+O5BfH8u1R+W1zAnZSdCHcY74f8eia/Cm0gNpNUnZf1vZNGDLYqXDHY93Sl deIqkuqO0fRtL30vfxic/MrlszZoaLr/1qerUjnxYnbcj02cQyAHZfDiXUXyEq7XnjhF +jEfdnTSuizEsVerkqaCvsnheDsmozaxVpxLN4wR6YVvvuP+wlfR5Hln0vlTLojDf4wx q+N4gxuJBKUFXMV3bfBBv8xBB+2NeVjF0atmKc5gsvC1icRPTd/R9u7rvYzquGP8OVUs jlin+vpYcWvjYoJL0EDpUywTAvKMbzlSnSjf/0igVPXoe7PDUQ8LrlYj3MTJ/Fesbtdp 2lrA== X-Gm-Message-State: AOAM533rqq/XVizOqcMN/j+cdPnme+yfSM10Zicmfh51U7IC6ajd1x8p 2Mx24OCUfqjaGS+r78WalDY= X-Google-Smtp-Source: ABdhPJxFu1likQj+qOnn7a71MxPF9QsD64CJ2bBKawmiVY26O2ssL8I2crrpWf0Yng7mbq8b7mW+3Q== X-Received: by 2002:a17:902:b60f:b0:151:a83a:5402 with SMTP id b15-20020a170902b60f00b00151a83a5402mr22098156pls.21.1646822589768; Wed, 09 Mar 2022 02:43:09 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id q13-20020a056a00088d00b004e1bea9c582sm2487557pfj.43.2022.03.09.02.43.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 02:43:09 -0800 (PST) From: Miaoqian Lin To: Tony Lindgren , Russell King , Santosh Shilimkar , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] ARM: OMAP2+: Fix refcount leak in omap_gic_of_init Date: Wed, 9 Mar 2022 10:43:01 +0000 Message-Id: <20220309104302.18398-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220309_024310_604763_92F203DD X-CRM114-Status: GOOD ( 12.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The of_find_compatible_node() function returns a node pointer with refcount incremented, We should use of_node_put() on it when done Add the missing of_node_put() to release the refcount. Fixes: fd1c07861491 ("ARM: OMAP4: Fix the init code to have OMAP4460 errata available in DT build") Signed-off-by: Miaoqian Lin --- arch/arm/mach-omap2/omap4-common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c index 5c3845730dbf..0b80f8bcd304 100644 --- a/arch/arm/mach-omap2/omap4-common.c +++ b/arch/arm/mach-omap2/omap4-common.c @@ -314,10 +314,12 @@ void __init omap_gic_of_init(void) np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic"); gic_dist_base_addr = of_iomap(np, 0); + of_node_put(np); WARN_ON(!gic_dist_base_addr); np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-twd-timer"); twd_base = of_iomap(np, 0); + of_node_put(np); WARN_ON(!twd_base); skip_errata_init: