From patchwork Fri Mar 11 14:52:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukas Bulwahn X-Patchwork-Id: 12778212 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C41CC433EF for ; Fri, 11 Mar 2022 15:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=M0egoW6ehLbe/5I8UsiQnPsTus8AmM2XxPZlkBGKq6k=; b=Nh/7g0+GrsmLHo xXFZynZtZwOynxcgBuBFGDqIymAZFmEb1EsCZJLX6Mngf2U1J0+ypfonitTJAUscvOlUZ6s04Zutf cmf/4+Vj+KFRgSCCcsVobeEmlrX5om9rAg2fgLdg32iYw/KeZgMbj5EY91SZBdHeZoOrwLoNC0WxY fKjvd/pJVWYedrWPMBKJo5r2nYTYVGOx8unDWRNnqZTdq+xbmq2jBmpNowNzkyn3q7Cw+mH0eAr+Y hEJ1uxuWTAGLzTQKVm8u6UzP7W7bR05mpwXrgTzL58TeKxLcMOwBKHu13jqwKyAQ+5/YOSU5k20EI TfQ8NjUwgDDlzP5R8bRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSguk-00H35l-PD; Fri, 11 Mar 2022 15:10:47 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSgdR-00Gvcy-Mu for linux-arm-kernel@lists.infradead.org; Fri, 11 Mar 2022 14:53:02 +0000 Received: by mail-wr1-x435.google.com with SMTP id x15so13250195wru.13 for ; Fri, 11 Mar 2022 06:52:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=zXbQhDsb4KeIHJF68pqLMN1JbVnR3P47zU5x8xmbukY=; b=BSANDLIqhwKqPBrb7Qys22MwnO6tUlv/4n97D6C6X5Xo7C0ubhSTuXrHjbCMsBJEm8 vmPhN2Koys66YJNxCfSmp+wBXlE+eJuOg6kODRnr6pMIoth0zpdaqu1ilC64Fj0yKH38 RthvqcRt3yNJAR9BT1UzW04Ux/o89D7N86AEIm7yZxKDtgFjLn4lzGWY8VLmAN/Bga+B pZsS9dpYySIl/qfRzxYPYGJifxR9SDNeBc5s8yJnJGVegL7LHXyPDgnQnOq0tH91dFW4 8Evma8cK5v5z1t1ppjbgDxvCCen/LmKduf4oXjcfhNsNzMZ5mwu4BccW4yFxlUQ+zVk+ dsUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zXbQhDsb4KeIHJF68pqLMN1JbVnR3P47zU5x8xmbukY=; b=nq9rwhQfA0g3EiXWFgFekcvjmvaF6P96tyyEZVaRzOMxo5NFPJfIuD2JWZgxqB6fWO hSyXOkKuKb1vNxp9lus0g+nGMHwh3FFqEbmovd5EMDQJ6S8yHUzyuWyR2fiKoxxgiwtC qHbqsDGAAUnvX1QyBGhBV2/aFxqNA4/l1K89QllZxBNSUY7xEUoqhQqmn4RLVpEuJnI0 kb8AYnL5SSDqXLJ6AfQputtlc0k1c5GjXqhD6Kr2jCQ9ZrpXaejclO4oiDf5NfLVQGZa ogJKnWdP4k9Lec7DDxPnq/fTvGrv9Th6b9YGtBNCVnO42HRHgGcppkCvvxOBuVVpiiZ+ 167w== X-Gm-Message-State: AOAM530yu+ahwGMxI/Ks2kWms/3iM8BikqCpDP/hT4Dp+hlgKg5TEEOR D+E9++HGdT+5Ikyom+Ttlsw= X-Google-Smtp-Source: ABdhPJzHH8NgnMxZ4xQfDUIJUUso04P4Zd8QBxBCn/z6kuDzIy8sTogfhut+UHhuw2kIN85qtVoNrQ== X-Received: by 2002:adf:fbd0:0:b0:1e6:8ec3:570 with SMTP id d16-20020adffbd0000000b001e68ec30570mr8040941wrs.396.1647010371688; Fri, 11 Mar 2022 06:52:51 -0800 (PST) Received: from felia.fritz.box (200116b826a9a900147fc2a0771e144b.dip.versatel-1u1.de. [2001:16b8:26a9:a900:147f:c2a0:771e:144b]) by smtp.gmail.com with ESMTPSA id n8-20020adf8b08000000b001f046cc8891sm7037812wra.24.2022.03.11.06.52.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Mar 2022 06:52:51 -0800 (PST) From: Lukas Bulwahn To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn Subject: [PATCH] mfd: ab8500: clean up definitions in header after debugfs removal Date: Fri, 11 Mar 2022 15:52:09 +0100 Message-Id: <20220311145209.17346-1-lukas.bulwahn@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220311_065253_812187_51461FCE X-CRM114-Status: GOOD ( 17.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit 3d4d1266597c ("mfd: ab8500: Drop debugfs module") removes the config AB8500_DEBUG in drivers/mfd/Kconfig, but missed a reference to this config in include/linux/mfd/abx500/ab8500.h. The functions ab8500_dump_all_banks() and ab8500_debug_register_interrupt() in the ab8500 header, previously with definitions conditioned on AB8500_DEBUG, are now completely needless to define and handle at all. The function ab8500_debug_register_interrupt() is not used at all and can just be removed. The function ab8500_dump_all_banks() is just registered in the abx500_ops struct in the dump_all_banks field, but this is then not further referenced anywhere else at all. So, safely drop the dump_all_banks field from abx500_ops and delete the ab8500_dump_all_banks() definition. Signed-off-by: Lukas Bulwahn Reviewed-by: Linus Walleij --- Linus, Lee, please pick this clean-up on top of the commit above. drivers/mfd/ab8500-core.c | 3 +-- include/linux/mfd/abx500.h | 1 - include/linux/mfd/abx500/ab8500.h | 9 --------- 3 files changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c index 6a059270acdc..9049030a0c82 100644 --- a/drivers/mfd/ab8500-core.c +++ b/drivers/mfd/ab8500-core.c @@ -328,8 +328,7 @@ static struct abx500_ops ab8500_ops = { .set_register_page = NULL, .mask_and_set_register = ab8500_mask_and_set_register, .event_registers_startup_state_get = NULL, - .startup_irq_enabled = NULL, - .dump_all_banks = ab8500_dump_all_banks, + .startup_irq_enabled = NULL }; static void ab8500_irq_lock(struct irq_data *data) diff --git a/include/linux/mfd/abx500.h b/include/linux/mfd/abx500.h index 7f07cfe44753..507e3d2f062f 100644 --- a/include/linux/mfd/abx500.h +++ b/include/linux/mfd/abx500.h @@ -63,7 +63,6 @@ struct abx500_ops { int (*mask_and_set_register) (struct device *, u8, u8, u8, u8); int (*event_registers_startup_state_get) (struct device *, u8 *); int (*startup_irq_enabled) (struct device *, unsigned int); - void (*dump_all_banks) (struct device *); }; int abx500_register_ops(struct device *core_dev, struct abx500_ops *ops); diff --git a/include/linux/mfd/abx500/ab8500.h b/include/linux/mfd/abx500/ab8500.h index 302a330c5c84..42fd5da7d8a7 100644 --- a/include/linux/mfd/abx500/ab8500.h +++ b/include/linux/mfd/abx500/ab8500.h @@ -503,13 +503,4 @@ static inline int is_ab9540_2p0_or_earlier(struct ab8500 *ab) void ab8500_override_turn_on_stat(u8 mask, u8 set); -#ifdef CONFIG_AB8500_DEBUG -extern int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size); -void ab8500_dump_all_banks(struct device *dev); -void ab8500_debug_register_interrupt(int line); -#else -static inline void ab8500_dump_all_banks(struct device *dev) {} -static inline void ab8500_debug_register_interrupt(int line) {} -#endif - #endif /* MFD_AB8500_H */