From patchwork Sat Mar 12 13:28:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 12778886 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADD8DC433EF for ; Sat, 12 Mar 2022 13:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wMk4c9sA5crPsBFsPXyFB0A950rvwAgTKkappPeEJe0=; b=HIAQtDtOdSxBbL krFydWdWY+OudHvT1mZBhdB2ByGT9Ib7/ZCCVDYUohGuL05TOxNozsxeXOMC8ptZj5rB2YY9lqQAj dKl3EHr/mrg40bgPAggWS7vfJzDU7bitprs0XcsOR4OCBWqHrcLpdPvCyHohKZkAcsPqrMb6qy/tM AdleSma8TnO2w6KoSJIqP6JZY40FBlhsA7O5WN0Ce3oCdg+symFpVejndc6gpaKp7qbEsvGlxixjD r0ts0lwZRs2sGJd+CuuTePHnGh/ltUYU1g1SJputaHTRcvXtjQgHwcycUmZWnUx90E5HermaIUaTO UUvTpts0ZfOyhp6v9Y7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nT1sf-001NWl-8r; Sat, 12 Mar 2022 13:34:02 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nT1oV-001LeC-7I for linux-arm-kernel@lists.infradead.org; Sat, 12 Mar 2022 13:29:44 +0000 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id E1A0B3F79D for ; Sat, 12 Mar 2022 13:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647091781; bh=x+DOMuEjhXppqlmSDNC0RKdzUzslcBqDhsGS9OsoQS4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=a4Ik9MN5YuOqev4yW9GJoQz9G4nNGGzA0iHV6uTe1iO+zl2CWV+pZpAtYsunIB5Dw mwRxDqVp3dtczN6p02i9YToL4BtrIFMxhWHCWyKsLjBQgelrWL3StcSo+52FOMVOfb XqI2JDlFxsTwGKf3jvnM1DpyHnAwMH+4bw0xq1nRmsbi891PL3V/QvSrBympOnZSiE JfFJWcUYvMwpwrlereU30RKJr1Mlz8eA5kvIsqDZaY47q6pADi5IUgmSJaSTAWAoHq EXytLYT4lqPUlkp3cvWdQICfoCgXMvFMhxYWa9G8SUlpk44VnIHBsjjZd7SpSyM7YQ tm7RaqooHypWg== Received: by mail-wm1-f70.google.com with SMTP id a26-20020a7bc1da000000b003857205ec7cso4401151wmj.2 for ; Sat, 12 Mar 2022 05:29:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x+DOMuEjhXppqlmSDNC0RKdzUzslcBqDhsGS9OsoQS4=; b=H0rBM321JZHMHLA90+ZYtodzJl3cwFpXqYP4PJnU9wJOlq+3b6KLU3e5f46yVqZ1Ax YeeN1YlU3CmoueBqJENvnr1sFiET1HP+Gvao9nZTkWpooaTBbauG8rUtpePFRh1JGwQH C6B0M1DWqOJC0Lck4ZVGJYtRWWglztfvY9fmAiRZCc4VSf+fH2CylkizIhaIQW8eujXZ KbsZ9WDktV2SXbEUb7Hnlvt6hs+9kcFPHSxTmse9OoE7Hc0WQvFR1F5kloscVTXkIyA0 kfRsqpoKEXxbKBGPUT/S+ZYHLh8g9PqA/7EHhB7cKkEjZJ1rf7Yh0I7Wobou0mWW64Mx L0kg== X-Gm-Message-State: AOAM530OH/MScSOIt9opqBjkC9oqR/8gQC7Clo1FUYSt3sHZqb6nVXeD BfjEFJnChpM3KtHsrJ6SC01rwhtVsCZg16Lo8/rAtXewRgMPqal6IAk9lMBAkoUh0GGKLqBIg2l zbwFYC5xlcDQ51daeVFn2prT4dtIvl/nFsPFY5ds67rtDJtcvjO6Z X-Received: by 2002:adf:f44d:0:b0:1f0:49bb:fead with SMTP id f13-20020adff44d000000b001f049bbfeadmr10583605wrp.586.1647091771129; Sat, 12 Mar 2022 05:29:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5ufiLsjNXlLmSXpd1ewfKV/mq0TKGVtl9zvcWEFJmoAu7ZXtJo6A/7/mnNUpXOXLfNGXp5w== X-Received: by 2002:adf:f44d:0:b0:1f0:49bb:fead with SMTP id f13-20020adff44d000000b001f049bbfeadmr10583570wrp.586.1647091770954; Sat, 12 Mar 2022 05:29:30 -0800 (PST) Received: from localhost.localdomain (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.gmail.com with ESMTPSA id p22-20020a1c5456000000b00389e7e62800sm5751550wmi.8.2022.03.12.05.29.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Mar 2022 05:29:30 -0800 (PST) From: Krzysztof Kozlowski To: Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: Stuart Yoder , Laurentiu Tudor , Abel Vesa , Shawn Guo , Sascha Hauer , Fabio Estevam , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , Srinivas Kandagatla , Mark Brown , "Michael S. Tsirkin" , Jason Wang , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds , Rasmus Villemoes , Krzysztof Kozlowski , stable@vger.kernel.org Subject: [PATCH v4 09/11] clk: imx: scu: Fix kfree() of static memory on setting driver_override Date: Sat, 12 Mar 2022 14:28:54 +0100 Message-Id: <20220312132856.65163-10-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220312132856.65163-1-krzysztof.kozlowski@canonical.com> References: <20220312132856.65163-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220312_052943_428290_430FE201 X-CRM114-Status: GOOD ( 15.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The driver_override field from platform driver should not be initialized from static memory (string literal) because the core later kfree() it, for example when driver_override is set via sysfs. Use dedicated helper to set driver_override properly. Fixes: 77d8f3068c63 ("clk: imx: scu: add two cells binding support") Cc: Signed-off-by: Krzysztof Kozlowski --- drivers/clk/imx/clk-scu.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c index 083da31dc3ea..4b2268b7d0d0 100644 --- a/drivers/clk/imx/clk-scu.c +++ b/drivers/clk/imx/clk-scu.c @@ -683,7 +683,12 @@ struct clk_hw *imx_clk_scu_alloc_dev(const char *name, return ERR_PTR(ret); } - pdev->driver_override = "imx-scu-clk"; + ret = driver_set_override(&pdev->dev, &pdev->driver_override, + "imx-scu-clk", strlen("imx-scu-clk")); + if (ret) { + platform_device_put(pdev); + return ERR_PTR(ret); + } ret = imx_clk_scu_attach_pd(&pdev->dev, rsrc_id); if (ret)