diff mbox series

[v20,1/4] mfd: silergy,sy7636a: Add config option

Message ID 20220330094126.30252-2-alistair@alistair23.me (mailing list archive)
State New, archived
Headers show
Series Add support for the silergy,sy7636a | expand

Commit Message

Alistair Francis March 30, 2022, 9:41 a.m. UTC
Add a specific MFD_SY7636A config option.

As part of this change we can use MFD_SY7636A as a dependency for all
SY7636a components and also remove the name from MFD_SIMPLE_MFD_I2C as
it no longer needs to be selectable.

Signed-off-by: Alistair Francis <alistair@alistair23.me>
---
 drivers/hwmon/Kconfig     |  1 +
 drivers/mfd/Kconfig       | 12 +++++++++++-
 drivers/regulator/Kconfig |  1 +
 3 files changed, 13 insertions(+), 1 deletion(-)

Comments

Guenter Roeck March 30, 2022, 8:02 p.m. UTC | #1
On 3/30/22 02:41, Alistair Francis wrote:
> Add a specific MFD_SY7636A config option.
> 
> As part of this change we can use MFD_SY7636A as a dependency for all
> SY7636a components and also remove the name from MFD_SIMPLE_MFD_I2C as
> it no longer needs to be selectable.
> 
> Signed-off-by: Alistair Francis <alistair@alistair23.me>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/hwmon/Kconfig     |  1 +
>   drivers/mfd/Kconfig       | 12 +++++++++++-
>   drivers/regulator/Kconfig |  1 +
>   3 files changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 68a8a27ab3b7..74b60d24e740 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1693,6 +1693,7 @@ config SENSORS_SIS5595
>   
>   config SENSORS_SY7636A
>   	tristate "Silergy SY7636A"
> +	depends on MFD_SY7636A
>   	help
>   	  If you say yes here you get support for the thermistor readout of
>   	  the Silergy SY7636A PMIC.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 3b59456f5545..c47cb755757b 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1095,6 +1095,16 @@ config MFD_SPMI_PMIC
>   	  Say M here if you want to include support for the SPMI PMIC
>   	  series as a module.  The module will be called "qcom-spmi-pmic".
>   
> +config MFD_SY7636A
> +	tristate "Silergy SY7636A voltage regulator"
> +	depends on I2C
> +	select MFD_SIMPLE_MFD_I2C
> +	help
> +	  Enable support for Silergy SY7636A voltage regulator.
> +
> +	  To enable support for building sub-devices as modules,
> +	  choose M here.
> +
>   config MFD_RDC321X
>   	tristate "RDC R-321x southbridge"
>   	select MFD_CORE
> @@ -1202,7 +1212,7 @@ config MFD_SI476X_CORE
>   	  module will be called si476x-core.
>   
>   config MFD_SIMPLE_MFD_I2C
> -	tristate "Simple Multi-Functional Device support (I2C)"
> +	tristate
>   	depends on I2C
>   	select MFD_CORE
>   	select REGMAP_I2C
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index 5ef2306fce04..c8ce6e5eea24 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -1219,6 +1219,7 @@ config REGULATOR_STW481X_VMMC
>   
>   config REGULATOR_SY7636A
>   	tristate "Silergy SY7636A voltage regulator"
> +	depends on MFD_SY7636A
>   	help
>   	  This driver supports Silergy SY3686A voltage regulator.
>
Alistair Francis April 20, 2022, 12:21 p.m. UTC | #2
On Thu, Mar 31, 2022 at 6:02 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 3/30/22 02:41, Alistair Francis wrote:
> > Add a specific MFD_SY7636A config option.
> >
> > As part of this change we can use MFD_SY7636A as a dependency for all
> > SY7636a components and also remove the name from MFD_SIMPLE_MFD_I2C as
> > it no longer needs to be selectable.
> >
> > Signed-off-by: Alistair Francis <alistair@alistair23.me>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Any chance of getting this in for 5.18? It would be nice to have the
configs all sorted before the release

Alistair

>
> > ---
> >   drivers/hwmon/Kconfig     |  1 +
> >   drivers/mfd/Kconfig       | 12 +++++++++++-
> >   drivers/regulator/Kconfig |  1 +
> >   3 files changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> > index 68a8a27ab3b7..74b60d24e740 100644
> > --- a/drivers/hwmon/Kconfig
> > +++ b/drivers/hwmon/Kconfig
> > @@ -1693,6 +1693,7 @@ config SENSORS_SIS5595
> >
> >   config SENSORS_SY7636A
> >       tristate "Silergy SY7636A"
> > +     depends on MFD_SY7636A
> >       help
> >         If you say yes here you get support for the thermistor readout of
> >         the Silergy SY7636A PMIC.
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 3b59456f5545..c47cb755757b 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -1095,6 +1095,16 @@ config MFD_SPMI_PMIC
> >         Say M here if you want to include support for the SPMI PMIC
> >         series as a module.  The module will be called "qcom-spmi-pmic".
> >
> > +config MFD_SY7636A
> > +     tristate "Silergy SY7636A voltage regulator"
> > +     depends on I2C
> > +     select MFD_SIMPLE_MFD_I2C
> > +     help
> > +       Enable support for Silergy SY7636A voltage regulator.
> > +
> > +       To enable support for building sub-devices as modules,
> > +       choose M here.
> > +
> >   config MFD_RDC321X
> >       tristate "RDC R-321x southbridge"
> >       select MFD_CORE
> > @@ -1202,7 +1212,7 @@ config MFD_SI476X_CORE
> >         module will be called si476x-core.
> >
> >   config MFD_SIMPLE_MFD_I2C
> > -     tristate "Simple Multi-Functional Device support (I2C)"
> > +     tristate
> >       depends on I2C
> >       select MFD_CORE
> >       select REGMAP_I2C
> > diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> > index 5ef2306fce04..c8ce6e5eea24 100644
> > --- a/drivers/regulator/Kconfig
> > +++ b/drivers/regulator/Kconfig
> > @@ -1219,6 +1219,7 @@ config REGULATOR_STW481X_VMMC
> >
> >   config REGULATOR_SY7636A
> >       tristate "Silergy SY7636A voltage regulator"
> > +     depends on MFD_SY7636A
> >       help
> >         This driver supports Silergy SY3686A voltage regulator.
> >
>
Lee Jones April 21, 2022, 8:07 a.m. UTC | #3
On Wed, 20 Apr 2022, Alistair Francis wrote:

> On Thu, Mar 31, 2022 at 6:02 AM Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > On 3/30/22 02:41, Alistair Francis wrote:
> > > Add a specific MFD_SY7636A config option.
> > >
> > > As part of this change we can use MFD_SY7636A as a dependency for all
> > > SY7636a components and also remove the name from MFD_SIMPLE_MFD_I2C as
> > > it no longer needs to be selectable.
> > >
> > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> >
> > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> Any chance of getting this in for 5.18? It would be nice to have the
> configs all sorted before the release

Can't do anything without Mark's Ack.
Alistair Francis May 24, 2022, 11:55 a.m. UTC | #4
On Thu, Apr 21, 2022 at 6:07 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Wed, 20 Apr 2022, Alistair Francis wrote:
>
> > On Thu, Mar 31, 2022 at 6:02 AM Guenter Roeck <linux@roeck-us.net> wrote:
> > >
> > > On 3/30/22 02:41, Alistair Francis wrote:
> > > > Add a specific MFD_SY7636A config option.
> > > >
> > > > As part of this change we can use MFD_SY7636A as a dependency for all
> > > > SY7636a components and also remove the name from MFD_SIMPLE_MFD_I2C as
> > > > it no longer needs to be selectable.
> > > >
> > > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > >
> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> >
> > Any chance of getting this in for 5.18? It would be nice to have the
> > configs all sorted before the release
>
> Can't do anything without Mark's Ack.

Can this be included in 5.19? I can re-send the series if required

Alistair

>
> --
> Lee Jones [李琼斯]
> Principal Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
Mark Brown May 24, 2022, 12:42 p.m. UTC | #5
On Tue, May 24, 2022 at 09:55:37PM +1000, Alistair Francis wrote:
> On Thu, Apr 21, 2022 at 6:07 PM Lee Jones <lee.jones@linaro.org> wrote:
> > On Wed, 20 Apr 2022, Alistair Francis wrote:

> > > Any chance of getting this in for 5.18? It would be nice to have the
> > > configs all sorted before the release

> > Can't do anything without Mark's Ack.

> Can this be included in 5.19? I can re-send the series if required

Please don't send content free pings, please resubmit patches if you
think they've been dropped on the floor (which is probably what happened
here, but I don't have context any more for what it is).  Content free
pings require people to go digging through mail archives to find out
what you're asking about, if they're even online and able to do so at
the time they look at your mail.
diff mbox series

Patch

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 68a8a27ab3b7..74b60d24e740 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1693,6 +1693,7 @@  config SENSORS_SIS5595
 
 config SENSORS_SY7636A
 	tristate "Silergy SY7636A"
+	depends on MFD_SY7636A
 	help
 	  If you say yes here you get support for the thermistor readout of
 	  the Silergy SY7636A PMIC.
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 3b59456f5545..c47cb755757b 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1095,6 +1095,16 @@  config MFD_SPMI_PMIC
 	  Say M here if you want to include support for the SPMI PMIC
 	  series as a module.  The module will be called "qcom-spmi-pmic".
 
+config MFD_SY7636A
+	tristate "Silergy SY7636A voltage regulator"
+	depends on I2C
+	select MFD_SIMPLE_MFD_I2C
+	help
+	  Enable support for Silergy SY7636A voltage regulator.
+
+	  To enable support for building sub-devices as modules,
+	  choose M here.
+
 config MFD_RDC321X
 	tristate "RDC R-321x southbridge"
 	select MFD_CORE
@@ -1202,7 +1212,7 @@  config MFD_SI476X_CORE
 	  module will be called si476x-core.
 
 config MFD_SIMPLE_MFD_I2C
-	tristate "Simple Multi-Functional Device support (I2C)"
+	tristate
 	depends on I2C
 	select MFD_CORE
 	select REGMAP_I2C
diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 5ef2306fce04..c8ce6e5eea24 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -1219,6 +1219,7 @@  config REGULATOR_STW481X_VMMC
 
 config REGULATOR_SY7636A
 	tristate "Silergy SY7636A voltage regulator"
+	depends on MFD_SY7636A
 	help
 	  This driver supports Silergy SY3686A voltage regulator.