| Message ID | 20220331194526.52444-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | pinctrl: samsung: staticize fsd_pin_ctrl | expand |
>-----Original Message----- >From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] >Sent: Friday, April 1, 2022 1:15 AM >To: Tomasz Figa <tomasz.figa@gmail.com>; Krzysztof Kozlowski ><krzk@kernel.org>; Sylwester Nawrocki <s.nawrocki@samsung.com>; Alim >Akhtar <alim.akhtar@samsung.com>; Linus Walleij <linus.walleij@linaro.org>; >Ajay Kumar <ajaykumar.rs@samsung.com>; linux-arm- >kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- >gpio@vger.kernel.org; linux-kernel@vger.kernel.org >Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; kernel test robot ><lkp@intel.com> >Subject: [PATCH] pinctrl: samsung: staticize fsd_pin_ctrl > >struct fsd_pin_ctrl is not used outside of the file, so it can be made static. This >fixes sparse warning: > > drivers/pinctrl/samsung/pinctrl-exynos-arm64.c:773:31: sparse: > symbol 'fsd_pin_ctrl' was not declared. Should it be static? > >Reported-by: kernel test robot <lkp@intel.com> >Fixes: 0d1b662c374c ("pinctrl: samsung: add FSD SoC specific data") >Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >--- Thanks Krzysztof. Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > drivers/pinctrl/samsung/pinctrl-exynos-arm64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c >b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c >index d291819c2f77..cb965cf93705 100644 >--- a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c >+++ b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c >@@ -770,7 +770,7 @@ static const struct samsung_pin_bank_data >fsd_pin_banks2[] __initconst = { > EXYNOS850_PIN_BANK_EINTN(3, 0x00, "gpq0"), }; > >-const struct samsung_pin_ctrl fsd_pin_ctrl[] __initconst = { >+static const struct samsung_pin_ctrl fsd_pin_ctrl[] __initconst = { > { > /* pin-controller instance 0 FSYS0 data */ > .pin_banks = fsd_pin_banks0, >-- >2.32.0
On Thu, 31 Mar 2022 21:45:26 +0200, Krzysztof Kozlowski wrote: > struct fsd_pin_ctrl is not used outside of the file, so it can be made > static. This fixes sparse warning: > > drivers/pinctrl/samsung/pinctrl-exynos-arm64.c:773:31: sparse: > symbol 'fsd_pin_ctrl' was not declared. Should it be static? > > > [...] Applied, thanks! [1/1] pinctrl: samsung: staticize fsd_pin_ctrl commit: abb860ac7e3f022a233f34b12d035d49abfc114d Best regards,
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c index d291819c2f77..cb965cf93705 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c @@ -770,7 +770,7 @@ static const struct samsung_pin_bank_data fsd_pin_banks2[] __initconst = { EXYNOS850_PIN_BANK_EINTN(3, 0x00, "gpq0"), }; -const struct samsung_pin_ctrl fsd_pin_ctrl[] __initconst = { +static const struct samsung_pin_ctrl fsd_pin_ctrl[] __initconst = { { /* pin-controller instance 0 FSYS0 data */ .pin_banks = fsd_pin_banks0,
struct fsd_pin_ctrl is not used outside of the file, so it can be made static. This fixes sparse warning: drivers/pinctrl/samsung/pinctrl-exynos-arm64.c:773:31: sparse: symbol 'fsd_pin_ctrl' was not declared. Should it be static? Reported-by: kernel test robot <lkp@intel.com> Fixes: 0d1b662c374c ("pinctrl: samsung: add FSD SoC specific data") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/pinctrl/samsung/pinctrl-exynos-arm64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)