From patchwork Sat Apr 2 04:03:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Liu Ying X-Patchwork-Id: 12798926 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66BB7C433F5 for ; Sat, 2 Apr 2022 04:19:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G4xTiZJdxTSBbw1JxrsXxbpytXTFpj1eLFqVbVpSS88=; b=pVmGp46SsPliyV yVU1aYzbFnhAcOq3K8t1kkQiCNpAV6b15jt9+gL39cNz0QxXAiRr/MPfq6xp/6vTc5XL2HNs1g6xd 71HapCt8lKW8fvhFSQT+fQ/CxB0yeZy9cuhxK7HS0o3Q2qeyCiG/tjnOA7H2cYBumafhhROMI96Yk hCmb5BhTQLKFQEK7ojE4qn6clP0aHjt2BDXhbYTWXWZhMe58sXySte9jgY4gpf/YJFk7gt0Vga3CQ rkNGh2CkO4owksOV9nXbhlKAoaBxkoKyHHP0UNNPRwBpfaH4gglPOp5nY6YXBV8gsQJ+sOpIVru4w P4gjSrGBJOb+Ajk7I5Sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naVD9-007uyC-Er; Sat, 02 Apr 2022 04:18:03 +0000 Received: from mail-ve1eur02on062c.outbound.protection.outlook.com ([2a01:111:f400:fe06::62c] helo=EUR02-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1naVD6-007uwa-AB for linux-arm-kernel@lists.infradead.org; Sat, 02 Apr 2022 04:18:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lmop5kzwaqaqbIr0mjppc2dffhyf3PgOpLBSFAaF8Ix0FNnXHeqzaKhUEhGIkGdiLOKImHe85iBIuQ66GNM6LI5rRU03JmxdOztfoKLstlq29PswNfckHjiHtvEg9Z7mxbSOgVV73Bsv473A5FjqHvlcHBUOGEUwyNz+9cwaZGdtNWAmwz7VkyTVw54YiPpcLqxaZaGvCS2ZqB4FBu0U0Gvb/ZnjL5k4kTZRoYlNPH3R+VuI3k0N9b/hm0cSwRWh48jhTsLuTYWPSQ6MRAfH5bLx71YKMeLPhPgi1WQYT6OACN/IcG4DkAoCyiItjl37UKBhiZkGuXrgm+l44n5ldg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E2iyT4vCBQVYLhhj2DqdYLsq/1RQuVjwDOOXOq7s36Q=; b=SEO6zNCtylTOHoSH+zlMepS7YfMt3wH1Hp6uVjIzURCUoRe1DNN4WXYRnrpHHQiizBKzOryNjcpkJ37c+fls6TDyD44lT07WxH3FhIf8QB643++3Sw153T5OTFxp+ylq/QNwPo6ZAnhy/f0Vd9fGdYD+B7MUKwWp+hysBYv0yzbVPQXrwJze09OH1pfj6ioSBhpOouUOSvZ99lTjNGNdnCAqEWYdbbXvEBI6qeXYMOgM0rRE+TBakYrzcBBge8jvvinwvS71tNpmQ81QOPC2Ngmrin/4HH29DHP/8+HASPeliZVhAZGbSC6tWm/ZxmklYoUZIIg6FpRJTDY0iR7XYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E2iyT4vCBQVYLhhj2DqdYLsq/1RQuVjwDOOXOq7s36Q=; b=JlQMhSfl0TyLcAlMLsx9i9e75UWwGG7KwUk3uO7rMIKuQ3LV2cn3b8OCMFRalVOUGyRmcSLjS0YO6AJEsJTs5Ru6foKxmXfVYxtfeLpGEfLpOId+dq3SrnU4ibj/r/hzNexP3GiWO9I6UZTH3ylJKHo/jHC/JOmrujt70RQszvg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by HE1PR04MB3210.eurprd04.prod.outlook.com (2603:10a6:7:1e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.30; Sat, 2 Apr 2022 04:02:01 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::b09c:8ffe:8e02:7387]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::b09c:8ffe:8e02:7387%9]) with mapi id 15.20.5123.030; Sat, 2 Apr 2022 04:02:01 +0000 From: Liu Ying To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Cc: kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org, a.hajda@samsung.com, narmstrong@baylibre.com, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@siol.net, airlied@linux.ie, daniel@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, agx@sigxcpu.org, robert.chiras@nxp.com, martin.kepplinger@puri.sm, robert.foss@linaro.org Subject: [PATCH v6 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set() Date: Sat, 2 Apr 2022 12:03:21 +0800 Message-Id: <20220402040325.2465222-2-victor.liu@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220402040325.2465222-1-victor.liu@nxp.com> References: <20220402040325.2465222-1-victor.liu@nxp.com> X-ClientProxiedBy: SGAP274CA0011.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::23) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6f9c4514-a55d-410b-b8c3-08da145d8a6a X-MS-TrafficTypeDiagnostic: HE1PR04MB3210:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EsKRtzcGeZAi13BrROwOuTn+2oEwrbnLt8AYhVZHZ/yniufdNadhiXEtjUzEKZEu8YMudMBHdeoDeoykYuaFJ87Y9YW3pVXgJMjN/eJIyKPxNzeh7TE02m/SVp3Cq0CKSy9kFtP7G4Be9JvxYJ+QTiI+Jq5xGCqr9JjFdE/Agm8H71xFWhL6ryPWFKWtNqe/mFTAdflJOuUeUW6ObnBZqEVIjXgsZyDVTwXLT1PlNNsRAa6liTSeH5VRXnoszfPWTesbzwJroLI4Ljyw2TtHkynyaLKShpU6ikEXh/9SQp7EWVKgfmJkzSszcgfBJXMGAUsq4YLUfZLSJsRrhV8UQC7Kgvo9D+Fd5W07Nffu8w+JYPz6/2sfFPNUAtPadvNWCu0sX66W9BTApmObG/I6uKb7SA/uZfDl0l0D8LYin/4Vz3XyD5GBnD8PzB0j+/TMnNtqjH5++zS/wX/n30TtpciFpWmuniFP3hLZUi3r87kgYMBDWaEFYkeU5OOT1udjmD1pc34nZQpA2r80xf5Kg6wj8dAcnL9Kem9mVEq3gT12H6k+cOBmbE6+hBGwCAOJqn6bRkf0wOCGfB3URIlIccoMy7ceNeysJTDlWP20OVpCK3vefXKJCChBlzNQZOkJ93nGlgB8FnlEr4vmwAhVD0AbpcoQJFQoJQG259Y/kA+L6zXrPttxshaOB4Qxv9S80lZbrMt2tW/qs0zLvXi61A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR04MB7046.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(86362001)(6512007)(186003)(26005)(2616005)(1076003)(4326008)(8676002)(66946007)(38350700002)(66556008)(66476007)(38100700002)(2906002)(36756003)(7416002)(5660300002)(8936002)(508600001)(52116002)(6486002)(6666004)(6506007)(316002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?2rtoNEyxEHt9J4rgJkSBHmEvh42E?= =?utf-8?q?1/nc88oHLG7UhMeaOC4EY8XgsLnOKiLLKOfR4jNLtO25TF25s0k/0qDZFfA0XXXWe?= =?utf-8?q?7iQE2tjI+1i/8g5UoOXPiAQg/g1Yzvj6z2Ub4YP43iYhDathfCe3FTnV6a3FthlKO?= =?utf-8?q?a/kOC+w0QLNodsr+RhjT4jMBZDfYmxgtjgN3FTrH/bM5aekY3uAFMjltlXh9ZAwca?= =?utf-8?q?KBYjSECXrBoFYj5dllZVvqTnB6ZDkD7HdcoEmItQpJRx8GmRVCJ9dTWDmjW1XUdzH?= =?utf-8?q?H72HowNc7WqHjRRF8IxFICAb6gvyz+2Qs4vmqGaxL+1jUF+RNCbrZ2P3O3aSbr/HF?= =?utf-8?q?vVSjzf2Nru3mQLn4jmSI0kF9JmlyuabbJl204fvGaFCFToafQCWWwykM0s4tYNVlo?= =?utf-8?q?AjlrsH7z5bzBxTQb/F53t4T+vb1QbwpQcbYd9A99oagQX5CPCkcdVSj7FJrtOFlqi?= =?utf-8?q?5yCHydQ7BmpoV9Tu+96HKDqNL8/4Q0kvEB7AEr2gFv+5LZkbONDAZ2EQigZzAJmuP?= =?utf-8?q?qV/a7pVa0le4RnP91yi4EiI4UeWvr4tUtqCRVGkq4AEtvWzLMraVWQQRRlY4ZoLYV?= =?utf-8?q?Gq9LKTo9hE7ta71G9bSsDu8F9dFsfe+hvL/jYchImPQ1ndZdfmLWZa1xjhd4odTho?= =?utf-8?q?WkZXL7YBFHbxgOCUW0T+iin1IEyxYDEEH9UQt9fahrlQJ/tgIwoN0urPtH1/hJ7H2?= =?utf-8?q?jEDGD3UOMgK6BmoIYipuJsvV+0TOD+l2AITt+z3EDwyjfuyuAbxabpk7Z/LQWcrZi?= =?utf-8?q?tG5+eH9jRy2Q5P26EA2GjT1nbUK6SfcrEMoHenV9ZFas66I5OGV4YXtxc96U0cw5r?= =?utf-8?q?IqEDK11BAtCqzHWEEfOM7ayRM9nkm6AbaEZ1hNiStmxd9vxUqL7ehMDjaghnxC6/V?= =?utf-8?q?R1kACOcUmt7XW1L+p/1nRw0EnQZse6j/gG0LjMOn/rYBValIZPH9FcTsfpmVQOoWh?= =?utf-8?q?o9rZsvFEeLonFzbvSyOvRa39jLvwIsZfP74MfAkydwf3LNkttldXjhCjlGlV3KkBn?= =?utf-8?q?z7FxXqUKqrvhg4TXYzsdgZEfylXjMYy5vEyvFFH2TsBAwixtaCEulk2o+O8OkostW?= =?utf-8?q?AYR9deRjmZHvZfPjhZ8pRfI1Ma9su7LU3DsbPRjSvB1aQjME1Lt2zc8ewEpwRHG50?= =?utf-8?q?H6Vp5nvA+eCUZI3sptrSqrWAivVA55tvQ03NJo4v7PN4v/yvobHnqneYtPMFQ0S7q?= =?utf-8?q?fwSLM4wxNUM/RYPtaIqvvY9Awbk5ALhSD+wZzzUtKgNloTrN+ztu57e1XguOSX2Hv?= =?utf-8?q?ikuSE0En79FkPYoYOn0VXXTv6RJpenbg+bUH+JISES8R+WSaKXeeLYE2LYIB1RZZd?= =?utf-8?q?CeG8s/TQ9vDrj66Y4v/pJShfMmg76V95E0+bJq/ywzGENuztC0g9484y6PFURzmFP?= =?utf-8?q?b0b6YWTIm9b83mDLKMiZF3A5HOVUbjJis+fdmqOH4iZ1StfyxAQrTYD9/38JIqshw?= =?utf-8?q?4L3sCMQ6lDpvhBRm84dxC1MQUEFrKu4WprFwjO9nV/ZWr88Yew8aXtp4HtEiev4X/?= =?utf-8?q?al1K16Fmor+4FqR644hQFyK5rDxrOdZZCJbTi/X4ppg2TYhzsPfmvaQdSfvnjQd8a?= =?utf-8?q?g/NrckMWoao/PGPb4eO/EpgdF9VGvnoV5hI1Vk6eZw+ZqcgGsiCzufMTc7o9wa2mr?= =?utf-8?q?c9rQM0A2fTFjY+6VNnreB/eoYZiI8gTA=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f9c4514-a55d-410b-b8c3-08da145d8a6a X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2022 04:02:01.5309 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bvf7ozu6VZ8OZ5D++N9MYyk1nIlbHQtpcKxwa2K/rG1xLcu6L09XG2ehqVlfa0J0xt4bSPP8br0DEksL3xySoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3210 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_211800_383345_544D521E X-CRM114-Status: GOOD ( 12.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp works with a Mixel MIPI DPHY + LVDS PHY combo to support either a MIPI DSI display or a LVDS display. So, this patch calls phy_set_mode() from nwl_dsi_mode_set() to set PHY mode to MIPI DPHY explicitly. Cc: Guido Günther Cc: Robert Chiras Cc: Martin Kepplinger Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: NXP Linux Team Signed-off-by: Liu Ying --- v5->v6: * Rebase the series upon v5.17-rc1. * Set PHY mode in ->mode_set() instead of ->pre_enable() in the nwl-dsi bridge driver due to the rebase. * Drop Guido's R-b tag due to the rebase. v4->v5: * No change. v3->v4: * No change. v2->v3: * No change. v1->v2: * Add Guido's R-b tag. drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c index af07eeb47ca0..cbe3edb17ceb 100644 --- a/drivers/gpu/drm/bridge/nwl-dsi.c +++ b/drivers/gpu/drm/bridge/nwl-dsi.c @@ -671,6 +671,12 @@ static int nwl_dsi_mode_set(struct nwl_dsi *dsi) return ret; } + ret = phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY); + if (ret < 0) { + DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n", ret); + goto uninit_phy; + } + ret = phy_configure(dsi->phy, phy_cfg); if (ret < 0) { DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", ret);