From patchwork Sun Apr 3 14:02:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 12799610 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CC29C433EF for ; Sun, 3 Apr 2022 14:04:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=MVr4KNuc/0WeX2xCCGJ4A8fgx1SDkfLLSOCR3Rag6RU=; b=FDNryzs7BYd/XD 8vt6+uyKpXasRyF5puh6Seep+on1YYzmh4Gm9orMYRYZ1vvWMhJjxUdNPdVRw70E+4Qo7aNsuOdP3 lhfj4mOToFuBAjZ80lsxpcMnzXG/0BPwvfCwKvzVWXgzVIaLBQN4iTrNPekxO6BLFQjyWoS+/bFZa UiqhwZVtx2N/zMRN2z4N9Wyd4i8d8rgHWchSn/MsTMGZvvG94c4tGYTqrBXK3I1ap1jESyNgo60zT 1MvCAnKoiabEzgFNDaDLHZwB74iUzHccIvnXayV7cd/zcmyu5MLM315n4llmlGnx9WsNXAXxMskyk qiPOP42pbQWOdrDa1erQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nb0oI-00BZ2r-OI; Sun, 03 Apr 2022 14:02:30 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nb0oF-00BZ1k-Ul for linux-arm-kernel@lists.infradead.org; Sun, 03 Apr 2022 14:02:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648994543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IgMX2nj2cNExGiU4IHmGwPOWMy+mYsJ+4MxIjrhMhLQ=; b=IUK67A5JGdDj6SFvTU2o1CJoZA6bocPffQciGy8gHb1xuUAjN45R7MIEbq7QkGUUspijjf BUXSsSpOq+r6IemLm53N2FVhy5BxkUxQ9+6fGKrHO5jrG1GioFgWJnBz0GobMUeWE44z9J JBHcBEZ48mX8dvxqLAdxK3/NopoajNI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-182-cV04TPiZN7iAhLwGpOi9pQ-1; Sun, 03 Apr 2022 10:02:15 -0400 X-MC-Unique: cV04TPiZN7iAhLwGpOi9pQ-1 Received: by mail-wm1-f69.google.com with SMTP id c62-20020a1c3541000000b003815245c642so5581675wma.6 for ; Sun, 03 Apr 2022 07:02:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IgMX2nj2cNExGiU4IHmGwPOWMy+mYsJ+4MxIjrhMhLQ=; b=nQXHYH00EfhHB+GwJjKIwVCYvhhhoGIAVcaX69tkXWVP9WEy24HN7NLDGvV2ZvyVJb xD6jZhqomROJpf8EDh/wmRVuoKj28CuDRKo2vNlN6tlw4fKIX7i2ozFpbbJe8AfPN4QJ OmF7Gag3/F/1SzHUCgtaKJp+RqYOMJVAygdYoX9xNLXO2DPuSGDA7DmKh/h3cMJcpic0 TXhCq2ZBYDYoXLMl7HHbdxEVr6gbs1FLQ+iBBj05fuBjfDK+rHKfA/YPPtxgrMOQ+a5c /7e/4cRZogLnJjJU5BeuDRoZVatZS5/kM/LiQ9BbQ2uLOhX+H1KAdmmyfzbE671xwoGg A5oQ== X-Gm-Message-State: AOAM530yKM1YfiulLDdlufz6A9iKkgWyfxksPHW1e8haUIzSZRev8v82 /LCcW4KtgEgEzydd1sKpFQpZyP6ojQSpGqNLMuKN9Wk6NxuqExgaYV2UpOQgJ7GoUaDPQjeTvgc UvSfFnq8b/BnHru1pmvhQJ86VcPrA7SN12w0= X-Received: by 2002:a5d:40c8:0:b0:205:2a3b:c2c with SMTP id b8-20020a5d40c8000000b002052a3b0c2cmr14072341wrq.13.1648994534314; Sun, 03 Apr 2022 07:02:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwz8TWqYImcP6rcwIhAkGMXujAFPtHd1mtW4Epczq6oGwMPXw022V6Oc/3xXzJvj9XSl1FGwA== X-Received: by 2002:a5d:40c8:0:b0:205:2a3b:c2c with SMTP id b8-20020a5d40c8000000b002052a3b0c2cmr14072332wrq.13.1648994534137; Sun, 03 Apr 2022 07:02:14 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id k9-20020adfb349000000b00206101fc58fsm914374wrd.110.2022.04.03.07.02.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Apr 2022 07:02:13 -0700 (PDT) From: Tom Rix To: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] stmmac: dwmac-loongson: change loongson_dwmac_driver from global to static Date: Sun, 3 Apr 2022 10:02:02 -0400 Message-Id: <20220403140202.2191516-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220403_070228_089414_D33D765F X-CRM114-Status: GOOD ( 13.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Smatch reports this issue dwmac-loongson.c:208:19: warning: symbol 'loongson_dwmac_driver' was not declared. Should it be static? loongson_dwmac_driver is only used in dwmac-loongson.c. File scope variables used only in one file should be static. Change loongson_dwmac_driver's storage-class-specifier from global to static. Signed-off-by: Tom Rix --- drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c index ecf759ee1c9f..017dbbda0c1c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c @@ -205,7 +205,7 @@ static const struct pci_device_id loongson_dwmac_id_table[] = { }; MODULE_DEVICE_TABLE(pci, loongson_dwmac_id_table); -struct pci_driver loongson_dwmac_driver = { +static struct pci_driver loongson_dwmac_driver = { .name = "dwmac-loongson-pci", .id_table = loongson_dwmac_id_table, .probe = loongson_dwmac_probe,