diff mbox series

[v1,1/2] arm64: vdso: put ELF related sections in the linker script

Message ID 20220405160246.1991-2-joey.gouly@arm.com (mailing list archive)
State New, archived
Headers show
Series Enable orphan-handling=warn for VDSO | expand

Commit Message

Joey Gouly April 5, 2022, 4:02 p.m. UTC 
These are the same sections as ELF_DETAILS in include/asm-generic/vmlinux.lds.h

Signed-off-by: Joey Gouly <joey.gouly@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: Kees Cook <keescook@chromium.org>
---
 arch/arm64/kernel/vdso/vdso.lds.S | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Kees Cook April 5, 2022, 5:41 p.m. UTC | #1 
On Tue, Apr 05, 2022 at 05:02:45PM +0100, Joey Gouly wrote:
> These are the same sections as ELF_DETAILS in include/asm-generic/vmlinux.lds.h

Can include/asm-generic/vmlinux.lds.h be included to just use
ELF_DETAILS directly?

Outside of that, yeah, this series looks good. Thanks!

-Kees

> 
> Signed-off-by: Joey Gouly <joey.gouly@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Cc: Kees Cook <keescook@chromium.org>
> ---
>  arch/arm64/kernel/vdso/vdso.lds.S | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/kernel/vdso/vdso.lds.S b/arch/arm64/kernel/vdso/vdso.lds.S
> index a5e61e09ea92..e453e74e98f9 100644
> --- a/arch/arm64/kernel/vdso/vdso.lds.S
> +++ b/arch/arm64/kernel/vdso/vdso.lds.S
> @@ -54,6 +54,11 @@ SECTIONS
>  	_end = .;
>  	PROVIDE(end = .);
>  
> +	.comment 0 : { *(.comment) }
> +	.symtab 0 : { *(.symtab) }
> +	.strtab 0 : { *(.strtab) }
> +	.shstrtab 0 : { *(.shstrtab) }
> +
>  	/DISCARD/	: {
>  		*(.data .data.* .gnu.linkonce.d.* .sdata*)
>  		*(.bss .sbss .dynbss .dynsbss)
> -- 
> 2.17.1
>
diff mbox series

Patch

diff --git a/arch/arm64/kernel/vdso/vdso.lds.S b/arch/arm64/kernel/vdso/vdso.lds.S
index a5e61e09ea92..e453e74e98f9 100644
--- a/arch/arm64/kernel/vdso/vdso.lds.S
+++ b/arch/arm64/kernel/vdso/vdso.lds.S
@@ -54,6 +54,11 @@  SECTIONS
 	_end = .;
 	PROVIDE(end = .);
 
+	.comment 0 : { *(.comment) }
+	.symtab 0 : { *(.symtab) }
+	.strtab 0 : { *(.strtab) }
+	.shstrtab 0 : { *(.shstrtab) }
+
 	/DISCARD/	: {
 		*(.data .data.* .gnu.linkonce.d.* .sdata*)
 		*(.bss .sbss .dynbss .dynsbss)