| Message ID | 20220407230503.1265036-2-irogers@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Tidy up symbol end fixup | expand |
Em Thu, Apr 07, 2022 at 04:04:59PM -0700, Ian Rogers escreveu: > If objdump writes to stderr it can block waiting for it to be read. As > perf doesn't read stderr then progress stops with perf waiting for > stdout output. Thanks, applied. - Arnaldo > Signed-off-by: Ian Rogers <irogers@google.com> > --- > tools/perf/util/annotate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c > index e4c641b240df..82cc396ef516 100644 > --- a/tools/perf/util/annotate.c > +++ b/tools/perf/util/annotate.c > @@ -2047,6 +2047,7 @@ static int symbol__disassemble(struct symbol *sym, struct annotate_args *args) > objdump_process.argv = objdump_argv; > objdump_process.out = -1; > objdump_process.err = -1; > + objdump_process.no_stderr = 1; > if (start_command(&objdump_process)) { > pr_err("Failure starting to run %s\n", command); > err = -1; > -- > 2.35.1.1178.g4f1659d476-goog
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index e4c641b240df..82cc396ef516 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -2047,6 +2047,7 @@ static int symbol__disassemble(struct symbol *sym, struct annotate_args *args) objdump_process.argv = objdump_argv; objdump_process.out = -1; objdump_process.err = -1; + objdump_process.no_stderr = 1; if (start_command(&objdump_process)) { pr_err("Failure starting to run %s\n", command); err = -1;
If objdump writes to stderr it can block waiting for it to be read. As perf doesn't read stderr then progress stops with perf waiting for stdout output. Signed-off-by: Ian Rogers <irogers@google.com> --- tools/perf/util/annotate.c | 1 + 1 file changed, 1 insertion(+)