From patchwork Tue Apr 12 15:48:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 12810903 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BEE9C433F5 for ; Tue, 12 Apr 2022 15:49:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:References: Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=7na4z3b76HvmyzJq/ix4mI10rOvfkJO4yX7sl6GRRu4=; b=w8cg01w27GEWDArRbUJMdeJOnw 5l1E/W8wd4TRIvktAK5RSmdXeP7FKfMwpPcfTe0J/ddvMbHscvGLZpe2cqMPN8lYf8FuETR4/KItC 2Zwg8IKmtQjY6KkGZK38Y1q5TGS3iJmSjiiW2mykBZ0dV58SqWaXJIznIdaeiDmJPUO+SBqzeB51o APn4rbuHFBetBE+bHvuaUagFRiUNq/3bWA0GLFstw2YFiIPhLNG59xwHwhdse7oNmqHjx9FwEBaqn lC5BlljZKmF2RzBO4a1eAT3D0zXC44VHVpEnCXKM9dRiboLzDXiRe8aazbTujFPYDiQYAajzVceBN q3ML/XHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neIkx-00Ezvl-As; Tue, 12 Apr 2022 15:48:39 +0000 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neIkm-00Ezni-Fl for linux-arm-kernel@lists.infradead.org; Tue, 12 Apr 2022 15:48:30 +0000 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-2ec12272fb2so56696007b3.6 for ; Tue, 12 Apr 2022 08:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=MNOrivzCB1IEcfUHpsPArN3av86pSVn5LI+JFeA009c=; b=Jxfcw41rIapSLBYY08oP79pW5QErfm0BlHMc9JOvIieL951+KQwxEyz9TwCoKjg5ia ti5O1h3vb0jWEPqVVl//CM9xr5kJ5zPlDjSWm+vWxVFjzTQBRAGF5u4FbK2UyoDSDkuj DS0FxeIAgTgE/ydppsuZWDV3puxDGvxQiY00VfHoimJhhNrx1mI7YG88+b0wdKV51Ifr BJznapmMQh2xGpvRKO/1uyO2wjRgvC2awCco39UmxwoZZjOV0NHOTYSqX+EC5Q4Y0vFw /xzhlk8w7udKnct+AFWq56O39PGQTRWntQjSn/cJKZt5HEA0zu7dpJG5iURk+3EDgf8F AoWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=MNOrivzCB1IEcfUHpsPArN3av86pSVn5LI+JFeA009c=; b=u/ERqStk+VQnsoGZdqOZtzshrF6lF1FGkCkUKtOqkJ6GqR4XaldSIpWatgyY7cKBCG B9mj/Oiylej4tK3NE+iVvF544lOb2o+OvKtogSHjSlx5r/v4Hjjhgj5jDBM/5NgIQQ37 gRyP90kwLEIjrbXXkDawXgjGnqwijZXeaAmAv9sNXYIu1xcSjM81g78rRguVt5Sgw2zt G7OYO0MK60Zwr/wgZDsh7kLoEkWFHTcJ11hi8MepNDsGqXvfJJNXaWOOduqSHMm9eyFA STTOeBuNwy6Cs7J3ZEa6sOpmQzwrlYuDrVAh0W4fd6v2Fe6NCtrBUKcbDD0LCG1g3u+3 splg== X-Gm-Message-State: AOAM530ETMwQQp/7RQpBvGWObVoNHQk4aBk1vVJOulj8ByYXzFfnr8nk kdwUA6Zzh6dxfzJuw5T+4lGgLh1kcp07 X-Google-Smtp-Source: ABdhPJwGRXJ4fhz3KDb9CRYJODouALMvz33H5HzPda/tm0sxnTSEU0EVIgx3og/+Sbbhdq3eUBWkMUmwdzDj X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:5f6f:a698:92a:5d45]) (user=irogers job=sendgmr) by 2002:a81:36cf:0:b0:2e5:2597:a026 with SMTP id d198-20020a8136cf000000b002e52597a026mr30798226ywa.301.1649778504446; Tue, 12 Apr 2022 08:48:24 -0700 (PDT) Date: Tue, 12 Apr 2022 08:48:14 -0700 In-Reply-To: <20220412154817.2728324-1-irogers@google.com> Message-Id: <20220412154817.2728324-2-irogers@google.com> Mime-Version: 1.0 References: <20220412154817.2728324-1-irogers@google.com> X-Mailer: git-send-email 2.35.1.1178.g4f1659d476-goog Subject: [PATCH v2 1/4] perf symbols: Always do architecture specific fixups From: Ian Rogers To: John Garry , Will Deacon , Mathieu Poirier , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Clark , Alexandre Truong , German Gomez , Ian Rogers , Dave Marchevsky , Song Liu , Ravi Bangoria , Li Huafei , " =?utf-8?q?Martin_Li=C5=A1ka?= " , William Cohen , Riccardo Mancini , Masami Hiramatsu , Thomas Richter , Lexi Shao , Remi Bernon , Michael Petlan , Denis Nikitin , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Stephane Eranian X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_084828_564833_2D1BD33F X-CRM114-Status: GOOD ( 17.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The change: https://lore.kernel.org/lkml/20220317135536.805-1-mpetlan@redhat.com/ modified the condition for architecture specific fixups motivated by a PowerPC case. So that architectures can independently modify their condition, move the if into the called architecture symbols__fixup_end function and always call it. --- tools/perf/arch/arm64/util/machine.c | 14 ++++++++------ tools/perf/arch/powerpc/util/machine.c | 14 ++++++++------ tools/perf/arch/s390/util/machine.c | 14 ++++++++------ tools/perf/util/symbol.c | 6 +++--- 4 files changed, 27 insertions(+), 21 deletions(-) diff --git a/tools/perf/arch/arm64/util/machine.c b/tools/perf/arch/arm64/util/machine.c index d2ce31e28cd7..1cc33b323c3f 100644 --- a/tools/perf/arch/arm64/util/machine.c +++ b/tools/perf/arch/arm64/util/machine.c @@ -20,13 +20,15 @@ void arch__symbols__fixup_end(struct symbol *p, struct symbol *c) { - if ((strchr(p->name, '[') && strchr(c->name, '[') == NULL) || + if (p->end == p->start || p->end != c->start) { + if ((strchr(p->name, '[') && strchr(c->name, '[') == NULL) || (strchr(p->name, '[') == NULL && strchr(c->name, '['))) - /* Limit range of last symbol in module and kernel */ - p->end += SYMBOL_LIMIT; - else - p->end = c->start; - pr_debug4("%s sym:%s end:%#" PRIx64 "\n", __func__, p->name, p->end); + /* Limit range of last symbol in module and kernel */ + p->end += SYMBOL_LIMIT; + else + p->end = c->start; + pr_debug4("%s sym:%s end:%#" PRIx64 "\n", __func__, p->name, p->end); + } } void arch__add_leaf_frame_record_opts(struct record_opts *opts) diff --git a/tools/perf/arch/powerpc/util/machine.c b/tools/perf/arch/powerpc/util/machine.c index e652a1aa8132..88a8abf98a57 100644 --- a/tools/perf/arch/powerpc/util/machine.c +++ b/tools/perf/arch/powerpc/util/machine.c @@ -16,10 +16,12 @@ void arch__symbols__fixup_end(struct symbol *p, struct symbol *c) { - if (strchr(p->name, '[') == NULL && strchr(c->name, '[')) - /* Limit the range of last kernel symbol */ - p->end += page_size; - else - p->end = c->start; - pr_debug4("%s sym:%s end:%#" PRIx64 "\n", __func__, p->name, p->end); + if (p->end == p->start || p->end != c->start) { + if (strchr(p->name, '[') == NULL && strchr(c->name, '[')) + /* Limit the range of last kernel symbol */ + p->end += page_size; + else + p->end = c->start; + pr_debug4("%s sym:%s end:%#" PRIx64 "\n", __func__, p->name, p->end); + } } diff --git a/tools/perf/arch/s390/util/machine.c b/tools/perf/arch/s390/util/machine.c index 7644a4f6d4a4..0b750738ec68 100644 --- a/tools/perf/arch/s390/util/machine.c +++ b/tools/perf/arch/s390/util/machine.c @@ -44,10 +44,12 @@ int arch__fix_module_text_start(u64 *start, u64 *size, const char *name) */ void arch__symbols__fixup_end(struct symbol *p, struct symbol *c) { - if (strchr(p->name, '[') == NULL && strchr(c->name, '[')) - /* Last kernel symbol mapped to end of page */ - p->end = roundup(p->end, page_size); - else - p->end = c->start; - pr_debug4("%s sym:%s end:%#" PRIx64 "\n", __func__, p->name, p->end); + if (p->end == p->start || p->end != c->start) { + if (strchr(p->name, '[') == NULL && strchr(c->name, '[')) + /* Last kernel symbol mapped to end of page */ + p->end = roundup(p->end, page_size); + else + p->end = c->start; + pr_debug4("%s sym:%s end:%#" PRIx64 "\n", __func__, p->name, p->end); + } } diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index dea0fc495185..394ad493c343 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -103,7 +103,8 @@ static int prefix_underscores_count(const char *str) void __weak arch__symbols__fixup_end(struct symbol *p, struct symbol *c) { - p->end = c->start; + if (p->end == p->start || p->end != c->start) + p->end = c->start; } const char * __weak arch__normalize_symbol_name(const char *name) @@ -231,8 +232,7 @@ void symbols__fixup_end(struct rb_root_cached *symbols) prev = curr; curr = rb_entry(nd, struct symbol, rb_node); - if (prev->end == prev->start || prev->end != curr->start) - arch__symbols__fixup_end(prev, curr); + arch__symbols__fixup_end(prev, curr); } /* Last entry */