From patchwork Thu Apr 14 00:23:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Holland X-Patchwork-Id: 12812809 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2334BC433EF for ; Thu, 14 Apr 2022 00:25:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OdShFI2o2nG1fsdyK+DJLxD3TIaN9v7XnqeV6Hqs2oQ=; b=KGw+2Aryn6agwq 0gTkOwzqI6u5W8+CA065PZGcO31NjBb3qDUFX9CFMo95PRCEVQbZx/gYTfqm3b/aGhknRJ0Bwtm6O p3IafMHH6kV8/iFXClQgYWxj/p5wDyXiV4ajC7JsRrnmNI3sxhWplY6kZFsreGfjM6hFWVCLoZzuI E/Etp8CsBJ0ZBaiavyok7q5xvzYpSq95VJxA9f4dB7BbJsFrDwmweeP0VON0gjUtSalm7LIxTj5Om ukENMF2upebMyzVBsm4VAhTdhdUnI60pfiygwmQ3A811AMyZB08bxi7vzOMCV9VM0yQekhDwBMTNL ga1gVKvXelEZZVpx41fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nenHX-003AM6-Db; Thu, 14 Apr 2022 00:24:19 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nenHB-003AEv-PC for linux-arm-kernel@lists.infradead.org; Thu, 14 Apr 2022 00:24:00 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A77305C02D9; Wed, 13 Apr 2022 20:23:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 13 Apr 2022 20:23:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1649895834; x=1649982234; bh=UX 20EKkihaXFR6pu5BIT9N5isu1yVemyQBEm7qLnXTM=; b=tlIfJ8zhf44HVqPslI tmi6bD4D8Z/oy9dnNqpGqRAbI1cvqmVi+17zGR29X+Qz+9JtWHmquBgNO11GQsDv dbsXyqhwab/xcr5XmJLe290aq9Hy+vQ4N6zDWhgEiDMgWE3WpRE3WaPTdq/ofGZk HlFSVxc3cSXDaSLuoF/v+fvM/WX2XOXNKwNIOxcbdqSjIdcEiFInTBRUN8kQuLwC Io8J3tZsAwMDg1CquG+yNpAIoo02lOV8aloZZ8ZxL6hMtpOjbXPzqwfUt6ehfB1q Hba6Kq2f6hBqFm1l4GfPHJVa4Eup3Pg8h9HWqycOcrYGI/yovLficthOKafy2sdY Ln+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1649895834; x=1649982234; bh=UX20EKkihaXFR6pu5BIT9N5isu1yVemyQBE m7qLnXTM=; b=dkenoMvsI7QjPiyaUzBeHoLYbRgzMX3BdkzHKcnms+wY76m4ULu GN3ijxMGOPw9MJSPB0V3S1WG1GWabBW+5CqgduIsBfrcpSKI311pvZbC9PWg6Fge biNuKA9kegpO/gdcp8vMp3MJ9L9pWKFVo7XOj2/adub6ZaK/9bQkTGTXzv/atwak yquaOtkeJQrXjpTreb8Lj0TmgrxVqWnmdu4sLOrNXoAyEaCuoXcTS/4fAFok4IiK toFrGbDJA6tuK7nGPLAf512qlzHJEwu+KzjDbDF29393U+YMQb9fB3lxl9EbM2AD 1uhh0Wk2UNo0AzJvNGz7VqWp6wVQoRqlxVA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudelvddgfeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefurghmuhgv lhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenucggtf frrghtthgvrhhnpeduhfejfedvhffgfeehtefghfeiiefgfeehgfdvvdevfeegjeehjedv gfejheeuieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Apr 2022 20:23:53 -0400 (EDT) From: Samuel Holland To: Dmitry Torokhov , Hans de Goede Cc: Samuel Holland , Maxime Ripard , Rob Herring , Chen-Yu Tsai , Jernej Skrabec , Krzysztof Kozlowski , Maxime Ripard , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Philipp Zabel Subject: [PATCH v2 2/3] Input: sun4i-lradc-keys: Add optional clock/reset support Date: Wed, 13 Apr 2022 19:23:47 -0500 Message-Id: <20220414002349.24332-2-samuel@sholland.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220414002349.24332-1-samuel@sholland.org> References: <20220414002349.24332-1-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220413_172357_976138_FED880AE X-CRM114-Status: GOOD ( 17.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Until the R329, the LRADC hardware was always active. Now it requires enabling a clock gate and deasserting a reset line. Add support for this variant of the hardware. Signed-off-by: Samuel Holland Acked-by: Jernej Skrabec --- Changes in v2: - Guard the code with a flag instead of using "_optional" variants. drivers/input/keyboard/sun4i-lradc-keys.c | 33 +++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/drivers/input/keyboard/sun4i-lradc-keys.c b/drivers/input/keyboard/sun4i-lradc-keys.c index 4a796bed48ac..5630334a6c09 100644 --- a/drivers/input/keyboard/sun4i-lradc-keys.c +++ b/drivers/input/keyboard/sun4i-lradc-keys.c @@ -14,6 +14,7 @@ * there are no boards known to use channel 1. */ +#include #include #include #include @@ -23,6 +24,7 @@ #include #include #include +#include #include #define LRADC_CTRL 0x00 @@ -58,10 +60,12 @@ /* struct lradc_variant - Describe sun4i-a10-lradc-keys hardware variant * @divisor_numerator: The numerator of lradc Vref internally divisor * @divisor_denominator: The denominator of lradc Vref internally divisor + * @has_clock_reset: If the binding requires a clock and reset */ struct lradc_variant { u8 divisor_numerator; u8 divisor_denominator; + bool has_clock_reset; }; static const struct lradc_variant lradc_variant_a10 = { @@ -83,6 +87,8 @@ struct sun4i_lradc_data { struct device *dev; struct input_dev *input; void __iomem *base; + struct clk *clk; + struct reset_control *reset; struct regulator *vref_supply; struct sun4i_lradc_keymap *chan0_map; const struct lradc_variant *variant; @@ -140,6 +146,14 @@ static int sun4i_lradc_open(struct input_dev *dev) if (error) return error; + error = reset_control_deassert(lradc->reset); + if (error) + goto err_disable_reg; + + error = clk_prepare_enable(lradc->clk); + if (error) + goto err_assert_reset; + lradc->vref = regulator_get_voltage(lradc->vref_supply) * lradc->variant->divisor_numerator / lradc->variant->divisor_denominator; @@ -153,6 +167,13 @@ static int sun4i_lradc_open(struct input_dev *dev) writel(CHAN0_KEYUP_IRQ | CHAN0_KEYDOWN_IRQ, lradc->base + LRADC_INTC); return 0; + +err_assert_reset: + reset_control_assert(lradc->reset); +err_disable_reg: + regulator_disable(lradc->vref_supply); + + return error; } static void sun4i_lradc_close(struct input_dev *dev) @@ -164,6 +185,8 @@ static void sun4i_lradc_close(struct input_dev *dev) SAMPLE_RATE(2), lradc->base + LRADC_CTRL); writel(0, lradc->base + LRADC_INTC); + clk_disable_unprepare(lradc->clk); + reset_control_assert(lradc->reset); regulator_disable(lradc->vref_supply); } @@ -243,6 +266,16 @@ static int sun4i_lradc_probe(struct platform_device *pdev) return -EINVAL; } + if (lradc->variant->has_clock_reset) { + lradc->clk = devm_clk_get(dev, NULL); + if (IS_ERR(lradc->clk)) + return PTR_ERR(lradc->clk); + + lradc->reset = devm_reset_control_get_exclusive(dev, NULL); + if (IS_ERR(lradc->reset)) + return PTR_ERR(lradc->reset); + } + lradc->vref_supply = devm_regulator_get(dev, "vref"); if (IS_ERR(lradc->vref_supply)) return PTR_ERR(lradc->vref_supply);