From patchwork Thu Apr 14 07:10:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Liu Ying X-Patchwork-Id: 12813015 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D928C433F5 for ; Thu, 14 Apr 2022 07:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vVu6zp8wgsiW3wxGDzaJY2fmpj7fx4F+HvG9L0GbzMQ=; b=ns+I0QBX0PJtF4 2YEYEgLz593/vLDY23T78XdV4BtzfYp3LGQl16VCf9iBNLJzJOpQQwycIsfy3w6qbSxT/Sro44obZ 9TkbjxW5fE1Ay22DFGmFCm9cyowGSKT//V5+XOvAnNEnvnMx8TyDyGczsbB0pyVEl8QgUL3si/KBI 90R8wYQKOFS1I14c5a8lBXfFFyrMIN2D5TJDFsf0rmteoFOFyev29Lae/IlVYFk/NHbcP1tUNipJV eKDzj/cqEW2gOto3qfWviclZH1K+0C2/bvnoQsOQwvIus/BZXrBovjfg35dP2XcyPfAGxy18EAaJg WB32pgk7Zwm8eqi2ReLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1netbP-004G3U-67; Thu, 14 Apr 2022 07:09:15 +0000 Received: from mail-am6eur05on20606.outbound.protection.outlook.com ([2a01:111:f400:7e1b::606] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1netbK-004Fye-Q4; Thu, 14 Apr 2022 07:09:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a7cmNhBle6uC/Yjn6atc7SuF8fJK6NUc6WpFPFZM5lUnpcP+L2uvE3lXDT+3dJ/c1qFi9YN1+kWiVfYnFroqHdOjulAt3Dgk2/TuW55C7poHd8sT/xRnHOyr5DitH4h67tYPW3BDph0JWijikgDmzXLllz9jNk5UuNywiysZdNpTlBru+BsuKpAshB+gwI8InAIcmlzk/riGn4bz3DWlxfGFbH3pdkpP5w7SspeQ3s+YLINLKbHG0635yKdn8Bde0gOBpM35L48LoIJBsZpv7eykeUCY13bAvw2oHWWuPbbKnDzD2Ww4I5qCYF3mT+O3U11v2xYafmrpp0Xte8Wwyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H4Yt87+y8OLIFPsVv3s0nx47PgG01ijdBdHzherr3D0=; b=gxyLGPI/dSvfScpjWKcVOS/AE2hMOIWjlV79aKr1aPfsgJWhefo8DRGTQ5pTMxdkOIlAjGrC2i47aYWWI9UyPM7ntHbTfspj1In627xN+EpP1bnMcMjTPRyB/cSYlSmLWsr0hlFtJK3Sc/Pr+l5KDHXhiEt6471xYg6tawmAck1tQY4wM94UkVianPmJxCDM/VhMo2nvpkZQWtaMCY1Tr/P0qQSseg0mhMecOOEQkfG2fJOHv2EoQ3Ye+4UBHEKksrCSoulRbdXkHhBDfknLbjqdPM9Yuf4bpWzQACG8VZqr05ShMZnvYLTmoQ3+6VxnXDDu35Nm3uXkhXXFjx4uzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H4Yt87+y8OLIFPsVv3s0nx47PgG01ijdBdHzherr3D0=; b=FmqwJJfRmcvbgvsJH28TqcMeI4YHHgH00Wtcsib4lWpvjEHpuAtlu30SmdsM2NDw40d7ZOeZRk2kV+zk9il9xugF0Ug5xT/lXRRrt88OyKg3o4OAP1HVWEeBVKCEnUwTyy9NFk0U2FeWcVhr0htm74an6gtFGMZ44dTms2C6TRg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by DB8PR04MB6714.eurprd04.prod.outlook.com (2603:10a6:10:10e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 14 Apr 2022 07:09:02 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::b09c:8ffe:8e02:7387]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::b09c:8ffe:8e02:7387%9]) with mapi id 15.20.5164.018; Thu, 14 Apr 2022 07:09:02 +0000 From: Liu Ying To: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Cc: kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org, andrzej.hajda@intel.com, narmstrong@baylibre.com, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, agx@sigxcpu.org, robert.chiras@nxp.com, martin.kepplinger@puri.sm, Andrzej Hajda , Jernej Skrabec Subject: [PATCH v8 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set() Date: Thu, 14 Apr 2022 15:10:35 +0800 Message-Id: <20220414071039.423271-2-victor.liu@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220414071039.423271-1-victor.liu@nxp.com> References: <20220414071039.423271-1-victor.liu@nxp.com> X-ClientProxiedBy: SI2PR06CA0005.apcprd06.prod.outlook.com (2603:1096:4:186::12) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 17c75abb-9c88-4cf1-c548-08da1de5a7b5 X-MS-TrafficTypeDiagnostic: DB8PR04MB6714:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: snn7Nol9XdeZwX+rj5wkYJmwp9/4VM3HHG0/9KZTVel1KFyr4nCZbZr+NksL3BtJiYT2cYLEp+/sCcowdL2JhNGc4BrfkMAACPfLX1Gz3xGfRR4znlzBduOr8Y5XdQZsUfQ3AyjUDBcy2zlhXc+W44f6SlqubSURUDTK70fJssA1dIK3aBarfZ73rpK2TBPV6elq5yerBmNErcAuOD4lkf9GlUhzB8sEGXA+Mv32fMXRmVsO4sJiuxtqFuP99+KU9IEyvm1ZAJFOa2wY/quR9HTFH/mx2CsVSHhWSZ2Ekov7KraNSsAguHs2TpyB1//Tbe0kKHeHvyEQR+ooGqCfpLhJ8OzXm681ggJ/og1ooFPPfeQymOczq5Qw+7yvgX1qNcX26Kw+l/AYMlN8dho08TZ94cM7Ef5RTPw57cc79Ir6YKNA2fzFzV4SfQGocdU7hcWvPgMQVwXo7OSi2Bme5CIxeQdspE25kMj6VR4inv4BCGRlTz/iVoiIn3WgOVJA7OzC+5+KVMmAqF9RXUTJf9qLPln/hpGNZYHv4m71xekeSGQA8q3ALo0GZebzRDXjDBB6l2bKdJxS1r0yNDRjAAY/eMNEum951WwThBHyBZJmfVBtwUwk/NYakXh5HhjfJX4LK8730Unuu/eIEsvNSLa9A5ahK0sQ9IJoEb9KHKGstUhDnb0aXDkasZtqeZtkcRaJw561oWKVRdtoLVpVdQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR04MB7046.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6486002)(1076003)(38100700002)(38350700002)(54906003)(66556008)(316002)(66946007)(4326008)(66476007)(508600001)(8676002)(86362001)(2616005)(26005)(6666004)(6512007)(52116002)(6506007)(186003)(7416002)(2906002)(5660300002)(36756003)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?buZ7puJRn3Zi2zwdj/QgqM7zQTqZ?= =?utf-8?q?0ahz1x0BfHvdXwWUPm8V3KaZsOzERgExXzcXAtkUbypjmkLee18mDqidDj8WTfLNt?= =?utf-8?q?cCR4lDYaNpJNXxw4CRTBmkBQRSBeAsjLmAfP3ZJMlHWwWxDcUsAX5IOhHms5qvTmq?= =?utf-8?q?lMd98Wn4tN7f5wlbXeC3wzFU/KIlFIdazp54FGnThW9WpTVAoWksng3UO/iuCHn8d?= =?utf-8?q?y1N1kJE6GF9mxXc1dmOyRaXgJOeFGe6VlRunBJMPzLZW+/BD+PTIFZtVuSGaZn5Nw?= =?utf-8?q?U62+hkyFql03v1TUh8jiMlogljOX5/HjHsUl75KLwgoF27IRnS7rR7p7JQGYaSkQs?= =?utf-8?q?g96LtUwVqjAgwjfv1VNqKX6RPxc2PQeIiuThqcw5lufXczeF4tJRhBM24E0T/Vo47?= =?utf-8?q?glsDkrC1bL+vdvEzvaRXxo1ub/nZ3/hr1YOTrWAZfl+cLh21ad78GHbd/YqiizXQS?= =?utf-8?q?luhUKoP8eQeUmPFJ4K1WLXaTxezw2RWRHHUzaNV2LvXpx4VgPxksiT2JantyS++Fm?= =?utf-8?q?1urFjGvDS9ZBhAQpOroJdQ1zbLRCKsv7qaL+PJgFrFjB3Kzqw0jLQDC0G/Ey6oLKo?= =?utf-8?q?TTH+hzm20SyHXVprbYZIGR/PpyOU7trY9UHTL+NPacAqLkdf5k/rcttcY6JZ1z7PM?= =?utf-8?q?4NS5R6ctD6DRpeo7i2dxcTx4J2I694NENO6JqZb7wiqH02WaFPmQUVJ0OpT25Co2r?= =?utf-8?q?NebmcAsx9GuS0McR0jenuzcKDQAJ82VHwDSXFqNtM0zc+w5NIlyYSgYi9hSEDlve2?= =?utf-8?q?uIHswWqhjWpCYWsHK67wVv7gfZVpfQW+YJshfHO2yKjJzp4Du7PoAuXlmfieL9/T0?= =?utf-8?q?2bB+WjnrYfW2wgjnnWdRwghxYuPz1akHlvL4c6GRh3buJVO28zLtSCh1Vi4871tBx?= =?utf-8?q?97ouZQxZ7sfGW6GWR9R/+4kg7MlmhxOsgGfdTW7+eRFsL57yGjJzOKTHMNzlz7Bg6?= =?utf-8?q?NcYPJTUqNs51P4pvufpPmtyLbOaU/WuRkJc5gVakCTmKWuqcyb79EdqpWDNucVvgU?= =?utf-8?q?5JYuOdoNMoAO0M3xk/siaBsF6bEOCw2w3Y6JBS1etk9YMy6bY5W8g9XosDsvYAe2p?= =?utf-8?q?vAP1xcI01ou7tqY4R5ckztZ7i/P3ox3neHFwfipmr1pSj6w4PPvCShdidI/616AGn?= =?utf-8?q?57HfBwu5OpafOAGXu1iDpXrcunX9XpOttfuj65FSZdjmP4Hmw1TMEKq4s2bPSWKPw?= =?utf-8?q?Hnx5rCjDTeD6MtF/TBfsUTI5X2YJA4n8xAF6RK+NA0MHQMrz+5N+nwO4Uy68Fon74?= =?utf-8?q?K/zWU/dcsBV0TbY8XCczwGZSCw0K+Gg4ebBlHbY1F85B/TZWGA2QioAIdBiomFfhz?= =?utf-8?q?AjASGvft+rxjM10HlLv3Xvcd8U8cbqL989QfG3eWE1JAQz4VaNyJ7wse1vLFaOowL?= =?utf-8?q?Oi70pB1QeBnRhn1kuOFJDKBwbPfcZRNa+i9+McS4S86N++BB4bVp3AL30+HhRwBrI?= =?utf-8?q?6s5Jg39BNM4iDTfxl3dNbotwXxLR3zq0LfEYXvAuPKhgFoGgxdR0kVcG3t5652Ydk?= =?utf-8?q?0IGF02vvmbF1Kt3UmxeokxHlc5CuVP/+3JdPDvK5JnQPVMEox3HKWiDUFHgLbI4Bo?= =?utf-8?q?ttzSEg6JcCpOdnuGHRj8maZve/IIPUiDQohDaVyBer53BqC+4iOob9nRi8xEA1T8P?= =?utf-8?q?lz80c5qsuT7lDO+ovgUke2HogH5+bO7g=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17c75abb-9c88-4cf1-c548-08da1de5a7b5 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 07:09:02.6801 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Az9lDrgiMsbzDu/QiAna3ZQr0NkQzZrea0HGXWtyhjtSterOAUT0FbrB0ERLnEzLQZP44EHIAVWVJgJJyayQNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6714 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220414_000910_881243_BF57A95A X-CRM114-Status: GOOD ( 11.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp works with a Mixel MIPI DPHY + LVDS PHY combo to support either a MIPI DSI display or a LVDS display. So, this patch calls phy_set_mode() from nwl_dsi_mode_set() to set PHY mode to MIPI DPHY explicitly. Cc: Guido Günther Cc: Robert Chiras Cc: Martin Kepplinger Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: NXP Linux Team Signed-off-by: Liu Ying --- v7->v8: * No change. v6->v7: * No change. v5->v6: * Rebase the series upon v5.17-rc1. * Set PHY mode in ->mode_set() instead of ->pre_enable() in the nwl-dsi bridge driver due to the rebase. * Drop Guido's R-b tag due to the rebase. v4->v5: * No change. v3->v4: * No change. v2->v3: * No change. v1->v2: * Add Guido's R-b tag. drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++ 1 file changed, 6 insertions(+) drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c index d5945501a5ee..85bab7372af1 100644 --- a/drivers/gpu/drm/bridge/nwl-dsi.c +++ b/drivers/gpu/drm/bridge/nwl-dsi.c @@ -666,6 +666,12 @@ static int nwl_dsi_mode_set(struct nwl_dsi *dsi) return ret; } + ret = phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY); + if (ret < 0) { + DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n", ret); + goto uninit_phy; + } + ret = phy_configure(dsi->phy, phy_cfg); if (ret < 0) { DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", ret);