| Message ID | 20220422133803.989256-2-chris.obbard@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Rockchip RK3328 VDEC support | expand |
On Fri, Apr 22, 2022 at 02:38:01PM +0100, Christopher Obbard wrote: > Document the RK3328 compatible for rockchip-vdec. > > Signed-off-by: Christopher Obbard <chris.obbard@collabora.com> Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> > --- > Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > index 089f11d21b25..23f9687d862c 100644 > --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > @@ -19,6 +19,7 @@ properties: > - const: rockchip,rk3399-vdec > - items: > - const: rockchip,rk3228-vdec > + - const: rockchip,rk3328-vdec > - const: rockchip,rk3399-vdec > > reg: > -- > 2.34.1 >
On 22/04/2022 15:38, Christopher Obbard wrote: > Document the RK3328 compatible for rockchip-vdec. > > Signed-off-by: Christopher Obbard <chris.obbard@collabora.com> > --- > Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 1 + > 1 file changed, 1 insertion(+) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 23/04/2022 13:10, Krzysztof Kozlowski wrote: > On 22/04/2022 15:38, Christopher Obbard wrote: >> Document the RK3328 compatible for rockchip-vdec. >> >> Signed-off-by: Christopher Obbard <chris.obbard@collabora.com> >> --- >> Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 1 + >> 1 file changed, 1 insertion(+) > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> I acked this but Johan pointed out that your intention was different and missing patch context is quite important here. Please explain what exactly you wanted in the patch? Now it looks actually wrong, so my ack is not correct. Best regards, Krzysztof
On 23/04/2022 18:31, Krzysztof Kozlowski wrote: > On 23/04/2022 13:10, Krzysztof Kozlowski wrote: >> On 22/04/2022 15:38, Christopher Obbard wrote: >>> Document the RK3328 compatible for rockchip-vdec. >>> >>> Signed-off-by: Christopher Obbard <chris.obbard@collabora.com> >>> --- >>> Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 1 + >>> 1 file changed, 1 insertion(+) >> >> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > I acked this but Johan pointed out that your intention was different and > missing patch context is quite important here. Please explain what > exactly you wanted in the patch? Now it looks actually wrong, so my ack > is not correct. Wow - I think i was in weekend mode and forgot to run dtbs_check ;-). It will be solved in v2. I have now added the check to my "pre send-patch" review checklist. Just out of interest, I didn't get a mail from Johan and I can't seem to find it the archive either. Is that message in public as I'd like to address any other concerns at the same time ? Cheers! Chris
On 25/04/2022 11:53, Christopher Obbard wrote: >>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> I acked this but Johan pointed out that your intention was different and >> missing patch context is quite important here. Please explain what >> exactly you wanted in the patch? Now it looks actually wrong, so my ack >> is not correct. > > Wow - I think i was in weekend mode and forgot to run dtbs_check ;-). > It will be solved in v2. I have now added the check to my "pre > send-patch" review checklist. > > Just out of interest, I didn't get a mail from Johan and I can't seem to > find it the archive either. Is that message in public as I'd like to > address any other concerns at the same time ? No, it wasn't public. :( Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml index 089f11d21b25..23f9687d862c 100644 --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml @@ -19,6 +19,7 @@ properties: - const: rockchip,rk3399-vdec - items: - const: rockchip,rk3228-vdec + - const: rockchip,rk3328-vdec - const: rockchip,rk3399-vdec reg:
Document the RK3328 compatible for rockchip-vdec. Signed-off-by: Christopher Obbard <chris.obbard@collabora.com> --- Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 1 + 1 file changed, 1 insertion(+)