| Message ID | 20220425132844.866743-3-o.rempel@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mainline Protonic PRTT1x boards | expand |
On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote: > Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C > board. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > index 105725a127ab..ce107fe45d7c 100644 > --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > @@ -39,6 +39,7 @@ properties: > compatible: > items: > - enum: > + - prt,prtt1c-wfm200 # Protonic PRTT1C Board > - silabs,brd4001a # WGM160P Evaluation Board > - silabs,brd8022a # WF200 Evaluation Board > - silabs,brd8023a # WFM200 Evaluation Board I think you also have to declare this new entry in wfx_sdio_of_match, and/or wfx_spi_of_match and wfx_spi_id. On the WFM200 variant, the antenna is built in the chip. So I think you can point on the same configuration than the brd8023a.
On Mon, Apr 25, 2022 at 05:38:20PM +0200, Jérôme Pouiller wrote: > On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote: > > Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C > > board. > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > --- > > .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > index 105725a127ab..ce107fe45d7c 100644 > > --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > @@ -39,6 +39,7 @@ properties: > > compatible: > > items: > > - enum: > > + - prt,prtt1c-wfm200 # Protonic PRTT1C Board > > - silabs,brd4001a # WGM160P Evaluation Board > > - silabs,brd8022a # WF200 Evaluation Board > > - silabs,brd8023a # WFM200 Evaluation Board > > I think you also have to declare this new entry in wfx_sdio_of_match, > and/or wfx_spi_of_match and wfx_spi_id. > > On the WFM200 variant, the antenna is built in the chip. So I think you > can point on the same configuration than the brd8023a. We have attached Molex 47950 antenna on secondary RF output. Is it still compatible with brd8023a? Regards, Oleksij
On Mon, Apr 25, 2022 at 05:38:20PM +0200, Jérôme Pouiller wrote: > On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote: > > Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C > > board. > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > --- > > .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > index 105725a127ab..ce107fe45d7c 100644 > > --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > @@ -39,6 +39,7 @@ properties: > > compatible: > > items: > > - enum: > > + - prt,prtt1c-wfm200 # Protonic PRTT1C Board > > - silabs,brd4001a # WGM160P Evaluation Board > > - silabs,brd8022a # WF200 Evaluation Board > > - silabs,brd8023a # WFM200 Evaluation Board > > I think you also have to declare this new entry in wfx_sdio_of_match, > and/or wfx_spi_of_match and wfx_spi_id. > > On the WFM200 variant, the antenna is built in the chip. So I think you > can point on the same configuration than the brd8023a. I assume driver update can be made in a separate patch. As soon as we reserved compatible for this boards there should be no conflicts. This patches series is targeting only devicetree and needed DT schema changes. Regards, Oleksij
On Tuesday 26 April 2022 07:08:12 CEST Oleksij Rempel wrote: > On Mon, Apr 25, 2022 at 05:38:20PM +0200, Jérôme Pouiller wrote: > > On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote: > > > Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C > > > board. > > > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > > --- > > > .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > > index 105725a127ab..ce107fe45d7c 100644 > > > --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > > +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > > @@ -39,6 +39,7 @@ properties: > > > compatible: > > > items: > > > - enum: > > > + - prt,prtt1c-wfm200 # Protonic PRTT1C Board > > > - silabs,brd4001a # WGM160P Evaluation Board > > > - silabs,brd8022a # WF200 Evaluation Board > > > - silabs,brd8023a # WFM200 Evaluation Board > > > > I think you also have to declare this new entry in wfx_sdio_of_match, > > and/or wfx_spi_of_match and wfx_spi_id. > > > > On the WFM200 variant, the antenna is built in the chip. So I think you > > can point on the same configuration than the brd8023a. > > We have attached Molex 47950 antenna on secondary RF output. Is it still > compatible with brd8023a? I think it is not. You will have to provide the configuration file for this board.
On Tuesday 26 April 2022 09:21:13 CEST Oleksij Rempel wrote: > On Mon, Apr 25, 2022 at 05:38:20PM +0200, Jérôme Pouiller wrote: > > On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote: > > > Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C > > > board. > > > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > > --- > > > .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > > index 105725a127ab..ce107fe45d7c 100644 > > > --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > > +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > > @@ -39,6 +39,7 @@ properties: > > > compatible: > > > items: > > > - enum: > > > + - prt,prtt1c-wfm200 # Protonic PRTT1C Board > > > - silabs,brd4001a # WGM160P Evaluation Board > > > - silabs,brd8022a # WF200 Evaluation Board > > > - silabs,brd8023a # WFM200 Evaluation Board > > > > I think you also have to declare this new entry in wfx_sdio_of_match, > > and/or wfx_spi_of_match and wfx_spi_id. > > > > On the WFM200 variant, the antenna is built in the chip. So I think you > > can point on the same configuration than the brd8023a. > > I assume driver update can be made in a separate patch. As soon as we > reserved compatible for this boards there should be no conflicts. This patches > series is targeting only devicetree and needed DT schema changes. hmmm... I am not DT specialist, but it seems a bit weird to have a new entry in the dt schema, but no new code in any of_match table.
On Tue, Apr 26, 2022 at 10:19:29AM +0200, Jérôme Pouiller wrote: > On Tuesday 26 April 2022 09:21:13 CEST Oleksij Rempel wrote: > > On Mon, Apr 25, 2022 at 05:38:20PM +0200, Jérôme Pouiller wrote: > > > On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote: > > > > Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C > > > > board. > > > > > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > > > --- > > > > .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > > > index 105725a127ab..ce107fe45d7c 100644 > > > > --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > > > +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > > > @@ -39,6 +39,7 @@ properties: > > > > compatible: > > > > items: > > > > - enum: > > > > + - prt,prtt1c-wfm200 # Protonic PRTT1C Board > > > > - silabs,brd4001a # WGM160P Evaluation Board > > > > - silabs,brd8022a # WF200 Evaluation Board > > > > - silabs,brd8023a # WFM200 Evaluation Board > > > > > > I think you also have to declare this new entry in wfx_sdio_of_match, > > > and/or wfx_spi_of_match and wfx_spi_id. > > > > > > On the WFM200 variant, the antenna is built in the chip. So I think you > > > can point on the same configuration than the brd8023a. > > > > I assume driver update can be made in a separate patch. As soon as we > > reserved compatible for this boards there should be no conflicts. This patches > > series is targeting only devicetree and needed DT schema changes. > > hmmm... I am not DT specialist, but it seems a bit weird to have a new > entry in the dt schema, but no new code in any of_match table. Here is one example: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/spi/fsl-imx-cspi.yaml?h=v5.18-rc4#n28 properties: compatible: oneOf: - const: fsl,imx1-cspi - const: fsl,imx21-cspi - const: fsl,imx27-cspi - const: fsl,imx31-cspi - const: fsl,imx35-cspi - const: fsl,imx51-ecspi - const: fsl,imx53-ecspi - items: - enum: - fsl,imx50-ecspi - fsl,imx6q-ecspi - fsl,imx6sx-ecspi - fsl,imx6sl-ecspi - fsl,imx6sll-ecspi - fsl,imx6ul-ecspi - fsl,imx7d-ecspi - fsl,imx8mq-ecspi - fsl,imx8mm-ecspi - fsl,imx8mn-ecspi - fsl,imx8mp-ecspi - const: fsl,imx51-ecspi httpt://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/spi/spi-imx.c?h=v5.18-rc4#n1063 static const struct of_device_id spi_imx_dt_ids[] = { { .compatible = "fsl,imx1-cspi", .data = &imx1_cspi_devtype_data, }, { .compatible = "fsl,imx21-cspi", .data = &imx21_cspi_devtype_data, }, { .compatible = "fsl,imx27-cspi", .data = &imx27_cspi_devtype_data, }, { .compatible = "fsl,imx31-cspi", .data = &imx31_cspi_devtype_data, }, { .compatible = "fsl,imx35-cspi", .data = &imx35_cspi_devtype_data, }, { .compatible = "fsl,imx51-ecspi", .data = &imx51_ecspi_devtype_data, }, { .compatible = "fsl,imx53-ecspi", .data = &imx53_ecspi_devtype_data, }, { .compatible = "fsl,imx6ul-ecspi", .data = &imx6ul_ecspi_devtype_data, }, { /* sentinel */ } }; Regards, Oleksij
On Tuesday 26 April 2022 10:33:05 CEST Oleksij Rempel wrote: > On Tue, Apr 26, 2022 at 10:19:29AM +0200, Jérôme Pouiller wrote: > > On Tuesday 26 April 2022 09:21:13 CEST Oleksij Rempel wrote: > > > On Mon, Apr 25, 2022 at 05:38:20PM +0200, Jérôme Pouiller wrote: > > > > On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote: > > > > > Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C > > > > > board. > > > > > > > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > > > > --- > > > > > .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > > > > index 105725a127ab..ce107fe45d7c 100644 > > > > > --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > > > > +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml > > > > > @@ -39,6 +39,7 @@ properties: > > > > > compatible: > > > > > items: > > > > > - enum: > > > > > + - prt,prtt1c-wfm200 # Protonic PRTT1C Board > > > > > - silabs,brd4001a # WGM160P Evaluation Board > > > > > - silabs,brd8022a # WF200 Evaluation Board > > > > > - silabs,brd8023a # WFM200 Evaluation Board > > > > > > > > I think you also have to declare this new entry in wfx_sdio_of_match, > > > > and/or wfx_spi_of_match and wfx_spi_id. > > > > > > > > On the WFM200 variant, the antenna is built in the chip. So I think you > > > > can point on the same configuration than the brd8023a. > > > > > > I assume driver update can be made in a separate patch. As soon as we > > > reserved compatible for this boards there should be no conflicts. This patches > > > series is targeting only devicetree and needed DT schema changes. > > > > hmmm... I am not DT specialist, but it seems a bit weird to have a new > > entry in the dt schema, but no new code in any of_match table. > > Here is one example: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/spi/fsl-imx-cspi.yaml?h=v5.18-rc4 > properties: > compatible: > oneOf: > - const: fsl,imx1-cspi > - const: fsl,imx21-cspi > - const: fsl,imx27-cspi > - const: fsl,imx31-cspi > - const: fsl,imx35-cspi > - const: fsl,imx51-ecspi > - const: fsl,imx53-ecspi > - items: > - enum: > - fsl,imx50-ecspi > - fsl,imx6q-ecspi > - fsl,imx6sx-ecspi > - fsl,imx6sl-ecspi > - fsl,imx6sll-ecspi > - fsl,imx6ul-ecspi > - fsl,imx7d-ecspi > - fsl,imx8mq-ecspi > - fsl,imx8mm-ecspi > - fsl,imx8mn-ecspi > - fsl,imx8mp-ecspi > - const: fsl,imx51-ecspi > > httpt://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/spi/spi-imx.c?h=v5.18-rc4#n1063 > static const struct of_device_id spi_imx_dt_ids[] = { > { .compatible = "fsl,imx1-cspi", .data = &imx1_cspi_devtype_data, }, > { .compatible = "fsl,imx21-cspi", .data = &imx21_cspi_devtype_data, }, > { .compatible = "fsl,imx27-cspi", .data = &imx27_cspi_devtype_data, }, > { .compatible = "fsl,imx31-cspi", .data = &imx31_cspi_devtype_data, }, > { .compatible = "fsl,imx35-cspi", .data = &imx35_cspi_devtype_data, }, > { .compatible = "fsl,imx51-ecspi", .data = &imx51_ecspi_devtype_data, }, > { .compatible = "fsl,imx53-ecspi", .data = &imx53_ecspi_devtype_data, }, > { .compatible = "fsl,imx6ul-ecspi", .data = &imx6ul_ecspi_devtype_data, }, > { /* sentinel */ } > }; Right.
diff --git a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml index 105725a127ab..ce107fe45d7c 100644 --- a/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml +++ b/Documentation/devicetree/bindings/staging/net/wireless/silabs,wfx.yaml @@ -39,6 +39,7 @@ properties: compatible: items: - enum: + - prt,prtt1c-wfm200 # Protonic PRTT1C Board - silabs,brd4001a # WGM160P Evaluation Board - silabs,brd8022a # WF200 Evaluation Board - silabs,brd8023a # WFM200 Evaluation Board
Add compatible for wfm200 antenna configuration variant for Protonic PRTT1C board. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml | 1 + 1 file changed, 1 insertion(+)