diff mbox series

[1/2] dt-bindings: soc: ti: pruss: Update bindings for K3 AM62x SoCs

Message ID 20220427072703.4898-2-kishon@ti.com (mailing list archive)
State New, archived
Headers show
Series soc: ti: Enable PRUSS-M on K3 AM62x SoCs | expand

Commit Message

Kishon Vijay Abraham I April 27, 2022, 7:27 a.m. UTC
Update the PRUSS bindings for the PRUSSM instance present in
AM625 SoC.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski April 28, 2022, 6:18 a.m. UTC | #1
On 27/04/2022 09:27, Kishon Vijay Abraham I wrote:
> Update the PRUSS bindings for the PRUSSM instance present in
> AM625 SoC.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> index 64461d432004..cf13e5179657 100644
> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> @@ -69,6 +69,7 @@ properties:
>        - ti,am654-icssg   # for K3 AM65x SoC family
>        - ti,j721e-icssg   # for K3 J721E SoC family
>        - ti,am642-icssg   # for K3 AM64x SoC family
> +      - ti,am625-pruss   # for K3 AM62x SoC family
>  

Looks like out of order (although for some reason before it was also
misordered...).


Best regards,
Krzysztof
Kishon Vijay Abraham I May 16, 2022, 12:33 p.m. UTC | #2
Hi Krzysztof,

On 28/04/22 11:48, Krzysztof Kozlowski wrote:
> On 27/04/2022 09:27, Kishon Vijay Abraham I wrote:
>> Update the PRUSS bindings for the PRUSSM instance present in
>> AM625 SoC.
>>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>> ---
>>  Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>> index 64461d432004..cf13e5179657 100644
>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>> @@ -69,6 +69,7 @@ properties:
>>        - ti,am654-icssg   # for K3 AM65x SoC family
>>        - ti,j721e-icssg   # for K3 J721E SoC family
>>        - ti,am642-icssg   # for K3 AM64x SoC family
>> +      - ti,am625-pruss   # for K3 AM62x SoC family
>>  
> 
> Looks like out of order (although for some reason before it was also
> misordered...).

These are really in the chronological order of the introduction of SoCs.
Isn't that okay to have?

Thanks,
Kishon
Krzysztof Kozlowski May 16, 2022, 3:18 p.m. UTC | #3
On 16/05/2022 14:33, Kishon Vijay Abraham I wrote:
> Hi Krzysztof,
> 
> On 28/04/22 11:48, Krzysztof Kozlowski wrote:
>> On 27/04/2022 09:27, Kishon Vijay Abraham I wrote:
>>> Update the PRUSS bindings for the PRUSSM instance present in
>>> AM625 SoC.
>>>
>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>>> ---
>>>  Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>> index 64461d432004..cf13e5179657 100644
>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>> @@ -69,6 +69,7 @@ properties:
>>>        - ti,am654-icssg   # for K3 AM65x SoC family
>>>        - ti,j721e-icssg   # for K3 J721E SoC family
>>>        - ti,am642-icssg   # for K3 AM64x SoC family
>>> +      - ti,am625-pruss   # for K3 AM62x SoC family
>>>  
>>
>> Looks like out of order (although for some reason before it was also
>> misordered...).
> 
> These are really in the chronological order of the introduction of SoCs.
> Isn't that okay to have?

You mean order of release on the market of order of adding files here?
The first is ok, the latter would mean there is no order at all.

It's a nit, so I don't expect to change it. It just increases our
chances for conflicts...


Best regards,
Krzysztof
Kishon Vijay Abraham I June 2, 2022, 10:03 a.m. UTC | #4
Hi Krzysztof,

On 16/05/22 20:48, Krzysztof Kozlowski wrote:
> On 16/05/2022 14:33, Kishon Vijay Abraham I wrote:
>> Hi Krzysztof,
>>
>> On 28/04/22 11:48, Krzysztof Kozlowski wrote:
>>> On 27/04/2022 09:27, Kishon Vijay Abraham I wrote:
>>>> Update the PRUSS bindings for the PRUSSM instance present in
>>>> AM625 SoC.
>>>>
>>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>>>> ---
>>>>  Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>> index 64461d432004..cf13e5179657 100644
>>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>> @@ -69,6 +69,7 @@ properties:
>>>>        - ti,am654-icssg   # for K3 AM65x SoC family
>>>>        - ti,j721e-icssg   # for K3 J721E SoC family
>>>>        - ti,am642-icssg   # for K3 AM64x SoC family
>>>> +      - ti,am625-pruss   # for K3 AM62x SoC family
>>>>  
>>>
>>> Looks like out of order (although for some reason before it was also
>>> misordered...).
>>
>> These are really in the chronological order of the introduction of SoCs.
>> Isn't that okay to have?
> 
> You mean order of release on the market of order of adding files here?
> The first is ok, the latter would mean there is no order at all.

I meant order of release to market. Anyways, I'll send a patch to change
the order to alphabetic order.

Thanks,
Kishon
Krzysztof Kozlowski June 2, 2022, 11:09 a.m. UTC | #5
On 02/06/2022 12:03, Kishon Vijay Abraham I wrote:
> Hi Krzysztof,
> 
> On 16/05/22 20:48, Krzysztof Kozlowski wrote:
>> On 16/05/2022 14:33, Kishon Vijay Abraham I wrote:
>>> Hi Krzysztof,
>>>
>>> On 28/04/22 11:48, Krzysztof Kozlowski wrote:
>>>> On 27/04/2022 09:27, Kishon Vijay Abraham I wrote:
>>>>> Update the PRUSS bindings for the PRUSSM instance present in
>>>>> AM625 SoC.
>>>>>
>>>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>>>>> ---
>>>>>  Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 1 +
>>>>>  1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>>> index 64461d432004..cf13e5179657 100644
>>>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>>>> @@ -69,6 +69,7 @@ properties:
>>>>>        - ti,am654-icssg   # for K3 AM65x SoC family
>>>>>        - ti,j721e-icssg   # for K3 J721E SoC family
>>>>>        - ti,am642-icssg   # for K3 AM64x SoC family
>>>>> +      - ti,am625-pruss   # for K3 AM62x SoC family
>>>>>  
>>>>
>>>> Looks like out of order (although for some reason before it was also
>>>> misordered...).
>>>
>>> These are really in the chronological order of the introduction of SoCs.
>>> Isn't that okay to have?
>>
>> You mean order of release on the market of order of adding files here?
>> The first is ok, the latter would mean there is no order at all.
> 
> I meant order of release to market. Anyways, I'll send a patch to change
> the order to alphabetic order.

It's okay to keep it then in such release-market order. Up to you:


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
index 64461d432004..cf13e5179657 100644
--- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
@@ -69,6 +69,7 @@  properties:
       - ti,am654-icssg   # for K3 AM65x SoC family
       - ti,j721e-icssg   # for K3 J721E SoC family
       - ti,am642-icssg   # for K3 AM64x SoC family
+      - ti,am625-pruss   # for K3 AM62x SoC family
 
   reg:
     maxItems: 1