| Message ID | 20220429113946.2087145-1-sudeep.holla@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] firmware: arm_ffa: Fix uuid parameter to ffa_partition_probe | expand |
On Fri, 29 Apr 2022 12:39:43 +0100, Sudeep Holla wrote: > While we pass uuid_null intentionally to ffa_partition_probe in > ffa_setup_partitions to get the count of the partitions, it must not be > uuid_null in ffa_partition_info_get which is used by the ffa_drivers > to fetch the specific partition info passing the UUID of the partition. > > Fix ffa_partition_info_get by passing the received uuid down to > ffa_partition_probe so that the correct partition information is fetched. > > [...] Applied to sudeep.holla/linux (for-next/ffa), thanks! [1/4] firmware: arm_ffa: Fix uuid parameter to ffa_partition_probe https://git.kernel.org/sudeep.holla/c/f3c45c045e [2/4] firmware: arm_ffa: Remove incorrect assignment of driver_data https://git.kernel.org/sudeep.holla/c/00512d2930 [3/4] firmware: arm_ffa: Add ffa_dev_get_drvdata helper function https://git.kernel.org/sudeep.holla/c/498af8d167 [4/4] tee: optee: Use ffa_dev_get_drvdata to fetch driver_data https://git.kernel.org/sudeep.holla/c/f3f3bdbd58 -- Regards, Sudeep
diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index ccccecae615f..6a913ac91e8e 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -588,7 +588,7 @@ static int ffa_partition_info_get(const char *uuid_str, return -ENODEV; } - count = ffa_partition_probe(&uuid_null, &pbuf); + count = ffa_partition_probe(&uuid, &pbuf); if (count <= 0) return -ENOENT;
While we pass uuid_null intentionally to ffa_partition_probe in ffa_setup_partitions to get the count of the partitions, it must not be uuid_null in ffa_partition_info_get which is used by the ffa_drivers to fetch the specific partition info passing the UUID of the partition. Fix ffa_partition_info_get by passing the received uuid down to ffa_partition_probe so that the correct partition information is fetched. Fixes: d0c0bce83122 ("firmware: arm_ffa: Setup in-kernel users of FFA partitions") Reported-by: Arunachalam Ganapathy <arunachalam.ganapathy@arm.com> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/firmware/arm_ffa/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)