From patchwork Fri Apr 29 11:39:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 12831882 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80301C433EF for ; Fri, 29 Apr 2022 11:41:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ociAozhAQS5XrWNK6b1Faq81udt4w9P899szrVCuJ58=; b=xAwlPzbx2UDH9U +mECJpQoyfHIJySEiyQTTzC85xV7ym4OBdwXdcsJYxDnYcqrB8ZMAJQwQOSZPiNMTIGmpT94ukw0R 9Vbt6l7gLxbEuDfH7gf4a5thzEQpRTIllVHISVBg++1mvdk2w2l2jnrYa32Kr7Gr2bmb2A/vCLE76 J7EoCKOh7Timz+oa681tqdEEYY6G56T9VXdGzee247pHBjg3Fh8b6IQYl3VbhgMSL3+1Qjtq9QCTQ 3kVANg+s7WMyvt+OvC7dc5z2Wtgbq/JDQrC3uqUERS3hbnm4n19IMMH5gikRSCps6THZWG6zt7Qk+ wUrb48sbnEHirqfCA4+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkOz5-00AzDk-IG; Fri, 29 Apr 2022 11:40:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkOyh-00Az8U-DY for linux-arm-kernel@lists.infradead.org; Fri, 29 Apr 2022 11:40:05 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 849F2106F; Fri, 29 Apr 2022 04:40:00 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 957733F73B; Fri, 29 Apr 2022 04:39:59 -0700 (PDT) From: Sudeep Holla To: linux-arm-kernel@lists.infradead.org, op-tee@lists.trustedfirmware.org Cc: Sudeep Holla , Arunachalam Ganapathy , Jens Wiklander , Sumit Garg Subject: [PATCH 2/4] firmware: arm_ffa: Remove incorrect assignment of driver_data Date: Fri, 29 Apr 2022 12:39:44 +0100 Message-Id: <20220429113946.2087145-2-sudeep.holla@arm.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220429113946.2087145-1-sudeep.holla@arm.com> References: <20220429113946.2087145-1-sudeep.holla@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220429_044003_535911_43D51ABF X-CRM114-Status: UNSURE ( 7.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The ffa core driver currently assigns its own driver information to individual ffa device driver_data which is wrong. Firstly, it leaks this core driver information to individual ffa_device and hence to ffa_driver. Secondly the ffa_device driver_data is for use by individual ffa_driver and not for this core driver managing all those devices. Fixes: d0c0bce83122 ("firmware: arm_ffa: Setup in-kernel users of FFA partitions") Signed-off-by: Sudeep Holla --- drivers/firmware/arm_ffa/driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index 6a913ac91e8e..ec731e9e942b 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -694,8 +694,6 @@ static void ffa_setup_partitions(void) __func__, tpbuf->id); continue; } - - ffa_dev_set_drvdata(ffa_dev, drv_info); } kfree(pbuf); }