| Message ID | 20220429185157.3673633-8-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge_connector: perform HPD enablement automatically | expand |
On 29/04/2022 21:51, Dmitry Baryshkov wrote: > Now as all drivers stopped calling drm_bridge_connector_enable_hpd() and > drm_bridge_connector_disable_hpd() it is safe to remove them complelely. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/drm_bridge_connector.c | 25 ------------------------- > include/drm/drm_bridge_connector.h | 2 -- > 2 files changed, 27 deletions(-) > > diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c > index 1592da3b9403..d9c1f61b6fb6 100644 > --- a/drivers/gpu/drm/drm_bridge_connector.c > +++ b/drivers/gpu/drm/drm_bridge_connector.c > @@ -128,18 +128,6 @@ static void drm_bridge_connector_hpd_cb(void *cb_data, > drm_kms_helper_hotplug_event(dev); > } > > -/** > - * drm_bridge_connector_enable_hpd - Enable hot-plug detection for the connector > - * @connector: The DRM bridge connector > - * > - * This function enables hot-plug detection for the given bridge connector. > - * This is typically used by display drivers in their resume handler. > - */ > -void drm_bridge_connector_enable_hpd(struct drm_connector *connector) > -{ > -} > -EXPORT_SYMBOL_GPL(drm_bridge_connector_enable_hpd); > - > static void _drm_bridge_connector_enable_hpd(struct drm_connector *connector) Here (and for _drm_bridge_connector_disable_hpd) you could remove the prefix underscore. Tomi
diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c index 1592da3b9403..d9c1f61b6fb6 100644 --- a/drivers/gpu/drm/drm_bridge_connector.c +++ b/drivers/gpu/drm/drm_bridge_connector.c @@ -128,18 +128,6 @@ static void drm_bridge_connector_hpd_cb(void *cb_data, drm_kms_helper_hotplug_event(dev); } -/** - * drm_bridge_connector_enable_hpd - Enable hot-plug detection for the connector - * @connector: The DRM bridge connector - * - * This function enables hot-plug detection for the given bridge connector. - * This is typically used by display drivers in their resume handler. - */ -void drm_bridge_connector_enable_hpd(struct drm_connector *connector) -{ -} -EXPORT_SYMBOL_GPL(drm_bridge_connector_enable_hpd); - static void _drm_bridge_connector_enable_hpd(struct drm_connector *connector) { struct drm_bridge_connector *bridge_connector = @@ -151,19 +139,6 @@ static void _drm_bridge_connector_enable_hpd(struct drm_connector *connector) bridge_connector); } -/** - * drm_bridge_connector_disable_hpd - Disable hot-plug detection for the - * connector - * @connector: The DRM bridge connector - * - * This function disables hot-plug detection for the given bridge connector. - * This is typically used by display drivers in their suspend handler. - */ -void drm_bridge_connector_disable_hpd(struct drm_connector *connector) -{ -} -EXPORT_SYMBOL_GPL(drm_bridge_connector_disable_hpd); - static void _drm_bridge_connector_disable_hpd(struct drm_connector *connector) { struct drm_bridge_connector *bridge_connector = diff --git a/include/drm/drm_bridge_connector.h b/include/drm/drm_bridge_connector.h index 33f6c3bbdb4a..69630815fb09 100644 --- a/include/drm/drm_bridge_connector.h +++ b/include/drm/drm_bridge_connector.h @@ -10,8 +10,6 @@ struct drm_connector; struct drm_device; struct drm_encoder; -void drm_bridge_connector_enable_hpd(struct drm_connector *connector); -void drm_bridge_connector_disable_hpd(struct drm_connector *connector); struct drm_connector *drm_bridge_connector_init(struct drm_device *drm, struct drm_encoder *encoder);
Now as all drivers stopped calling drm_bridge_connector_enable_hpd() and drm_bridge_connector_disable_hpd() it is safe to remove them complelely. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/drm_bridge_connector.c | 25 ------------------------- include/drm/drm_bridge_connector.h | 2 -- 2 files changed, 27 deletions(-)