diff mbox series

[v3] dt-bindings: arm: mediatek: mmsys: refine power and gce properties

Message ID 20220501090117.19557-1-jason-jh.lin@mediatek.com (mailing list archive)
State New, archived
Headers show
Series [v3] dt-bindings: arm: mediatek: mmsys: refine power and gce properties | expand

Commit Message

Jason-JH Lin (林睿祥) May 1, 2022, 9:01 a.m. UTC
Power:
  Refine description and add item number for power-domains property.

GCE:
  Refine description and add item number for mboxes property and
  mediatek,gce-client-reg property.

Fixes: 1da90b8a7bae ("dt-bindings: arm: mediatek: mmsys: add power and gce properties")
Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
---
Change in v3:
  Add maxItems condition for mboxes property.
---
 .../bindings/arm/mediatek/mediatek,mmsys.yaml | 34 ++++++++++++++-----
 1 file changed, 26 insertions(+), 8 deletions(-)

Comments

Krzysztof Kozlowski May 1, 2022, 10:47 a.m. UTC | #1
On 01/05/2022 11:01, Jason-JH.Lin wrote:
> Power:
>   Refine description and add item number for power-domains property.
> 
> GCE:
>   Refine description and add item number for mboxes property and
>   mediatek,gce-client-reg property.
> 
> Fixes: 1da90b8a7bae ("dt-bindings: arm: mediatek: mmsys: add power and gce properties")
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> ---
> Change in v3:
>   Add maxItems condition for mboxes property.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
AngeloGioacchino Del Regno May 2, 2022, 8:58 a.m. UTC | #2
Il 01/05/22 11:01, Jason-JH.Lin ha scritto:
> Power:
>    Refine description and add item number for power-domains property.
> 
> GCE:
>    Refine description and add item number for mboxes property and
>    mediatek,gce-client-reg property.
> 
> Fixes: 1da90b8a7bae ("dt-bindings: arm: mediatek: mmsys: add power and gce properties")
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
index 6ad023eec193..f36798792b8c 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
@@ -43,17 +43,19 @@  properties:
     maxItems: 1
 
   power-domains:
+    maxItems: 1
     description:
-      A phandle and PM domain specifier as defined by bindings
-      of the power controller specified by phandle. See
-      Documentation/devicetree/bindings/power/power-domain.yaml for details.
+      Each mmsys belongs to a power-domains. If mmsys wants to use PM
+      interface to control the power controller of mmsys, it should have
+      this property.
 
   mboxes:
     description:
-      Using mailbox to communicate with GCE, it should have this
-      property and list of phandle, mailbox specifiers. See
-      Documentation/devicetree/bindings/mailbox/mtk-gce.txt for details.
-    $ref: /schemas/types.yaml#/definitions/phandle-array
+      If using mailbox to communicate with GCE, it should have this
+      property. GCE will help configure the hardware settings for the
+      current mmsys data pipeline.
+    minItems: 1
+    maxItems: 24
 
   mediatek,gce-client-reg:
     description:
@@ -64,7 +66,12 @@  properties:
       register which is defined in the gce header
       include/dt-bindings/gce/<chip>-gce.h.
     $ref: /schemas/types.yaml#/definitions/phandle-array
-    maxItems: 1
+    items:
+      - items:
+          - description: phandle to GCE
+          - description: subsys id
+          - description: register offset
+          - description: register size
 
   "#clock-cells":
     const: 1
@@ -77,6 +84,17 @@  required:
   - reg
   - "#clock-cells"
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: mediatek,mt8173-mmsys
+    then:
+      properties:
+        mboxes:
+          maxItems: 16
+
 additionalProperties: false
 
 examples: