From patchwork Mon May 2 09:02:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hector Martin X-Patchwork-Id: 12834010 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EE70C433EF for ; Mon, 2 May 2022 09:04:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+mUGtMTpT959lPoO30rZV3ZoKPlxIb9lDrCn4rrytG0=; b=b/Y3u9rSj1T7dj 95h8dSDVHcb5kWeINf7Sy6obolvroWQUtzWUJxnUDD703ggPNm1TNaIAQrGsnEAU0MdqtiMroZ1Eo crtp1FPhYG4/j5J1DJICPx6Za9ban6pubAwFiFEFfM8OGaO0Ts27PFuDVAAr8vVZ7pukDuapgoB7Z NVcga6nAQYRRQCglJnsukaGKgZqYXwC6uuxiIC+ZFE70d46JxItbrmRZf6ALiQfc445xKFFEbmDfM Y9oS2YUWk36jR36MS66HFnp8lTldRC4CS7apqvQ7jPc+rIBPt72mNzZ2ol3RMQen90kUR2JSpk6vj Go4ZwrOE79W/yif3sLRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlRxm-000VWH-9h; Mon, 02 May 2022 09:03:26 +0000 Received: from marcansoft.com ([212.63.210.85] helo=mail.marcansoft.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlRxG-000VDY-76 for linux-arm-kernel@lists.infradead.org; Mon, 02 May 2022 09:02:57 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hector@marcansoft.com) by mail.marcansoft.com (Postfix) with ESMTPSA id 90BE54206F; Mon, 2 May 2022 09:02:42 +0000 (UTC) From: Hector Martin To: Cc: Hector Martin , Anup Patel , Vinod Koul , Sven Peter , Alyssa Rosenzweig , Mun Yew Tham , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Michal Simek , Arnd Bergmann , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH 3/7] mailbox: ti-msgmgr Remove unused ti_msgmgr_queue_peek_data Date: Mon, 2 May 2022 18:02:21 +0900 Message-Id: <20220502090225.26478-4-marcan@marcan.st> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220502090225.26478-1-marcan@marcan.st> References: <20220502090225.26478-1-marcan@marcan.st> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220502_020254_467219_9D67D384 X-CRM114-Status: GOOD ( 12.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This op was ambiguously specified, and the way it was interpreted for this implementation is not useful. It has no users, so remove it. Signed-off-by: Hector Martin --- drivers/mailbox/ti-msgmgr.c | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/drivers/mailbox/ti-msgmgr.c b/drivers/mailbox/ti-msgmgr.c index ddac423ac1a9..10881b812df2 100644 --- a/drivers/mailbox/ti-msgmgr.c +++ b/drivers/mailbox/ti-msgmgr.c @@ -309,33 +309,6 @@ static irqreturn_t ti_msgmgr_queue_rx_interrupt(int irq, void *p) return IRQ_HANDLED; } -/** - * ti_msgmgr_queue_peek_data() - Peek to see if there are any rx messages. - * @chan: Channel Pointer - * - * Return: 'true' if there is pending rx data, 'false' if there is none. - */ -static bool ti_msgmgr_queue_peek_data(struct mbox_chan *chan) -{ - struct ti_queue_inst *qinst = chan->con_priv; - struct device *dev = chan->mbox->dev; - struct ti_msgmgr_inst *inst = dev_get_drvdata(dev); - const struct ti_msgmgr_desc *desc = inst->desc; - int msg_count; - - if (qinst->is_tx) - return false; - - if (ti_msgmgr_queue_is_error(desc, qinst)) { - dev_err(dev, "Error on channel %s\n", qinst->name); - return false; - } - - msg_count = ti_msgmgr_queue_get_num_messages(desc, qinst); - - return msg_count ? true : false; -} - /** * ti_msgmgr_last_tx_done() - See if all the tx messages are sent * @chan: Channel pointer @@ -744,7 +717,6 @@ static DEFINE_SIMPLE_DEV_PM_OPS(ti_msgmgr_pm_ops, ti_msgmgr_suspend, ti_msgmgr_r static const struct mbox_chan_ops ti_msgmgr_chan_ops = { .startup = ti_msgmgr_queue_startup, .shutdown = ti_msgmgr_queue_shutdown, - .peek_data = ti_msgmgr_queue_peek_data, .last_tx_done = ti_msgmgr_last_tx_done, .send_data = ti_msgmgr_send_data, };