diff mbox series

[1/2] dt-bindings: power: Add MediaTek Helio X10 MT6795 power domains

Message ID 20220503105436.54901-2-angelogioacchino.delregno@collabora.com (mailing list archive)
State New, archived
Headers show
Series MediaTek Helio X10 MT6795 - power domains | expand

Commit Message

AngeloGioacchino Del Regno May 3, 2022, 10:54 a.m. UTC
Add power domains dt-bindings for MediaTek Helio X10 (MT6795).

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 .../power/mediatek,power-controller.yaml         |  2 ++
 include/dt-bindings/power/mt6795-power.h         | 16 ++++++++++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 include/dt-bindings/power/mt6795-power.h

Comments

Krzysztof Kozlowski May 3, 2022, 12:38 p.m. UTC | #1
On 03/05/2022 12:54, AngeloGioacchino Del Regno wrote:
> Add power domains dt-bindings for MediaTek Helio X10 (MT6795).
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  .../power/mediatek,power-controller.yaml         |  2 ++
>  include/dt-bindings/power/mt6795-power.h         | 16 ++++++++++++++++
>  2 files changed, 18 insertions(+)
>  create mode 100644 include/dt-bindings/power/mt6795-power.h
> 
> diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> index 135c6f722091..b448101fac43 100644
> --- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> +++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> @@ -23,6 +23,7 @@ properties:
>  
>    compatible:
>      enum:
> +      - mediatek,mt6795-power-controller
>        - mediatek,mt8167-power-controller
>        - mediatek,mt8173-power-controller
>        - mediatek,mt8183-power-controller
> @@ -62,6 +63,7 @@ patternProperties:
>        reg:
>          description: |
>            Power domain index. Valid values are defined in:
> +              "include/dt-bindings/power/mt6795-power.h" - for MT8167 type power domain.
>                "include/dt-bindings/power/mt8167-power.h" - for MT8167 type power domain.
>                "include/dt-bindings/power/mt8173-power.h" - for MT8173 type power domain.
>                "include/dt-bindings/power/mt8183-power.h" - for MT8183 type power domain.
> diff --git a/include/dt-bindings/power/mt6795-power.h b/include/dt-bindings/power/mt6795-power.h
> new file mode 100644
> index 000000000000..0e27bc7fa748
> --- /dev/null
> +++ b/include/dt-bindings/power/mt6795-power.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

If it is not a derivative work, should be GPL-2.0 OR BSD


Best regards,
Krzysztof
AngeloGioacchino Del Regno May 3, 2022, 12:43 p.m. UTC | #2
Il 03/05/22 14:38, Krzysztof Kozlowski ha scritto:
> On 03/05/2022 12:54, AngeloGioacchino Del Regno wrote:
>> Add power domains dt-bindings for MediaTek Helio X10 (MT6795).
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>>   .../power/mediatek,power-controller.yaml         |  2 ++
>>   include/dt-bindings/power/mt6795-power.h         | 16 ++++++++++++++++
>>   2 files changed, 18 insertions(+)
>>   create mode 100644 include/dt-bindings/power/mt6795-power.h
>>
>> diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
>> index 135c6f722091..b448101fac43 100644
>> --- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
>> +++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
>> @@ -23,6 +23,7 @@ properties:
>>   
>>     compatible:
>>       enum:
>> +      - mediatek,mt6795-power-controller
>>         - mediatek,mt8167-power-controller
>>         - mediatek,mt8173-power-controller
>>         - mediatek,mt8183-power-controller
>> @@ -62,6 +63,7 @@ patternProperties:
>>         reg:
>>           description: |
>>             Power domain index. Valid values are defined in:
>> +              "include/dt-bindings/power/mt6795-power.h" - for MT8167 type power domain.
>>                 "include/dt-bindings/power/mt8167-power.h" - for MT8167 type power domain.
>>                 "include/dt-bindings/power/mt8173-power.h" - for MT8173 type power domain.
>>                 "include/dt-bindings/power/mt8183-power.h" - for MT8183 type power domain.
>> diff --git a/include/dt-bindings/power/mt6795-power.h b/include/dt-bindings/power/mt6795-power.h
>> new file mode 100644
>> index 000000000000..0e27bc7fa748
>> --- /dev/null
>> +++ b/include/dt-bindings/power/mt6795-power.h
>> @@ -0,0 +1,16 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
> 
> If it is not a derivative work, should be GPL-2.0 OR BSD
> 

On that, I agree with you, fully.

Though, all of the mt(xxxx)-power.h headers provide this license tag and I
wanted to follow that to give the same.

Should I change it to (GPL-2.0-only OR BSD-2-Clause)?

Regards,
Angelo

> 
> Best regards,
> Krzysztof
Krzysztof Kozlowski May 3, 2022, 12:57 p.m. UTC | #3
On 03/05/2022 14:43, AngeloGioacchino Del Regno wrote:
>>
>> If it is not a derivative work, should be GPL-2.0 OR BSD
>>
> 
> On that, I agree with you, fully.
> 
> Though, all of the mt(xxxx)-power.h headers provide this license tag and I
> wanted to follow that to give the same.
> 
> Should I change it to (GPL-2.0-only OR BSD-2-Clause)?

Yes, please, for this one.

For the other bindings - you would need acks from people involved.

Best regards,
Krzysztof
AngeloGioacchino Del Regno May 3, 2022, 12:58 p.m. UTC | #4
Il 03/05/22 14:57, Krzysztof Kozlowski ha scritto:
> On 03/05/2022 14:43, AngeloGioacchino Del Regno wrote:
>>>
>>> If it is not a derivative work, should be GPL-2.0 OR BSD
>>>
>>
>> On that, I agree with you, fully.
>>
>> Though, all of the mt(xxxx)-power.h headers provide this license tag and I
>> wanted to follow that to give the same.
>>
>> Should I change it to (GPL-2.0-only OR BSD-2-Clause)?
> 
> Yes, please, for this one.
> 
> For the other bindings - you would need acks from people involved.
> 

I'm glad to read this. I'll change it in the next version. Thank you!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
index 135c6f722091..b448101fac43 100644
--- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
+++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
@@ -23,6 +23,7 @@  properties:
 
   compatible:
     enum:
+      - mediatek,mt6795-power-controller
       - mediatek,mt8167-power-controller
       - mediatek,mt8173-power-controller
       - mediatek,mt8183-power-controller
@@ -62,6 +63,7 @@  patternProperties:
       reg:
         description: |
           Power domain index. Valid values are defined in:
+              "include/dt-bindings/power/mt6795-power.h" - for MT8167 type power domain.
               "include/dt-bindings/power/mt8167-power.h" - for MT8167 type power domain.
               "include/dt-bindings/power/mt8173-power.h" - for MT8173 type power domain.
               "include/dt-bindings/power/mt8183-power.h" - for MT8183 type power domain.
diff --git a/include/dt-bindings/power/mt6795-power.h b/include/dt-bindings/power/mt6795-power.h
new file mode 100644
index 000000000000..0e27bc7fa748
--- /dev/null
+++ b/include/dt-bindings/power/mt6795-power.h
@@ -0,0 +1,16 @@ 
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _DT_BINDINGS_POWER_MT6795_POWER_H
+#define _DT_BINDINGS_POWER_MT6795_POWER_H
+
+#define MT6795_POWER_DOMAIN_MM		0
+#define MT6795_POWER_DOMAIN_VDEC	1
+#define MT6795_POWER_DOMAIN_VENC	2
+#define MT6795_POWER_DOMAIN_ISP		3
+#define MT6795_POWER_DOMAIN_MJC		4
+#define MT6795_POWER_DOMAIN_AUDIO	5
+#define MT6795_POWER_DOMAIN_MFG_ASYNC	6
+#define MT6795_POWER_DOMAIN_MFG_2D	7
+#define MT6795_POWER_DOMAIN_MFG		8
+#define MT6795_POWER_DOMAIN_MODEM	9
+
+#endif /* _DT_BINDINGS_POWER_MT6795_POWER_H */