| Message ID | 20220504100555.96007-1-nbd@nbd.name (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | PCI: mediatek-gen3: change driver name to mtk-pcie-gen3 | expand |
On Wed, May 04, 2022 at 12:05:55PM +0200, Felix Fietkau wrote: > This allows it to coexist with the other mtk pcie driver in the same kernel I assume this is a v3 of [1]. Please: - Follow the subject line capitalization convention, i.e., "PCI: mediatek-gen3: Change ..." - Expand the commit log to say why this is important. From a C language level, using the same "mtk-pcie" string in both drivers is no problem. So please mention where it *is* a problem, e.g., if it's a problem with modprobe or similar, say that. Or if it's to make log messages in dmesg have different driver names, say that. - s/pcie/PCIe/ in commit log and other English text. - Add a period at the end of the commit log sentence. [1] https://lore.kernel.org/r/20220422070908.14043-1-jianjun.wang@mediatek.com > Signed-off-by: Felix Fietkau <nbd@nbd.name> > --- > drivers/pci/controller/pcie-mediatek-gen3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c > index 3e8d70bfabc6..2e665cd7e735 100644 > --- a/drivers/pci/controller/pcie-mediatek-gen3.c > +++ b/drivers/pci/controller/pcie-mediatek-gen3.c > @@ -1021,7 +1021,7 @@ static struct platform_driver mtk_pcie_driver = { > .probe = mtk_pcie_probe, > .remove = mtk_pcie_remove, > .driver = { > - .name = "mtk-pcie", > + .name = "mtk-pcie-gen3", > .of_match_table = mtk_pcie_of_match, > .pm = &mtk_pcie_pm_ops, > }, > -- > 2.35.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 04.05.22 19:06, Bjorn Helgaas wrote: > On Wed, May 04, 2022 at 12:05:55PM +0200, Felix Fietkau wrote: >> This allows it to coexist with the other mtk pcie driver in the same kernel > > I assume this is a v3 of [1]. Please: Thanks, I wasn't aware of that patch. > - Follow the subject line capitalization convention, i.e., > "PCI: mediatek-gen3: Change ..." > > - Expand the commit log to say why this is important. From a C > language level, using the same "mtk-pcie" string in both drivers > is no problem. So please mention where it *is* a problem, e.g., > if it's a problem with modprobe or similar, say that. Or if it's > to make log messages in dmesg have different driver names, say > that.The reason is the fact that driver_register will refuse to register a driver if one with the same name has already been registered. > - s/pcie/PCIe/ in commit log and other English text. > > - Add a period at the end of the commit log sentence. > > [1] https://lore.kernel.org/r/20220422070908.14043-1-jianjun.wang@mediatek.com Will take care of this and send an updated version as v3. - Felix
diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c index 3e8d70bfabc6..2e665cd7e735 100644 --- a/drivers/pci/controller/pcie-mediatek-gen3.c +++ b/drivers/pci/controller/pcie-mediatek-gen3.c @@ -1021,7 +1021,7 @@ static struct platform_driver mtk_pcie_driver = { .probe = mtk_pcie_probe, .remove = mtk_pcie_remove, .driver = { - .name = "mtk-pcie", + .name = "mtk-pcie-gen3", .of_match_table = mtk_pcie_of_match, .pm = &mtk_pcie_pm_ops, },
This allows it to coexist with the other mtk pcie driver in the same kernel Signed-off-by: Felix Fietkau <nbd@nbd.name> --- drivers/pci/controller/pcie-mediatek-gen3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)