| Message ID | 20220507100910.93705-1-renzhijie2@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,-next] drm/rockchip: Fix Kconfig dependencies | expand |
Hi Zhijie: On 5/7/22 18:09, Ren Zhijie wrote: > drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_connector_mode_valid': > cdn-dp-core.c:(.text+0x1e1): undefined reference to `drm_dp_bw_code_to_link_rate' > cdn-dp-core.c:(.text+0x1f4): undefined reference to `drm_dp_bw_code_to_link_rate' > drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_pd_event_work': > cdn-dp-core.c:(.text+0x138e): undefined reference to `drm_dp_channel_eq_ok' > drivers/gpu/drm/rockchip/cdn-dp-reg.o: In function `cdn_dp_train_link': > cdn-dp-reg.c:(.text+0xd5a): undefined reference to `drm_dp_bw_code_to_link_rate' > > The DP-helper module has been replaced by the display-helper module. > So the driver have to select it. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: 1e0f66420b13("drm/display: Introduce a DRM display-helper module") > Signed-off-by: Ren Zhijie <renzhijie2@huawei.com> Thanks. Reviewed-by: Andy Yan <andy.yan@rock-chips.com> > --- > v2: remove "select DRM_DISPLAY_HELPER if ROCKCHIP_ANALOGIX_DP" under DRM_ROCKCHIP at the head, > and separately add the select for ROCKCHIP_ANALOGIX_DP and ROCKCHIP_CDN_DP, which Andy suggested. > --- > --- > drivers/gpu/drm/rockchip/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig > index 5afab49dc4f2..53c2d9980d48 100644 > --- a/drivers/gpu/drm/rockchip/Kconfig > +++ b/drivers/gpu/drm/rockchip/Kconfig > @@ -2,7 +2,6 @@ > config DRM_ROCKCHIP > tristate "DRM Support for Rockchip" > depends on DRM && ROCKCHIP_IOMMU > - select DRM_DISPLAY_HELPER if ROCKCHIP_ANALOGIX_DP > select DRM_GEM_CMA_HELPER > select DRM_KMS_HELPER > select DRM_PANEL > @@ -38,6 +37,7 @@ config ROCKCHIP_VOP2 > config ROCKCHIP_ANALOGIX_DP > bool "Rockchip specific extensions for Analogix DP driver" > depends on ROCKCHIP_VOP > + select DRM_DISPLAY_HELPER > select DRM_DISPLAY_DP_HELPER > help > This selects support for Rockchip SoC specific extensions > @@ -47,6 +47,8 @@ config ROCKCHIP_ANALOGIX_DP > config ROCKCHIP_CDN_DP > bool "Rockchip cdn DP" > depends on EXTCON=y || (EXTCON=m && DRM_ROCKCHIP=m) > + select DRM_DISPLAY_HELPER > + select DRM_DISPLAY_DP_HELPER > help > This selects support for Rockchip SoC specific extensions > for the cdn DP driver. If you want to enable Dp on
On Sat, 7 May 2022 18:09:10 +0800, Ren Zhijie wrote: > The DP-helper module has been replaced by the display-helper module. > So the driver have to select it. Applied, thanks! [1/1] drm/rockchip: Fix Kconfig dependencies commit: 0b752df77633cc4c3606a6187e3ad37ad6925c15 Best regards,
diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig index 5afab49dc4f2..53c2d9980d48 100644 --- a/drivers/gpu/drm/rockchip/Kconfig +++ b/drivers/gpu/drm/rockchip/Kconfig @@ -2,7 +2,6 @@ config DRM_ROCKCHIP tristate "DRM Support for Rockchip" depends on DRM && ROCKCHIP_IOMMU - select DRM_DISPLAY_HELPER if ROCKCHIP_ANALOGIX_DP select DRM_GEM_CMA_HELPER select DRM_KMS_HELPER select DRM_PANEL @@ -38,6 +37,7 @@ config ROCKCHIP_VOP2 config ROCKCHIP_ANALOGIX_DP bool "Rockchip specific extensions for Analogix DP driver" depends on ROCKCHIP_VOP + select DRM_DISPLAY_HELPER select DRM_DISPLAY_DP_HELPER help This selects support for Rockchip SoC specific extensions @@ -47,6 +47,8 @@ config ROCKCHIP_ANALOGIX_DP config ROCKCHIP_CDN_DP bool "Rockchip cdn DP" depends on EXTCON=y || (EXTCON=m && DRM_ROCKCHIP=m) + select DRM_DISPLAY_HELPER + select DRM_DISPLAY_DP_HELPER help This selects support for Rockchip SoC specific extensions for the cdn DP driver. If you want to enable Dp on
drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_connector_mode_valid': cdn-dp-core.c:(.text+0x1e1): undefined reference to `drm_dp_bw_code_to_link_rate' cdn-dp-core.c:(.text+0x1f4): undefined reference to `drm_dp_bw_code_to_link_rate' drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_pd_event_work': cdn-dp-core.c:(.text+0x138e): undefined reference to `drm_dp_channel_eq_ok' drivers/gpu/drm/rockchip/cdn-dp-reg.o: In function `cdn_dp_train_link': cdn-dp-reg.c:(.text+0xd5a): undefined reference to `drm_dp_bw_code_to_link_rate' The DP-helper module has been replaced by the display-helper module. So the driver have to select it. Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: 1e0f66420b13("drm/display: Introduce a DRM display-helper module") Signed-off-by: Ren Zhijie <renzhijie2@huawei.com> --- v2: remove "select DRM_DISPLAY_HELPER if ROCKCHIP_ANALOGIX_DP" under DRM_ROCKCHIP at the head, and separately add the select for ROCKCHIP_ANALOGIX_DP and ROCKCHIP_CDN_DP, which Andy suggested. --- --- drivers/gpu/drm/rockchip/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)