diff mbox series

[V2] arm64: Declare non global symbols as static

Message ID 20220509043221.16361-1-lcherian@marvell.com (mailing list archive)
State New, archived
Headers show
Series [V2] arm64: Declare non global symbols as static | expand

Commit Message

Linu Cherian May 9, 2022, 4:32 a.m. UTC
Fix below sparse warnings introduced while adding errata.

arch/arm64/kernel/cpu_errata.c:218:25: sparse: warning: symbol
'cavium_erratum_23154_cpus' was not declared. Should it be static?

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Linu Cherian <lcherian@marvell.com>
---
Changes from V1:
Reverted change to global symbol cavium_erratum_27456_cpus since it
was used in other files.

 arch/arm64/kernel/cpu_errata.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Will Deacon May 10, 2022, 11:05 a.m. UTC | #1
On Mon, May 09, 2022 at 10:02:21AM +0530, Linu Cherian wrote:
> Fix below sparse warnings introduced while adding errata.
> 
> arch/arm64/kernel/cpu_errata.c:218:25: sparse: warning: symbol
> 'cavium_erratum_23154_cpus' was not declared. Should it be static?
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Linu Cherian <lcherian@marvell.com>
> ---
> Changes from V1:
> Reverted change to global symbol cavium_erratum_27456_cpus since it
> was used in other files.
> 
>  arch/arm64/kernel/cpu_errata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Will Deacon <will@kernel.org>

Will
Catalin Marinas May 11, 2022, 4:10 p.m. UTC | #2
On Mon, 9 May 2022 10:02:21 +0530, Linu Cherian wrote:
> Fix below sparse warnings introduced while adding errata.
> 
> arch/arm64/kernel/cpu_errata.c:218:25: sparse: warning: symbol
> 'cavium_erratum_23154_cpus' was not declared. Should it be static?
> 
> 

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64: Declare non global symbols as static
      https://git.kernel.org/arm64/c/710c8d6c026c
diff mbox series

Patch

diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
index 4c9b5b4b7a0b..49f4863c6c56 100644
--- a/arch/arm64/kernel/cpu_errata.c
+++ b/arch/arm64/kernel/cpu_errata.c
@@ -215,7 +215,7 @@  static const struct arm64_cpu_capabilities arm64_repeat_tlbi_list[] = {
 #endif
 
 #ifdef CONFIG_CAVIUM_ERRATUM_23154
-const struct midr_range cavium_erratum_23154_cpus[] = {
+static const struct midr_range cavium_erratum_23154_cpus[] = {
 	MIDR_ALL_VERSIONS(MIDR_THUNDERX),
 	MIDR_ALL_VERSIONS(MIDR_THUNDERX_81XX),
 	MIDR_ALL_VERSIONS(MIDR_THUNDERX_83XX),