diff mbox series

[1/1] ARM: dts: imx7: Move hsic_phy power domain to HSIC PHY node

Message ID 20220509110708.2190558-1-alexander.stein@ew.tq-group.com (mailing list archive)
State New, archived
Headers show
Series [1/1] ARM: dts: imx7: Move hsic_phy power domain to HSIC PHY node | expand

Commit Message

Alexander Stein May 9, 2022, 11:07 a.m. UTC
Move the power domain to its actual user. This keeps the power domain
enabled even when the USB host is runtime suspended. This is necessary
to detect any downstream events, like device attach.

Suggested-by: Jun Li <jun.li@nxp.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
This patch superseeds the initial patch from [1].

[1] https://lore.kernel.org/linux-arm-kernel/5566202.DvuYhMxLoT@steina-w/T/
 arch/arm/boot/dts/imx7s.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jun Li May 10, 2022, 3:12 a.m. UTC | #1
> -----Original Message-----
> From: Alexander Stein <alexander.stein@ew.tq-group.com>
> Sent: Monday, May 9, 2022 7:07 PM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo <shawnguo@kernel.org>;
> Sascha Hauer <s.hauer@pengutronix.de>; Fabio Estevam <festevam@gmail.com>
> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Jun Li
> <jun.li@nxp.com>
> Subject: [PATCH 1/1] ARM: dts: imx7: Move hsic_phy power domain to HSIC PHY
> node
> 
> Move the power domain to its actual user. This keeps the power domain enabled
> even when the USB host is runtime suspended. This is necessary to detect
> any downstream events, like device attach.
> 
> Suggested-by: Jun Li <jun.li@nxp.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

This is a fix and should be applied to stable tree too.

Li Jun  

> ---
> This patch superseeds the initial patch from [1].
> 
> [1]
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.
> kernel.org%2Flinux-arm-kernel%2F5566202.DvuYhMxLoT%40steina-w%2FT%2F&am
> p;data=05%7C01%7Cjun.li%40nxp.com%7Cae99c3d6780d4f4b513c08da31ac14c5%7C
> 686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637876912401414970%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX
> VCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=vKVI%2F%2BIrMJejYM%2BYEex2TCxskxPu
> IZeLxYWSKFw%2FKZk%3D&amp;reserved=0
>  arch/arm/boot/dts/imx7s.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index 008e3da460f1..039eed79d2e7 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -120,6 +120,7 @@ usbphynop3: usbphynop3 {
>  		compatible = "usb-nop-xceiv";
>  		clocks = <&clks IMX7D_USB_HSIC_ROOT_CLK>;
>  		clock-names = "main_clk";
> +		power-domains = <&pgc_hsic_phy>;
>  		#phy-cells = <0>;
>  	};
> 
> @@ -1153,7 +1154,6 @@ usbh: usb@30b30000 {
>  				compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
>  				reg = <0x30b30000 0x200>;
>  				interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
> -				power-domains = <&pgc_hsic_phy>;
>  				clocks = <&clks IMX7D_USB_CTRL_CLK>;
>  				fsl,usbphy = <&usbphynop3>;
>  				fsl,usbmisc = <&usbmisc3 0>;
> --
> 2.25.1
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index 008e3da460f1..039eed79d2e7 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -120,6 +120,7 @@  usbphynop3: usbphynop3 {
 		compatible = "usb-nop-xceiv";
 		clocks = <&clks IMX7D_USB_HSIC_ROOT_CLK>;
 		clock-names = "main_clk";
+		power-domains = <&pgc_hsic_phy>;
 		#phy-cells = <0>;
 	};
 
@@ -1153,7 +1154,6 @@  usbh: usb@30b30000 {
 				compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
 				reg = <0x30b30000 0x200>;
 				interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
-				power-domains = <&pgc_hsic_phy>;
 				clocks = <&clks IMX7D_USB_CTRL_CLK>;
 				fsl,usbphy = <&usbphynop3>;
 				fsl,usbmisc = <&usbmisc3 0>;