| Message ID | 20220510015229.139818-9-nobuhiro1.iwamatsu@toshiba.co.jp (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Visconti5: Update the clock providers | expand |
On Tue, May 10, 2022 at 10:52:28AM +0900, Nobuhiro Iwamatsu wrote: > The clock for this driver switched to the common clock controller driver. > Therefore, update common clock properties for watchdog in the binding document. > The examples are just that, examples. If this needs to exactly match your dts file, why isn't the dts file the example? > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > --- > .../bindings/watchdog/toshiba,visconti-wdt.yaml | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) But fine: Acked-by: Rob Herring <robh@kernel.org>
Hi, Thanks for your review. > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Wednesday, May 18, 2022 5:50 AM > To: iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) > <nobuhiro1.iwamatsu@toshiba.co.jp> > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Arnd > Bergmann <arnd@arndb.de>; Olof Johansson <olof@lixom.net>; ishikawa > yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開) <yuji2.ishikawa@toshiba.co.jp> > Subject: Re: [PATCH 8/9] dt-bindings: watchdog: toshiba,visconti-wdt: > Update the common clock properties > > On Tue, May 10, 2022 at 10:52:28AM +0900, Nobuhiro Iwamatsu wrote: > > The clock for this driver switched to the common clock controller driver. > > Therefore, update common clock properties for watchdog in the binding > document. > > > > The examples are just that, examples. If this needs to exactly match your dts > file, why isn't the dts file the example? I will update the example as well in next version. > > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > > --- > > .../bindings/watchdog/toshiba,visconti-wdt.yaml | 10 +++------- > > 1 file changed, 3 insertions(+), 7 deletions(-) > > But fine: > > Acked-by: Rob Herring <robh@kernel.org> Thank you. Best regards, Nobuhiro
diff --git a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml index 690e19ce4b87..edfefb97b6b1 100644 --- a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml @@ -35,20 +35,16 @@ additionalProperties: false examples: - | + #include <dt-bindings/clock/toshiba,tmpv770x.h> + soc { #address-cells = <2>; #size-cells = <2>; - wdt_clk: wdt-clk { - compatible = "fixed-clock"; - clock-frequency = <150000000>; - #clock-cells = <0>; - }; - watchdog@28330000 { compatible = "toshiba,visconti-wdt"; reg = <0 0x28330000 0 0x1000>; - clocks = <&wdt_clk>; + clocks = <&pismu TMPV770X_CLK_WDTCLK>; timeout-sec = <20>; }; };
The clock for this driver switched to the common clock controller driver. Therefore, update common clock properties for watchdog in the binding document. Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> --- .../bindings/watchdog/toshiba,visconti-wdt.yaml | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)