| Message ID | 20220512034652.61134-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: mstar: Fix refcount leaks | expand |
Hi, Le jeu. 12 mai 2022 à 05:47, Miaoqian Lin <linmq006@gmail.com> a écrit : > > of_find_compatible_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when done. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 5919eec0f092 ("ARM: mstar: SMP support") > Fixes: 312b62b6610c ("ARM: mstar: Add machine for MStar/Sigmastar Armv7 SoCs") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Looks good to me, Reviewed-by: Romain Perier <romain.perier@gmail.com>
diff --git a/arch/arm/mach-mstar/mstarv7.c b/arch/arm/mach-mstar/mstarv7.c index 274c4f0df270..3176998817d2 100644 --- a/arch/arm/mach-mstar/mstarv7.c +++ b/arch/arm/mach-mstar/mstarv7.c @@ -86,6 +86,7 @@ static int mstarv7_boot_secondary(unsigned int cpu, struct task_struct *idle) np = of_find_compatible_node(NULL, NULL, "mstar,smpctrl"); smpctrl = of_iomap(np, 0); + of_node_put(np); if (!smpctrl) return -ENODEV; @@ -120,6 +121,7 @@ static void __init mstarv7_init(void) soc_mb = mstarv7_mb; else pr_warn("Failed to install memory barrier, DMA will be broken!\n"); + of_node_put(np); } DT_MACHINE_START(MSTARV7_DT, "MStar/Sigmastar Armv7 (Device Tree)")
of_find_compatible_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 5919eec0f092 ("ARM: mstar: SMP support") Fixes: 312b62b6610c ("ARM: mstar: Add machine for MStar/Sigmastar Armv7 SoCs") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- arch/arm/mach-mstar/mstarv7.c | 2 ++ 1 file changed, 2 insertions(+)