diff mbox series

[03/11] dt-bindings: soc: bcm: bcm2835-pm: Add support for bcm2711

Message ID 20220515202032.3046-4-stefan.wahren@i2se.com (mailing list archive)
State New, archived
Headers show
Series soc: bcm2835-power: Prepare BCM2711 V3D support | expand

Commit Message

Stefan Wahren May 15, 2022, 8:20 p.m. UTC
Add a new compatible string for BCM2711 and the option to provide a
third reg property for the board's new RPiVid ASB.

In BCM2711 the new RPiVid ASB took over V3D, which is our only consumer
of this driver so far. The old ASB is still be present with ISP and H264
bits but no V3D.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 .../bindings/soc/bcm/brcm,bcm2835-pm.yaml     | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

Comments

Rob Herring May 18, 2022, 12:55 a.m. UTC | #1
On Sun, May 15, 2022 at 10:20:24PM +0200, Stefan Wahren wrote:
> Add a new compatible string for BCM2711 and the option to provide a
> third reg property for the board's new RPiVid ASB.
> 
> In BCM2711 the new RPiVid ASB took over V3D, which is our only consumer
> of this driver so far. The old ASB is still be present with ISP and H264
> bits but no V3D.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>  .../bindings/soc/bcm/brcm,bcm2835-pm.yaml     | 19 +++++++++++++------
>  1 file changed, 13 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
> index 883ab7cb96e9..e13ce98d1753 100644
> --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
> @@ -19,17 +19,24 @@ allOf:
>  properties:
>    compatible:
>      items:
> -      - const: brcm,bcm2835-pm
> +      - enum:
> +          - brcm,bcm2835-pm
> +          - brcm,bcm2711-pm
>        - const: brcm,bcm2835-pm-wdt
>  
>    reg:
> -    minItems: 2
> -    maxItems: 2
> +    minItems: 1
> +    maxItems: 3
>  
>    reg-names:
> -    items:
> -      - const: pm
> -      - const: asb
> +    oneOf:
> +      - items:
> +          - const: pm
> +          - const: asb
> +      - items:
> +          - const: pm
> +          - const: asb
> +          - const: rpivid_asb

This can be simplified to:

minItems: 2
items:
  - const: pm
  - const: asb
  - const: rpivid_asb

>  
>    "#power-domain-cells":
>      const: 1
> -- 
> 2.25.1
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
index 883ab7cb96e9..e13ce98d1753 100644
--- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
+++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
@@ -19,17 +19,24 @@  allOf:
 properties:
   compatible:
     items:
-      - const: brcm,bcm2835-pm
+      - enum:
+          - brcm,bcm2835-pm
+          - brcm,bcm2711-pm
       - const: brcm,bcm2835-pm-wdt
 
   reg:
-    minItems: 2
-    maxItems: 2
+    minItems: 1
+    maxItems: 3
 
   reg-names:
-    items:
-      - const: pm
-      - const: asb
+    oneOf:
+      - items:
+          - const: pm
+          - const: asb
+      - items:
+          - const: pm
+          - const: asb
+          - const: rpivid_asb
 
   "#power-domain-cells":
     const: 1