diff mbox series

[v3,3/4] ARM: only use -mtp=cp15 for the compiler

Message ID 20220516210954.1660716-4-ndesaulniers@google.com (mailing list archive)
State New, archived
Headers show
Series pass -march= only to compiler | expand

Commit Message

Nick Desaulniers May 16, 2022, 9:09 p.m. UTC
Avoids an error from the assembler for CONFIG_THUMB2 kernels:

clang-15: error: hardware TLS register is not supported for the thumbv4t
sub-architecture

This flag only makes sense to pass to the compiler, not the assembler.

Perhaps CFLAGS_ABI can be renamed to CPPFLAGS_ABI to reflect that they
will be passed to both the compiler and assembler for sources that
require pre-processing.

Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
 arch/arm/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nick Desaulniers May 16, 2022, 9:15 p.m. UTC | #1
+ Ard (I messed up my command line invocation of git send-email, sorry
for more noise)
https://lore.kernel.org/llvm/20220516210954.1660716-1-ndesaulniers@google.com/

On Mon, May 16, 2022 at 2:10 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> Avoids an error from the assembler for CONFIG_THUMB2 kernels:
>
> clang-15: error: hardware TLS register is not supported for the thumbv4t
> sub-architecture
>
> This flag only makes sense to pass to the compiler, not the assembler.
>
> Perhaps CFLAGS_ABI can be renamed to CPPFLAGS_ABI to reflect that they
> will be passed to both the compiler and assembler for sources that
> require pre-processing.
>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
>  arch/arm/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 99a7ed7e9f09..1029c2503aef 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -108,7 +108,7 @@ CFLAGS_ABI  += -meabi gnu
>  endif
>
>  ifeq ($(CONFIG_CURRENT_POINTER_IN_TPIDRURO),y)
> -CFLAGS_ABI     += -mtp=cp15
> +KBUILD_CFLAGS  += -mtp=cp15
>  endif
>
>  # Accept old syntax despite ".syntax unified"
> --
> 2.36.0.550.gb090851708-goog
>
diff mbox series

Patch

diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 99a7ed7e9f09..1029c2503aef 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -108,7 +108,7 @@  CFLAGS_ABI	+= -meabi gnu
 endif
 
 ifeq ($(CONFIG_CURRENT_POINTER_IN_TPIDRURO),y)
-CFLAGS_ABI	+= -mtp=cp15
+KBUILD_CFLAGS	+= -mtp=cp15
 endif
 
 # Accept old syntax despite ".syntax unified"