| Message ID | 20220519071610.423372-3-wenst@chromium.org (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | clk: mediatek: Move to struct clk_hw provider APIs | expand |
Quoting Chen-Yu Tsai (2022-05-19 00:16:07) > mtk_clk_register_ref2usb_tx() prints an error message if clk_register() > fails. It doesn't if kzalloc() fails though. The caller would then tack > on its own error message to handle this. > > Also, All other clk registration functions in the MediaTek clk library > leave the error message printing to the bulk registration functions, > while the helpers that register individual clks just return error codes. > > Drop the error message that is printed when clk_register() fails in > mtk_clk_register_ref2usb_tx() to make its behavior consistent both > across its failure modes, and with the rest of the driver library. > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > Reviewed-by: Miles Chen <miles.chen@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Tested-by: Miles Chen <miles.chen@mediatek.com> > --- Applied to clk-next
diff --git a/drivers/clk/mediatek/clk-apmixed.c b/drivers/clk/mediatek/clk-apmixed.c index a29339cc26c4..06400c043fe7 100644 --- a/drivers/clk/mediatek/clk-apmixed.c +++ b/drivers/clk/mediatek/clk-apmixed.c @@ -91,10 +91,8 @@ struct clk * __init mtk_clk_register_ref2usb_tx(const char *name, clk = clk_register(NULL, &tx->hw); - if (IS_ERR(clk)) { - pr_err("Failed to register clk %s: %pe\n", name, clk); + if (IS_ERR(clk)) kfree(tx); - } return clk; }