diff mbox series

dt-bindings: net: Fix unevaluatedProperties warnings in examples

Message ID 20220526014149.2872762-1-robh@kernel.org (mailing list archive)
State New, archived
Headers show
Series dt-bindings: net: Fix unevaluatedProperties warnings in examples | expand

Commit Message

Rob Herring May 26, 2022, 1:41 a.m. UTC
The 'unevaluatedProperties' schema checks is not fully working and doesn't
catch some cases where there's a $ref to another schema. A fix is pending,
but results in new warnings in examples. Fix the warnings by removing
spurious properties or adding missing properties to the schema.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/net/cdns,macb.yaml           | 1 -
 Documentation/devicetree/bindings/net/mediatek,net.yaml        | 3 +++
 Documentation/devicetree/bindings/net/mediatek-dwmac.yaml      | 3 +++
 .../devicetree/bindings/net/wireless/mediatek,mt76.yaml        | 2 +-
 4 files changed, 7 insertions(+), 2 deletions(-)

Comments

Nicolas Ferre May 30, 2022, 9:03 a.m. UTC | #1
On 26/05/2022 at 03:41, Rob Herring wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples. Fix the warnings by removing
> spurious properties or adding missing properties to the schema.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>   Documentation/devicetree/bindings/net/cdns,macb.yaml           | 1 -
>   Documentation/devicetree/bindings/net/mediatek,net.yaml        | 3 +++
>   Documentation/devicetree/bindings/net/mediatek-dwmac.yaml      | 3 +++
>   .../devicetree/bindings/net/wireless/mediatek,mt76.yaml        | 2 +-
>   4 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index 337cec4d85ca..86fc31c2d91b 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -191,7 +191,6 @@ examples:
>                       clock-names = "pclk", "hclk", "tx_clk", "rx_clk", "tsu_clk";
>                       #address-cells = <1>;
>                       #size-cells = <0>;
> -                    #stream-id-cells = <1>;
>                       iommus = <&smmu 0x875>;
>                       power-domains = <&zynqmp_firmware PD_ETH_1>;
>                       resets = <&zynqmp_reset ZYNQMP_RESET_GEM1>;

For cdns,macb.yaml:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks Rob. Best regards,
   Nicolas

> diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> index 699164dd1295..f5564ecddb62 100644
> --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
> +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> @@ -27,6 +27,9 @@ properties:
>     reg:
>       maxItems: 1
> 
> +  clocks: true
> +  clock-names: true
> +
>     interrupts:
>       minItems: 3
>       maxItems: 4
> diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> index 901944683322..61b2fb9e141b 100644
> --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> @@ -58,6 +58,9 @@ properties:
>         - const: rmii_internal
>         - const: mac_cg
> 
> +  power-domains:
> +    maxItems: 1
> +
>     mediatek,pericfg:
>       $ref: /schemas/types.yaml#/definitions/phandle
>       description:
> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> index 249967d8d750..5a12dc32288a 100644
> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> @@ -51,7 +51,7 @@ properties:
>       description:
>         Specify the consys reset for mt7986.
> 
> -  reset-name:
> +  reset-names:
>       const: consys
> 
>     mediatek,infracfg:
> --
> 2.34.1
>
Rob Herring May 31, 2022, 3:20 p.m. UTC | #2
On Wed, May 25, 2022 at 08:41:48PM -0500, Rob Herring wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples. Fix the warnings by removing
> spurious properties or adding missing properties to the schema.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/net/cdns,macb.yaml           | 1 -
>  Documentation/devicetree/bindings/net/mediatek,net.yaml        | 3 +++
>  Documentation/devicetree/bindings/net/mediatek-dwmac.yaml      | 3 +++
>  .../devicetree/bindings/net/wireless/mediatek,mt76.yaml        | 2 +-
>  4 files changed, 7 insertions(+), 2 deletions(-)

Applied, thanks.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
index 337cec4d85ca..86fc31c2d91b 100644
--- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
+++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
@@ -191,7 +191,6 @@  examples:
                     clock-names = "pclk", "hclk", "tx_clk", "rx_clk", "tsu_clk";
                     #address-cells = <1>;
                     #size-cells = <0>;
-                    #stream-id-cells = <1>;
                     iommus = <&smmu 0x875>;
                     power-domains = <&zynqmp_firmware PD_ETH_1>;
                     resets = <&zynqmp_reset ZYNQMP_RESET_GEM1>;
diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
index 699164dd1295..f5564ecddb62 100644
--- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
@@ -27,6 +27,9 @@  properties:
   reg:
     maxItems: 1
 
+  clocks: true
+  clock-names: true
+
   interrupts:
     minItems: 3
     maxItems: 4
diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
index 901944683322..61b2fb9e141b 100644
--- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
@@ -58,6 +58,9 @@  properties:
       - const: rmii_internal
       - const: mac_cg
 
+  power-domains:
+    maxItems: 1
+
   mediatek,pericfg:
     $ref: /schemas/types.yaml#/definitions/phandle
     description:
diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index 249967d8d750..5a12dc32288a 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -51,7 +51,7 @@  properties:
     description:
       Specify the consys reset for mt7986.
 
-  reset-name:
+  reset-names:
     const: consys
 
   mediatek,infracfg: