| Message ID | 20220526075325.27356-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: bcm: brcmstb: pm: pm-arm: Fix refcount leak in brcmstb_pm_probe | expand |
On Thu, May 26, 2022 at 11:53:22AM +0400, Miaoqian Lin wrote: > of_find_matching_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > In brcmstb_init_sram, it pass dn to of_address_to_resource(), > of_address_to_resource() will call of_find_device_by_node() to take > reference, so we should release the reference returned by > of_find_matching_node(). Looks legit, Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Fixes: 0b741b8234c8 ("soc: bcm: brcmstb: Add support for S2/S3/S5 suspend states (ARM)") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > --- > drivers/soc/bcm/brcmstb/pm/pm-arm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/bcm/brcmstb/pm/pm-arm.c b/drivers/soc/bcm/brcmstb/pm/pm-arm.c > index 3cbb165d6e30..70ad0f3dce28 100644 > --- a/drivers/soc/bcm/brcmstb/pm/pm-arm.c > +++ b/drivers/soc/bcm/brcmstb/pm/pm-arm.c > @@ -783,6 +783,7 @@ static int brcmstb_pm_probe(struct platform_device *pdev) > } > > ret = brcmstb_init_sram(dn); > + of_node_put(dn); > if (ret) { > pr_err("error setting up SRAM for PM\n"); > return ret; > -- > 2.25.1 >
On Thu, 26 May 2022 11:53:22 +0400, Miaoqian Lin <linmq006@gmail.com> wrote: > of_find_matching_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > In brcmstb_init_sram, it pass dn to of_address_to_resource(), > of_address_to_resource() will call of_find_device_by_node() to take > reference, so we should release the reference returned by > of_find_matching_node(). > > Fixes: 0b741b8234c8 ("soc: bcm: brcmstb: Add support for S2/S3/S5 suspend states (ARM)") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > --- Applied to https://github.com/Broadcom/stblinux/commits/drivers/fixes, thanks! -- Florian
diff --git a/drivers/soc/bcm/brcmstb/pm/pm-arm.c b/drivers/soc/bcm/brcmstb/pm/pm-arm.c index 3cbb165d6e30..70ad0f3dce28 100644 --- a/drivers/soc/bcm/brcmstb/pm/pm-arm.c +++ b/drivers/soc/bcm/brcmstb/pm/pm-arm.c @@ -783,6 +783,7 @@ static int brcmstb_pm_probe(struct platform_device *pdev) } ret = brcmstb_init_sram(dn); + of_node_put(dn); if (ret) { pr_err("error setting up SRAM for PM\n"); return ret;
of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. In brcmstb_init_sram, it pass dn to of_address_to_resource(), of_address_to_resource() will call of_find_device_by_node() to take reference, so we should release the reference returned by of_find_matching_node(). Fixes: 0b741b8234c8 ("soc: bcm: brcmstb: Add support for S2/S3/S5 suspend states (ARM)") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/soc/bcm/brcmstb/pm/pm-arm.c | 1 + 1 file changed, 1 insertion(+)