From patchwork Thu May 26 08:13:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12862069 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E9ECC433EF for ; Thu, 26 May 2022 08:15:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=5ihmJy4FZ/BRATWExfT8gZ9WrXxQ4c8T2bpj0RbAcxM=; b=wZNKl83HFnU13T fFpOx2YQdkMPM6YNagKf9wzzvQ0vio1q7538FaETDEaAMM3qS6wdwL5KvpflwJjP2BGAfTY8BxJzr /8WZiudivorlJ0PtEPG4utYt6uvWwDrFddMWaFl6Mvtl963aSRoj9SGONQQJHR4nzkeQmf6rIvEj6 4ivZyrueWw88NDUfT8eSOsx9s8qZEagTVuSzQopkICLpnVXoGev+yGQQYzRaaQK7Bf7jXhhcuk1o5 ttMQ5sP56uGHgWHIRbRCR8TQAjHDtJU269060KVHTl1ix5bIry7OOf/KbfSTtsTV0NVC71Nxbjh8d WoZuNRFAHdZ2Mvo9O/ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nu8d0-00DzLw-Rc; Thu, 26 May 2022 08:13:55 +0000 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nu8cx-00DzJi-5E for linux-arm-kernel@lists.infradead.org; Thu, 26 May 2022 08:13:52 +0000 Received: by mail-pj1-x102e.google.com with SMTP id x2-20020a17090a1f8200b001e07a64c461so3772753pja.4 for ; Thu, 26 May 2022 01:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sBEKGmkjoE28MCTQbjd5ORFpa77bz/agL9nSVVFspD0=; b=U02aOGk0NHNgLEItlnR/QPW5AvWVU5/iXwA8+xraVYrHhGXGs4D8A9oemFul3CRDFm Gt2101IPsae1+c3fOcEO7oelNwh0RBOar/s8RgV5r/ObBLNGuQPlAqfPsR/s9iRQzP4z WnQfvK3RGHPcxf2SgCQSHORkoo+TIjKSqyZN5Mho/H7WU2D4Rln8imTv5CF0rK/rPwZZ lQxmSkh8REdO1WXzm/032CE8YqTVrI/vXRldYWBrGbnVh2V4l2FiyIPhnDTAe95lfLIO JVtluiWrCItcVn+GTC99TAQPh3839qq5fxie3xX4EiJ15cHjgQBHzVPWjg+nl8WukVh8 qo+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sBEKGmkjoE28MCTQbjd5ORFpa77bz/agL9nSVVFspD0=; b=dQE9fLtMlWJZI8i0m4u/vPb6DJaG8vlGB5cRYfx8yrostxJt989uTaKVMFFE1wbPRz FQsi2y6cVSUnnljCZQP5GxZGbl2wctjWINc2v5AmGG6fxnUqinwtIN4aStyeDWqEKgG7 pnrzR61xXSYFpiv89zZeFJoQtxctQEdP1A125Rwspmz1dfpn4RwZGhIcMI7CbjDc0uge MbQTIkmH6z80CqJKuDPDY4rZ6IpHupYfSVg/bu5Fc50OZMqRMoraXPCc9L0EjAaPuEcB cZDfhqs7s4N+ppGN2KKWkOPcqryNfqeEb3NjcjHDUDktlDXb8PgP4pDy2bvhPqQqlKsh R2tA== X-Gm-Message-State: AOAM532BrwyQPDUp2QdEUlCy7Yi4qUaeKh0Q8ZK4qBNUgKe1msblDmQR 8RlAtTMXqDC+/iZaOfFXV9w= X-Google-Smtp-Source: ABdhPJwmyYXrCMYA89cDjci7YDwwnifRlFdnDsevNvEB4OhCP+IR2OqScWdmufnVH87NwZY/G/KuIA== X-Received: by 2002:a17:90a:de15:b0:1df:63dd:9cfc with SMTP id m21-20020a17090ade1500b001df63dd9cfcmr1394721pjv.200.1653552826328; Thu, 26 May 2022 01:13:46 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id bg16-20020a056a02011000b003c62fa02f08sm904246pgb.43.2022.05.26.01.13.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 01:13:45 -0700 (PDT) From: Miaoqian Lin To: Russell King , Florian Fainelli , Ray Jui , Scott Branden , Broadcom Kernel Team , Christian Daudt , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] ARM: bcm: Fix refcount leak in bcm_kona_smc_init Date: Thu, 26 May 2022 12:13:25 +0400 Message-Id: <20220526081325.30954-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220526_011351_234504_2D965EF6 X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: b8eb35fd594a ("ARM: bcm281xx: Add L2 cache enable code") Signed-off-by: Miaoqian Lin --- arch/arm/mach-bcm/bcm_kona_smc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-bcm/bcm_kona_smc.c b/arch/arm/mach-bcm/bcm_kona_smc.c index 43829e49ad93..347bfb7f03e2 100644 --- a/arch/arm/mach-bcm/bcm_kona_smc.c +++ b/arch/arm/mach-bcm/bcm_kona_smc.c @@ -52,6 +52,7 @@ int __init bcm_kona_smc_init(void) return -ENODEV; prop_val = of_get_address(node, 0, &prop_size, NULL); + of_node_put(node); if (!prop_val) return -EINVAL;