| Message ID | 20220526081756.32998-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: integrator: Fix refcount leak in intcp_init_of | expand |
On Thu, May 26, 2022 at 10:18 AM Miaoqian Lin <linmq006@gmail.com> wrote: > of_find_matching_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: df36680f1a71 ("ARM: integrator: core module registers from compatible strings") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Patch applied manually (target file moved in the tree) Yours, Linus Walleij
diff --git a/arch/arm/mach-integrator/integrator_cp.c b/arch/arm/mach-integrator/integrator_cp.c index b7eb4038798b..bb301ca8c7e1 100644 --- a/arch/arm/mach-integrator/integrator_cp.c +++ b/arch/arm/mach-integrator/integrator_cp.c @@ -126,6 +126,7 @@ static void __init intcp_init_of(void) return; intcp_con_base = of_iomap(cpcon, 0); + of_node_put(cpcon); if (!intcp_con_base) return;
of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: df36680f1a71 ("ARM: integrator: core module registers from compatible strings") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- arch/arm/mach-integrator/integrator_cp.c | 1 + 1 file changed, 1 insertion(+)