From patchwork Fri May 27 10:24:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ming Qian X-Patchwork-Id: 12863221 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0625C433F5 for ; Fri, 27 May 2022 10:26:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=/GJpguTQg+vjcyv8fTBioAKPDeidwxj4eI1SxU7ejMU=; b=uPCAooDCBLu0t0 MoULdIoie1rTLYKWHdMfhCkMb3mLb9ZqVIBhV5qjhJdR54fB/9ZXUSmM2hEjXlXSRsYR7+Mam4Lkr 0yt1uxXqtWMw2PJkEFeVA3BgIVd5aZ/DpG/FtfqwsfEGatH+WDHGwpyh1to+RhsBn0yy1bUmcrOzE /aaKZbkBXgCct8ZZ1qEzb+DouR1BLIg8nHmMFZa4yx8ZwHcmXsq1m5iGkZG/hhTzg+C6E4sHUXp5I ZFY7JROJT5EiZO9Ciz4EhKXNL7N87zUfYQ2GMwihHhftQsbOoQ+m0GSc+tSdVFwGNpPyy5yhqc7d6 VbwlfvOYC07yW8eDwB2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuX9a-00HKVi-RQ; Fri, 27 May 2022 10:25:11 +0000 Received: from mail-am6eur05on20624.outbound.protection.outlook.com ([2a01:111:f400:7e1b::624] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuX9X-00HKUC-C8 for linux-arm-kernel@lists.infradead.org; Fri, 27 May 2022 10:25:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VMX4sCEBcxpJNVhcjJweBV1fhZGRn5HJVQVl9bhWLt7bqphaiYaQ/BKZHcIIX6ONcQDrSgIrzw1NyQ+DgyUKwKcRjwn8JjAS/FqPZXfHGB/MHNaRa3N34jRyJytNMitC6iQPxb7rlpVFbQAZkQBBK7506jLX0fqRRvdGjzJmmVpIG9G0cS+P43vUG9bPN55E7FSA9OINSSuVWUs3KOADlgyREVPcA7KEMMJDovW0V7yuYpUTx5J3wpLkzooGgB9O+mVTOcMNxNG8DMOYbnpnkHJtAZWPj/bnfl0vWM3CvVZwRNJ+3Ib8Gg2PosOzhEwSrJYOPMRopt2PDkaXaILqyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KoCzVMO2TSbL/kzMGVx0A/9AHGeZIpTfvLyq7cJkP3o=; b=oPBXyMkm2nP2xxXFEVNezBa+GWO1eAGPt3HkZp8HmX8SuI7oFMWgBr82iMypnubKDn9Wn8CmBgBWes3JrmEAXwhF9sFJCP+yyQkXc7vk8jk75UMB+M8nWno7xt3G1ozECs8yMRiNmA1uGQcX4QuM88hjUp2ZUtuggFs9qHQ6yryBQ+ka4KhrwP04ApA3x+WWPfFg066DExmGtbBOS4DZKmoNCayFL11mbPghjD20oD31cxHchjY5dYm33CgSOcyUEmXCKDLAdMOpLap+tVkwlP71IG4HokD1G9fRfrTuIN1yrY2i2zS964Qyu7VLCR8170GNsdDoAcili9moyyrmyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KoCzVMO2TSbL/kzMGVx0A/9AHGeZIpTfvLyq7cJkP3o=; b=AhPuv42TGGBMZA2j/asaoYJ2e5mpCP8hGyzDKCTS9x7K76UIPjbGyWpQAPO3Sw9l4P5kXRR7pX82XOASUxXgKh9TIdwU7nNsULLGJ2gwLKLyt8JwjBsAswcaAUP2xZhcO3GKHsU2GbRGeMtkI/6aa/7ZHkufL4sO5olbskWAq+0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB6341.eurprd04.prod.outlook.com (2603:10a6:20b:d8::14) by DU2PR04MB8597.eurprd04.prod.outlook.com (2603:10a6:10:2d8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 10:25:03 +0000 Received: from AM6PR04MB6341.eurprd04.prod.outlook.com ([fe80::bc48:7565:c619:62c3]) by AM6PR04MB6341.eurprd04.prod.outlook.com ([fe80::bc48:7565:c619:62c3%7]) with mapi id 15.20.5293.015; Fri, 27 May 2022 10:25:03 +0000 From: Ming Qian To: mchehab@kernel.org, mirela.rabulea@oss.nxp.com, hverkuil-cisco@xs4all.nl Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] media: imx-jpeg: Leave a blank space before the configuration data Date: Fri, 27 May 2022 18:24:44 +0800 Message-Id: <20220527102444.19683-1-ming.qian@nxp.com> X-Mailer: git-send-email 2.36.1 X-ClientProxiedBy: SI2P153CA0018.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::9) To AM6PR04MB6341.eurprd04.prod.outlook.com (2603:10a6:20b:d8::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c35468c-9025-4974-b6ce-08da3fcb2960 X-MS-TrafficTypeDiagnostic: DU2PR04MB8597:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5lQEfClQWETEwxwYM7t8+uDNX4wum4y3ok00Ow1UrdZVtzFq4FvtsKxNu0b/9R77hAb2OJCWndcYTqAglTh3/vJLDJZytZqyPsR5nX61rpH8t9jR/Tru+fo8v++Xv+Nn7+Ckv/KqlGjI6RiA0bkNmDFMwvhRO0RToeJWVjPPdRm0GFI/iBJr+/2tzJZ7WEZKDhJJtlZULn2Ui/m9WmodeURxnA4MIqEcNMJ2jO0nis+kXcGg0XR/K7OKVMuV2SfFdqkEX4/sfewUQxy6t+oqSPA5tpBRrvi5iHpxEtuyNP9hJhRx1DwcM/QFn67Cd5AVchRnlEdcEZeYXdg6l8bSWQY6NPseG3pRqcF6giDBQxcSMjU2HCezQS/lBZ0FmTVADbTxRj9Y6avcUNSBYmQqjJfe3TznnSM7ujP4/weBoBHbesOasvrYi9wDAFv1rj9edFGMLJimYXvtyJm95jbr9+efLTFUwzAXCry74cp2g6Ss434U7la7yY/Llu/UyT1zJLjImgbgbkj1yfrprUA73sCNIGXuRFACISP3VUweq7wuaKqdUdM4wf1mzmmYZNjCpChJaSxYpUFdCWArJujhmposKogPY9wkSayeVbBvYynawiBeWeFAoE+GSOvZdPKooiAxbBWWr8fez2MmFMcdyMFy13gwezFs8KeA8gR8DA6Ys1uea0OqzSYZBsa8PC6vMLLqU9t9XrogieWjHSLsVg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6341.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(2616005)(6666004)(52116002)(26005)(6506007)(316002)(66556008)(66946007)(508600001)(8676002)(4326008)(66476007)(38350700002)(6486002)(86362001)(38100700002)(1076003)(186003)(83380400001)(5660300002)(7416002)(2906002)(44832011)(8936002)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ViC5bTyi3HYrFhbLbf9xFMq6S9erzWXVBnHCdbwtnWa+s7VSvEaVvkZhyyiqGn6HNxb5ZOW+e7QuIqp5H2yQpND3LUau0lPuq83wMxHaVymTUmT75uxYuVzQmlWvL8k3C+41O0fJtegvgq3oVi5TrpXTJeT+5dAtsreNMXB38UKa7t7nqJVtl7wY8wLrsvLnKGqfW9ecnJljoroPssOuUIyxFD+cPbVtHWxksbWLRJNguO9steZAqkyAdZyrzqO3MCNalcYRBR70gbB+CFqajUqLTzE6RjeCyUPjOfKFcqijbMrFvTbGw27VOgqmTcZu9SRrjJgKZ1TfpQGIBX5j2yCr2PeACvdtoEnhy81l8mBZRhu/Hn3Kiub79VgL7WXavQEhCuDW7KQEMzkTNzK9va9VOXuBKvm4UuICtx6dQaNEzyT0cfY5+axbMriaJouAKjqmV79qG+DXWt07zxb0n8DZbuNdZGNKucf35S2qotP95FfU2OBNBJ/mPZdITVGUWVXcP/C0eHl7qEUMy2kpUa9SzY2GC+L6cxE15UB8bnTYjFL/rAgnz5UGOYGhAVjBRALpa7mk8fBI9Z3QUlIACHb3tONGbgfk8LCvGcqibHWZuQktPfHCaSLqerIGDAAxQwoxnlH/tws3lY7bKnyjUig16Wd4lvZg7qBOJBhsmhsp+aFz19gwZrwsCC3IyLyf5U9izg1Vz4bmgTgTaXBsyQMr/12ND/FJdslY34r42X+8KXQxas6/dP8uR2rBuhDbcEBMUXtnbkGEjVI9DQRYmEzMvNNN5oyu0m8MpKVQyQiIbrs+i4tSr+z9aYmTcQpYFlIL/dI2zn+xfKFirHNBrnJq5VBnM696qRB0hZNI3bffhHp4fdOsZA5w+8sgLuT6s0vglz8NJCH+XsWgEQq4bOF3L6fCq79r66Ws70HC+mXpo+y0KPlnpnoK8+GWOZ/VtbWKLE7mUHp69hEmJF450UzuqG+UewGXDCxUqRZ3h4BvxoN9hRy0S624gMnEJozNtLGbskfMrP3wZGBZAp8mxF1zb5hHWF9qVzyT0Dk0wDjzHsZoHWTnjQOrFAwbhTf2LPxZA4X86ChBBtRhzaOeN8O2TlAxzN58dCMuq9NT+zBvuYAD2zlQ0h4rVs/aMXmlXt2MhyLR555CT5ujb74sdx7y0jOQM5bIJrABmho0B6uoRpcN/FA4j/3qlKyj9GUtxfA2qBEF7HqrmjTiqGKUnBwkTGyjX5myMnRYv9FBA/qPYuLT+SaYeIRFLkPMbF2Z64rlffICVR/YgOIeV9MNiixTKcL3UbLFkwLPKRbXV5rLgnDrvozgLCRSKjxDOuzWyM8MI/huWIFCDthqEPp/Yw1f8zm3RDxfTUqA5vNUi8Fcf8TGyZ06TILsw8qVCl75AR/4zYIb975OQQaRrRjLVXE/baYwENnG0uPZKEsibdjak3BwdIUrXJo9tjLRsd8mNRxCUIjgnSEykEMCSm8yQYNe8EokNpZcW41xL4xn9Kf9XGulScAgI0mnmsoUgxQVJx79ywQLMb9mJrHVIHSW8hoGl/nDvrqw3USad+HFKvdrnNBkTB731DmctEV5nEF8QYujl/TbCl5U630Z3pFGRLu1fXXNlydp30DHAmJKsEuvtWfdrvkDerLevXoZTa4CsKoYhGVWGcOFw4DPHXhgG+MHFtcwS/J9VmYp7jNZiEVkfNW1/LmJp/WZVctr6lcy/E6en/IWlsIGgecmLkeSbQ== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c35468c-9025-4974-b6ce-08da3fcb2960 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 10:25:03.3180 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kuJTc1WDeOarT+i3zZtxRDKmQc69e92dKTIRB/hO/K9CRF8OFGIMIjFWEMZ8kMg8fGk3O1iNP8RXyXwO/VYOIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8597 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220527_032507_615347_0E80FB6D X-CRM114-Status: GOOD ( 13.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is a hardware bug that it will load the first 128 bytes of configuration data twice, it will led to some configure error. so shift the configuration data 128 bytes, and make the first 128 bytes all zero, then hardware will load the 128 zero twice, and ignore them as garbage. then the configuration data can be loaded correctly Signed-off-by: Ming Qian Reviewed-by: Mirela Rabulea Reviewed-by: Tommaso Merciai --- v2 - add some comments about why the 0x80 offset is needed drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c index 734e1b65fbc7..c0fd030d0f19 100644 --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c @@ -519,6 +519,7 @@ static bool mxc_jpeg_alloc_slot_data(struct mxc_jpeg_dev *jpeg, GFP_ATOMIC); if (!cfg_stm) goto err; + memset(cfg_stm, 0, MXC_JPEG_MAX_CFG_STREAM); jpeg->slot_data[slot].cfg_stream_vaddr = cfg_stm; skip_alloc: @@ -755,7 +756,13 @@ static unsigned int mxc_jpeg_setup_cfg_stream(void *cfg_stream_vaddr, u32 fourcc, u16 w, u16 h) { - unsigned int offset = 0; + /* + * There is a hardware issue that first 128 bytes of configuration data + * can't be loaded correctly. + * To avoid this issue, we need to write the configuration from + * an offset which should be no less than 0x80 (128 bytes). + */ + unsigned int offset = 0x80; u8 *cfg = (u8 *)cfg_stream_vaddr; struct mxc_jpeg_sof *sof; struct mxc_jpeg_sos *sos;