From patchwork Wed Jun 1 04:25:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12866346 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 118C1C433EF for ; Wed, 1 Jun 2022 04:27:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=oszndTY1NNTKn1Ou+QW+B/5yfEOQQ1/0F8IZA/MsNYw=; b=bAGlPWetIM+k3g xWCpvJA16X2JAFEW4XUAFLVss+z4Zqyg/XlFiwKS+/68MOWzwVBfsn1J3x0ddeSEjjF8N9tlb3nRB XKdiPTHNCvuj5UPzDzkEWvrlRvz1ofjbE8tdHo9u9NOApmZNeBsWPzQRuAi5PidPacTmUbOPy0Z8x ANKbRW4SMck2qeoS+GxHpjjggWt6/nbppHBivmL74n73uQxS02D5v9mlxB57N/vHdZUBig2yOtuSB uzpUyCt1gpH/uS6MAqgCSyGnGqI+YvPDZLBMuoyAY/wJMfh9ZVxsKETmeGpUVagBwE9+rgbPORmQa yQTMviyCWa+NmOYcDUJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwFvF-00Do3S-3i; Wed, 01 Jun 2022 04:25:29 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwFvB-00Do2W-Lk for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 04:25:27 +0000 Received: by mail-pl1-x629.google.com with SMTP id q18so626534pln.12 for ; Tue, 31 May 2022 21:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qV/kQWWE5TCXDtwtIihkerreiew7iWC6lBTWJeucJIg=; b=ReFoyD6+1Lqkr/R2pf+8AKWuf/SU8Gfa83eXY5S/LG50yi/hKWMyX/3OPwn6aJ1F59 ib9E9yb2Y+S9tgbMqi2DzZfsCNhEUZGbxD4oOkub/0tFfsfKT9wVkM86/SQIFsLo3BVz e5cJitqsmzcKoJtU0zDAoJXxB/Z2c3YRZcfczyZeN6rgZiFxc0z9YfjrHcMfrDOIzBxV u+rLPDPpIMOH6r2OBg5TTdGimLpRzbSuCskm47LvrMHkT2LLciV2MPVfHVIrOC8nH7HR MEYS9/U+HJ6ikAALq2hyIwzab4ExehXGsmHSgM3JQxIvPbHiKj0rK4M0VnW+6Qi4/aq1 vRWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qV/kQWWE5TCXDtwtIihkerreiew7iWC6lBTWJeucJIg=; b=Qj+CCKb0TkhKCBeWjoX1IknMz/CiiafxaaM/fBKMWnh3AE/XxMsOQ1gQQO2+lNWdvr dC4HuxCQn5ysCX3ITuAn2MOvimWsIbYN+3ggCpWpEvaXXv8laxdhCsO2pbqLb7yRV5Hh u30h5BZ0sIZ8bHMLIz0uJ0TUhLz0ga90aJFItrYspgBf5UB7kgrURBcetdlZj2ltnhJm UeeQzlVcTp4oYB9KaoRKUj29cDcoZ1yHlqBdFyoz72n8q/nH5XF2WRZceTwidBWVUZI8 0bcCnnWLvs3WxoYx+Zwqei3rGG+a14UYbLDJhT6RcEqsOy+JlOoXzgtiwP3zhQW/epCw jVzg== X-Gm-Message-State: AOAM530aazNrx9bdh0qb0FjHTf4/3hMN0UYxrrbjAXJva5a9D2B+tSIg LuJOd0rQpXwh6ofkOAjZ2NQ= X-Google-Smtp-Source: ABdhPJzhh0v5mf83CiChYoplV/aivC7HiUkv4hOQhbwi4NqjR/XvCvK6+eyWrEazVoETOiYVO01X8A== X-Received: by 2002:a17:902:e54e:b0:162:4b8b:f2be with SMTP id n14-20020a170902e54e00b001624b8bf2bemr38630727plf.5.1654057524096; Tue, 31 May 2022 21:25:24 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id fz21-20020a17090b025500b001df51e34036sm337111pjb.0.2022.05.31.21.25.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 May 2022 21:25:23 -0700 (PDT) From: Miaoqian Lin To: Hyun Kwon , Laurent Pinchart , Mauro Carvalho Chehab , Michal Simek , Radhey Shyam Pandey , Hans Verkuil , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] v4l: xilinx-vipp: Fix refcount leak in xvip_graph_dma_init Date: Wed, 1 Jun 2022 08:25:14 +0400 Message-Id: <20220601042514.61780-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220531_212525_771747_A4574ABA X-CRM114-Status: GOOD ( 12.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: df3305156f98 ("[media] v4l: xilinx: Add Xilinx Video IP core") Signed-off-by: Miaoqian Lin Reviewed-by: Laurent Pinchart --- drivers/media/platform/xilinx/xilinx-vipp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c index f34f8b077e03..415579b63737 100644 --- a/drivers/media/platform/xilinx/xilinx-vipp.c +++ b/drivers/media/platform/xilinx/xilinx-vipp.c @@ -483,10 +483,12 @@ static int xvip_graph_dma_init(struct xvip_composite_device *xdev) ret = xvip_graph_dma_init_one(xdev, port); if (ret < 0) { of_node_put(port); + of_node_put(ports); return ret; } } + of_node_put(ports); return 0; }