| Message ID | 20220601110249.569540-4-pbrobinson@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Raspberry PI 4 V3D enablement | expand |
[add Melissa] Am 01.06.22 um 13:02 schrieb Peter Robinson: > Add compatible string and Kconfig options for bcm2711. > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> Reviewed-by: Stefan Wahren <stefan.wahren@i2se.com> > --- > Changes since v5: > - Change compatible to align downstream and othee HW, reorder to suit > > drivers/gpu/drm/v3d/Kconfig | 2 +- > drivers/gpu/drm/v3d/v3d_drv.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/v3d/Kconfig b/drivers/gpu/drm/v3d/Kconfig > index e973ec487484..01d91c829107 100644 > --- a/drivers/gpu/drm/v3d/Kconfig > +++ b/drivers/gpu/drm/v3d/Kconfig > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0-only > config DRM_V3D > tristate "Broadcom V3D 3.x and newer" > - depends on ARCH_BCM || ARCH_BRCMSTB || COMPILE_TEST > + depends on ARCH_BCM || ARCH_BRCMSTB || ARCH_BCM2835 || COMPILE_TEST > depends on DRM > depends on COMMON_CLK > depends on MMU > diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c > index 56d5f831e48b..8c7f910daa28 100644 > --- a/drivers/gpu/drm/v3d/v3d_drv.c > +++ b/drivers/gpu/drm/v3d/v3d_drv.c > @@ -191,6 +191,7 @@ static const struct drm_driver v3d_drm_driver = { > }; > > static const struct of_device_id v3d_of_match[] = { > + { .compatible = "brcm,2711-v3d" }, > { .compatible = "brcm,7268-v3d" }, > { .compatible = "brcm,7278-v3d" }, > {},
On 6/1/22 13:02, Peter Robinson wrote: > Add compatible string and Kconfig options for bcm2711. > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > --- Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> I've one small nit though. [snip] > # SPDX-License-Identifier: GPL-2.0-only > config DRM_V3D > tristate "Broadcom V3D 3.x and newer" > - depends on ARCH_BCM || ARCH_BRCMSTB || COMPILE_TEST > + depends on ARCH_BCM || ARCH_BRCMSTB || ARCH_BCM2835 || COMPILE_TEST The help text for this Kconfig symbol currently says: help Choose this option if you have a system that has a Broadcom V3D 3.x or newer GPU, such as BCM7268. Maybe you can add "... as BCM7268 or BCM2711." ?
diff --git a/drivers/gpu/drm/v3d/Kconfig b/drivers/gpu/drm/v3d/Kconfig index e973ec487484..01d91c829107 100644 --- a/drivers/gpu/drm/v3d/Kconfig +++ b/drivers/gpu/drm/v3d/Kconfig @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config DRM_V3D tristate "Broadcom V3D 3.x and newer" - depends on ARCH_BCM || ARCH_BRCMSTB || COMPILE_TEST + depends on ARCH_BCM || ARCH_BRCMSTB || ARCH_BCM2835 || COMPILE_TEST depends on DRM depends on COMMON_CLK depends on MMU diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c index 56d5f831e48b..8c7f910daa28 100644 --- a/drivers/gpu/drm/v3d/v3d_drv.c +++ b/drivers/gpu/drm/v3d/v3d_drv.c @@ -191,6 +191,7 @@ static const struct drm_driver v3d_drm_driver = { }; static const struct of_device_id v3d_of_match[] = { + { .compatible = "brcm,2711-v3d" }, { .compatible = "brcm,7268-v3d" }, { .compatible = "brcm,7278-v3d" }, {},