diff mbox series

usb: gadget: lpc32xx_udc: Fix refcount leak in lpc32xx_udc_probe

Message ID 20220603140246.64529-1-linmq006@gmail.com (mailing list archive)
State New, archived
Headers show
Series usb: gadget: lpc32xx_udc: Fix refcount leak in lpc32xx_udc_probe | expand

Commit Message

Miaoqian Lin June 3, 2022, 2:02 p.m. UTC 
of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
of_node_put() will check NULL pointer.

Fixes: 24a28e428351 ("USB: gadget driver for LPC32xx")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 drivers/usb/gadget/udc/lpc32xx_udc.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c
index 6117ae8e7242..cea10cdb83ae 100644
--- a/drivers/usb/gadget/udc/lpc32xx_udc.c
+++ b/drivers/usb/gadget/udc/lpc32xx_udc.c
@@ -3016,6 +3016,7 @@  static int lpc32xx_udc_probe(struct platform_device *pdev)
 	}
 
 	udc->isp1301_i2c_client = isp1301_get_client(isp1301_node);
+	of_node_put(isp1301_node);
 	if (!udc->isp1301_i2c_client) {
 		return -EPROBE_DEFER;
 	}