diff mbox series

[4/7] ARM: dts: imx6ul: remove unsupported adc property

Message ID 20220613123357.441779-4-alexander.stein@ew.tq-group.com (mailing list archive)
State New, archived
Headers show
Series [1/7] ARM: dts: imx6ul: add missing properties for sram | expand

Commit Message

Alexander Stein June 13, 2022, 12:33 p.m. UTC
'num-channels' is not supported by binding, nor driver, remove it. Fixes
the dt_binding_check warning:
adc@2198000: 'num-channels' does not match any of the regexes:
'pinctrl-[0-9]+'

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm/boot/dts/imx6ul.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Baruch Siach June 13, 2022, 12:44 p.m. UTC | #1
Hi Alexander,

On Mon, Jun 13 2022, Alexander Stein wrote:
> 'num-channels' is not supported by binding, nor driver, remove it. Fixes
> the dt_binding_check warning:
> adc@2198000: 'num-channels' does not match any of the regexes:
> 'pinctrl-[0-9]+'
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Shawn's imx/dt branch has commit 71b81f1cac29297 that removes
num-channels from all imx6ul DT files:

  https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/commit/?h=imx/dt&id=71b81f1cac29297769ec81fe29a3fcc40bc2c31c

baruch

> ---
>  arch/arm/boot/dts/imx6ul.dtsi | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index df8b4ad62418..b951bdb793d2 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -924,7 +924,6 @@ adc1: adc@2198000 {
>  				reg = <0x02198000 0x4000>;
>  				interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clks IMX6UL_CLK_ADC1>;
> -				num-channels = <2>;
>  				clock-names = "adc";
>  				fsl,adck-max-frequency = <30000000>, <40000000>,
>  							 <20000000>;
Alexander Stein June 13, 2022, 1:01 p.m. UTC | #2
Hi Baruch,

Am Montag, 13. Juni 2022, 14:44:09 CEST schrieb Baruch Siach:
> Hi Alexander,
> 
> On Mon, Jun 13 2022, Alexander Stein wrote:
> > 'num-channels' is not supported by binding, nor driver, remove it. Fixes
> > the dt_binding_check warning:
> > adc@2198000: 'num-channels' does not match any of the regexes:
> > 'pinctrl-[0-9]+'
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> Shawn's imx/dt branch has commit 71b81f1cac29297 that removes
> num-channels from all imx6ul DT files:
> 
>  
> https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/commit/?
> h=imx/dt&id=71b81f1cac29297769ec81fe29a3fcc40bc2c31c

Ah, it's not in next-20220610, so I wasn't aware of it. Thanks for the hint 
though.

Best regards,
Alexander

> > ---
> > 
> >  arch/arm/boot/dts/imx6ul.dtsi | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> > index df8b4ad62418..b951bdb793d2 100644
> > --- a/arch/arm/boot/dts/imx6ul.dtsi
> > +++ b/arch/arm/boot/dts/imx6ul.dtsi
> > @@ -924,7 +924,6 @@ adc1: adc@2198000 {
> > 
> >  				reg = <0x02198000 0x4000>;
> >  				interrupts = <GIC_SPI 100 
IRQ_TYPE_LEVEL_HIGH>;
> >  				clocks = <&clks IMX6UL_CLK_ADC1>;
> > 
> > -				num-channels = <2>;
> > 
> >  				clock-names = "adc";
> >  				fsl,adck-max-frequency = 
<30000000>, <40000000>,
> >  				
> >  							 
<20000000>;
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
index df8b4ad62418..b951bdb793d2 100644
--- a/arch/arm/boot/dts/imx6ul.dtsi
+++ b/arch/arm/boot/dts/imx6ul.dtsi
@@ -924,7 +924,6 @@  adc1: adc@2198000 {
 				reg = <0x02198000 0x4000>;
 				interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clks IMX6UL_CLK_ADC1>;
-				num-channels = <2>;
 				clock-names = "adc";
 				fsl,adck-max-frequency = <30000000>, <40000000>,
 							 <20000000>;