| Message ID | 20220616054203.11365-6-yong.wu@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iommu/mediatek: Improve safety from dts | expand |
Il 16/06/22 07:42, Yong Wu ha scritto: > Just remove a unused variable that only is for mtk_iommu_v1. > > Fixes: 9485a04a5bb9 ("iommu/mediatek: Separate mtk_iommu_data for v1 and v2") > Signed-off-by: Yong Wu <yong.wu@mediatek.com> The title isn't immediately clear, looks like you're removing some mapping, not a struct member... Perhaps... iommu/mediatek: Remove unused "mapping" member from mtk_iommu_data ? After clarifying the commit title: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cheers, Angelo
On 16/06/2022 07:42, Yong Wu wrote: > Just remove a unused variable that only is for mtk_iommu_v1. > > Fixes: 9485a04a5bb9 ("iommu/mediatek: Separate mtk_iommu_data for v1 and v2") It does not fix a bug, so no fixes tag here needed. With that: Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > --- > drivers/iommu/mtk_iommu.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 5e86fd48928a..e65e705d9fc1 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -221,10 +221,7 @@ struct mtk_iommu_data { > struct device *smicomm_dev; > > struct mtk_iommu_bank_data *bank; > - > - struct dma_iommu_mapping *mapping; /* For mtk_iommu_v1.c */ > struct regmap *pericfg; > - > struct mutex mutex; /* Protect m4u_group/m4u_dom above */ > > /*
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index 5e86fd48928a..e65e705d9fc1 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -221,10 +221,7 @@ struct mtk_iommu_data { struct device *smicomm_dev; struct mtk_iommu_bank_data *bank; - - struct dma_iommu_mapping *mapping; /* For mtk_iommu_v1.c */ struct regmap *pericfg; - struct mutex mutex; /* Protect m4u_group/m4u_dom above */ /*
Just remove a unused variable that only is for mtk_iommu_v1. Fixes: 9485a04a5bb9 ("iommu/mediatek: Separate mtk_iommu_data for v1 and v2") Signed-off-by: Yong Wu <yong.wu@mediatek.com> --- drivers/iommu/mtk_iommu.c | 3 --- 1 file changed, 3 deletions(-)