From patchwork Tue Jun 21 19:20:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 12889638 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19DCEC43334 for ; Tue, 21 Jun 2022 19:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CeU44eTR950MtcGZjWe0gEfmR0FHjtHPwsC7EwWtoPc=; b=rQC3JM3sJhuBxc OC1k/IXAK63qVibHcAzbI1djcMYpVsnZloo9tuNPai8a8Q2Vjv8FnwLY+NFbQHq7NeTOFJnXRUe9/ pkXOLtsuuWNQCPk+L9RKV/cvqYZV2Bba8jlhhNu2AwqSQLQDvlz3B5NUZl01wlyv1/H3smJtThB6o 9cAvl64TaAovHuFYknh5GGumVV/ArcQ41VXTO5p5Q47X2BzCRiEZkySeLsGwvY5aR31hbjIAq43tP 7qkzaOttHv5HDdoCo0lrlhd2RGX7ZRYeH+5H3099pixMaCs4NTeRJDwSq6EfHIEaG2I3dM2oC/Cql 0pj6Zd/YR7ir6fxMUQCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3jUj-006qLp-9G; Tue, 21 Jun 2022 19:25:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3jQy-006o7J-P4; Tue, 21 Jun 2022 19:21:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3D46D1688; Tue, 21 Jun 2022 12:21:07 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 008833F792; Tue, 21 Jun 2022 12:21:04 -0700 (PDT) From: Sudeep Holla To: linux-kernel@vger.kernel.org, Greg KH Cc: Sudeep Holla , Atish Patra , Atish Patra , Vincent Guittot , Dietmar Eggemann , Qing Wang , Rob Herring , "Rafael J . Wysocki" , Ionela Voinescu , Pierre Gondois , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Will Deacon , Catalin Marinas , Gavin Shan Subject: [PATCH v4 10/20] arm64: topology: Remove redundant setting of llc_id in CPU topology Date: Tue, 21 Jun 2022 20:20:24 +0100 Message-Id: <20220621192034.3332546-11-sudeep.holla@arm.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220621192034.3332546-1-sudeep.holla@arm.com> References: <20220621192034.3332546-1-sudeep.holla@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220621_122108_904160_485562B7 X-CRM114-Status: GOOD ( 10.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since the cacheinfo LLC information is used directly in arch_topology, there is no need to parse and fetch the LLC ID information only for ACPI systems. Just drop the redundant parsing and setting of llc_id in CPU topology from ACPI PPTT. Cc: Will Deacon Cc: Catalin Marinas Reviewed-by: Gavin Shan Signed-off-by: Sudeep Holla Acked-by: Catalin Marinas --- arch/arm64/kernel/topology.c | 14 -------------- 1 file changed, 14 deletions(-) Hi Will/Catalin, This is part of a series updating topology to get both ACPI and DT view aligned. I have not cc-ed you assuming you won't be interested. Let me know if you are. The parts affecting arm64 is just this patch removing some unnecessary ACPI code that is now moved to core arch_topology.c Please ack if you are happy with this and OK to take this as part of the series. Regards, Sudeep diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c index 9ab78ad826e2..869ffc4d4484 100644 --- a/arch/arm64/kernel/topology.c +++ b/arch/arm64/kernel/topology.c @@ -89,8 +89,6 @@ int __init parse_acpi_topology(void) return 0; for_each_possible_cpu(cpu) { - int i, cache_id; - topology_id = find_acpi_cpu_topology(cpu, 0); if (topology_id < 0) return topology_id; @@ -107,18 +105,6 @@ int __init parse_acpi_topology(void) cpu_topology[cpu].cluster_id = topology_id; topology_id = find_acpi_cpu_topology_package(cpu); cpu_topology[cpu].package_id = topology_id; - - i = acpi_find_last_cache_level(cpu); - - if (i > 0) { - /* - * this is the only part of cpu_topology that has - * a direct relationship with the cache topology - */ - cache_id = find_acpi_cpu_cache_topology(cpu, i); - if (cache_id > 0) - cpu_topology[cpu].llc_id = cache_id; - } } return 0;