diff mbox series

[v4,1/4] arm64: dts: ls1028a: Update SFP binding to include clock

Message ID 20220630223207.1687329-2-sean.anderson@seco.com (mailing list archive)
State New, archived
Headers show
Series nvmem: sfp: binding updates | expand

Commit Message

Sean Anderson June 30, 2022, 10:32 p.m. UTC
The clocks property is now mandatory. Add it.

Fixes: eba5bea8f37f ("arm64: dts: ls1028a: add efuse node")
Signed-off-by: Sean Anderson <sean.anderson@seco.com>
Reviewed-by: Michael Walle <michael@walle.cc>
---

(no changes since v1)

 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski July 4, 2022, 8:27 a.m. UTC | #1
On 01/07/2022 00:32, Sean Anderson wrote:
> The clocks property is now mandatory. Add it.
> 
> Fixes: eba5bea8f37f ("arm64: dts: ls1028a: add efuse node")
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> Reviewed-by: Michael Walle <michael@walle.cc>

The subjects of all these 4 patches are confusing - you did not
update/add any binding here. These are not bindings.

Best regards,
Krzysztof
Shawn Guo July 5, 2022, 1:09 a.m. UTC | #2
On Mon, Jul 04, 2022 at 10:27:40AM +0200, Krzysztof Kozlowski wrote:
> On 01/07/2022 00:32, Sean Anderson wrote:
> > The clocks property is now mandatory. Add it.
> > 
> > Fixes: eba5bea8f37f ("arm64: dts: ls1028a: add efuse node")
> > Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> > Reviewed-by: Michael Walle <michael@walle.cc>
> 
> The subjects of all these 4 patches are confusing - you did not
> update/add any binding here. These are not bindings.

Right, I replaced 'binding' with 'node' during applying.

Shawn
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 92465f777603..d5cdd77e5a95 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -224,9 +224,12 @@  rst: syscon@1e60000 {
 			little-endian;
 		};
 
-		efuse@1e80000 {
+		sfp: efuse@1e80000 {
 			compatible = "fsl,ls1028a-sfp";
 			reg = <0x0 0x1e80000 0x0 0x10000>;
+			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
+					    QORIQ_CLK_PLL_DIV(4)>;
+			clock-names = "sfp";
 			#address-cells = <1>;
 			#size-cells = <1>;