From patchwork Fri Jul 1 19:26:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Foster X-Patchwork-Id: 12903654 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C2D4C433EF for ; Fri, 1 Jul 2022 19:28:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tkRpJaez6JEYarrHUlEM5PulfYV7OsGtFiYn1g1d/xU=; b=DbmHme2bXMTOOW 6JDSdGLvY16Nkr4K4uB1TaA57mpsQTfBI8fH41WBxYsRcZLaZiA1IKU0JBq8yOEw1OK5bUIFfFD7o f4Yj+5ItQ6BdqgaiGauWRsJgtEpCOY0c4ywKc6qX3524XZiuVt/TsFxK0JnCWd0mjfnwIUHgka9dw pjnIR9L6pn7kMaY1nDVLJuxq7JGYWSrT5gRzAD+4bVpY0ylcYulo/FrJ1GESsgJ1YRxAdJ4xmPi28 8BSw7wgOUXjGeGOTl2NsGz2N3gomfY3PLfFBmfQo2q1qC4PJbNhy4W0bOMauHA8Yd3fdgSJXJp3dK sWsd20LLIAa5NWwUcyVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7MIJ-006Zha-IZ; Fri, 01 Jul 2022 19:27:11 +0000 Received: from mail-bn8nam04on2129.outbound.protection.outlook.com ([40.107.100.129] helo=NAM04-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7MHc-006ZDU-Gl for linux-arm-kernel@lists.infradead.org; Fri, 01 Jul 2022 19:26:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VNBhkucqY2ipvV8N7s27a5WPwbTU+nGNcYI9fdvryIg8toagdPsT0ik40KUBV0ew7LMOfw6kmiixDFgHPKH310O723W4JSu8JiFGMlHd6KVj+CSS/AxJZj6paD1uV17aRaDW1DkqLc3LU98vH9MHTIRnxtTIizo2XzskAKV60VuJAylTyei0SV68N3mUXD0xqxj3eyRLBBGClCbMSiU7jmzhKjyLgMGSj3Md/MymKQj4Ga+aHp/L3whbqcgSANE6JFKZkHJmnYrtlU1oUowfKc1JbMeMiZUoQQm/Zsdzpg+cUg5QV04m8r0qWx/YQHw4cQEoDB5c2BiIPM83a4+pTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uOcGSAkGUZLMtQI5ouwJ59oJTVFWTM6Cy9q248Qfxx8=; b=fs2eRRc26McHsPtA/9UROO/97Cf6TICaUjwox0/XwDGt9nPsy/J9tVjiFL3yQLZxvnX/ZnnU03w//+3QX8/55yTJilIOCRuE5i4UR9V/V1NkpmphCnot9gfWszR4E2LlizKymB5YjG/qbaQD7NaTRigHWzNpINGsTPlr1/cdKZurIn5VIAD3X9pG0kiZKRjnzMbt6wOeFk+2Vx+oH/QVZqanwT4aMw6wGQj/NjkTK2nokruNXpVOC3mDeI41zZXt9wX5Wgd+IUbK71qwUcrkdVBQKHkA0UHeJH1A2gktVglZgv2tEeUEcTkHklGvJQ57oRfvXZ/l28J8DOFxvWYoMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uOcGSAkGUZLMtQI5ouwJ59oJTVFWTM6Cy9q248Qfxx8=; b=bubKyz58zKvgH9R4xCBxCqPvnXjRe4DM2Ba8C4R8y4H14lSasjLph8Egw9Uu+sdwARPYbFHiiarRzFEWwK6q11/fOofeH0pO6eiJ9m1gOUW/ApdDFu0nsuBqEiEVZlZWvIxVn1IjFnao5/+5B2Nb3wJi5VgE6vBflgehpEsyaWQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by CY4PR1001MB2230.namprd10.prod.outlook.com (2603:10b6:910:46::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Fri, 1 Jul 2022 19:26:20 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::712f:6916:3431:e74e]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::712f:6916:3431:e74e%6]) with mapi id 15.20.5373.018; Fri, 1 Jul 2022 19:26:20 +0000 From: Colin Foster To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Cc: Vladimir Oltean , Lee Jones , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Linus Walleij , Wolfram Sang , Terry Bowman , Andy Shevchenko , katie.morris@in-advantage.com Subject: [PATCH v12 net-next 2/9] net: mdio: mscc-miim: add ability to be used in a non-mmio configuration Date: Fri, 1 Jul 2022 12:26:02 -0700 Message-Id: <20220701192609.3970317-3-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220701192609.3970317-1-colin.foster@in-advantage.com> References: <20220701192609.3970317-1-colin.foster@in-advantage.com> X-ClientProxiedBy: MWHPR1601CA0006.namprd16.prod.outlook.com (2603:10b6:300:da::16) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 02eeb2a6-7620-4493-de2a-08da5b9793a0 X-MS-TrafficTypeDiagnostic: CY4PR1001MB2230:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QY9TAonoMI57aifygxh663PCUwhW/O0hT9OreJ2hQESvnhy7ZVhZlbFDtOYyd+2unN1WdSfBXZBZweX2CGe3mU0LtYBcaeDiXLbPztxkFpXeDB+eaoA6rK/Sj2GI9xQXt3wotakyhVJkrSgDWoqv7hes71Zg0BuYMPRuzsGY3pIatEsojCS0DjxZJiB+vyoyPw/g1MUF105zcFp9K6GcfJU6sx4VyzNH274f+sXKo6uGxCgbTHRolWtp5fButX+7rmPZ0ocSqFjsmPp4wGjS0rBDX/0+53xJRgeqMY2JpqyHEcfPNxQsMgGhW2ksaUY3rWhJ3qLNoKot8sacLApzSh+bFo99z/ZmUpx0wTMCTcKz5c6qY1hWy759CSabwqp74yQYTsVlPHs8TJKneWiGISg1Fo/3eHs/JqvgoNP1AqQ8yy3CA3TnHvd8Y6bVOM000R9MQxb26wT+/5/PDZmwXnzVSANJjiEcFb4i06BkkKRctasQbA/vuyeDPASC3nbQ06FGOBhj4jGoVHmZ0ILYydEVBol2xkgbDfD4fLCufJ87Wvlw+GgTsB6r91l0dt0F3Mhv0MCz6eIjRIvzX6O/SKpa6mCQ/NSzQlt9/t3L3w5mg00Eb1euSO9YvRFgGeWFstMrkbf1KX6zqlngbOycDDe/VkrzSut46Yf705fZg2pX7nMU/DLy30hMNAWcTGhgITSj17jOlD1q9O6Yab8mpJV3EepIuuKg302VXYnneKUFLAifFXOuwEzbhjesBRe71xF6akQQCnls116bwzW4dj+ngociNPJwkMO5b7xid/HEumSBUlyDTRQWV4eQjsJa X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2351.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(346002)(39830400003)(376002)(136003)(396003)(66476007)(38350700002)(186003)(8676002)(8936002)(4326008)(86362001)(66946007)(1076003)(5660300002)(6666004)(38100700002)(107886003)(83380400001)(66556008)(7416002)(41300700001)(478600001)(316002)(36756003)(52116002)(44832011)(2906002)(6512007)(2616005)(6506007)(6486002)(26005)(54906003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4tnNSElbuiF4KcJWrEqXK1Erex8/7VPVPiGfNKIKIC/qxGIIwHoYAbJSAzSivkJVlCGrgwigFkpoZcT7jdMOlmXhyYjFd/6rwmnMIEbTdlBPOy1CM6Pewyr1W7RpUyXwbbzLVXI/jTWboaiDRS19zZHZt4D1qovl/jIMPQIZqATDQT1e8O/h0FwU/fjS8KqNtvWXckJBfsF4RdGGSDI7+tLmAtkpcf6ZDuFIvbtg9fP4N7dSlVvx0VHGxmHes1YAIimpdkZQznwN3tkFOg/yG/Fz1fOF7nLHQThkTVJdsnsnW8BJId2dwmj0Humd43KwAA0GHO+3/E24pNxoAx0+Tuqgv3pQXbhFws3NrV8BBCIWeTpZaAqIP367IWzrFc4p7nRz9udSE4OkZNExTDFd11fdazQA8fgx2M53tXOZB64DCVUAf75N2jbqM9vWzKpj9R8fob1w2YEZfGHS2S17CNhlOJEBP5C/Mfe/qg+9600ikkf56hLUtqNeruPfKMYzRvtghAxNERVOG3F1DmXygJUwcij4pna48WA+a2NeHRDy2J41crqK+q3z99i2wHpNfMZ6kF/j3LLzy3JjrbINbjCMSLnM5llGQD7SsXptD/7Y++JPfT6o//o61pi5qqauxAWtw9Bk34ApCWRJI83W1ytw+bnsVGO5V5zYBEiMS/3cB/4toyL3PWv+UYRTB+FTCYOPzyf44M3S9rVRki1Cqhz/seSSXs/O7PAXhzHMcmyTn/citX/Bn/opznnb+eant6q6S9+FD4s3PokhP7gM1uGtQjZNjEB+e7yr52fHuz0BKsDZoevdD1fKBNN5tcwygSAuqsE5AedPc+R25Nx2RW6zygamL8SqyJv2y1AU1ZRw0gZMvdd3z6vNbTiBui+fFHuj3U8VFyTFhpHJ2ZKMJSc+st06H4IPDoKBGHOXqQMFXB3btvNrr1r8Ai/ubFJIsU2ALPxNSRVIPQIK/TpYnfAtBcDPMoEKBBAPAB+e8D8q4DE4zyA91ElBz7oXgBpetiCzHTbVs21XgHggffBE+OJ1vtA3h6Cx9s5DEbJQ3LjNw734J5hRE1H7ZbdtHeOv2BrcbQgRZVDBMadOKnDa8AJGvZHuTpMw3dT80nhdIRdJuGFW8lGHQyTkiVIFd6TOUFiG/ZBOK3jbDmPuiU3Z+0YnkKfl6eXEE7PEJxf0LRXvVcHIQcAP5HPDhscIQQs7PxDJkq24A96ijWJpQK9N6Mua/rpVMsN8tcI84G4rr+Gm/xDvqdyONT+6FHQ0jPAoDOqLyGJI9g7KZi4WlhZd7eLXLTeqIh3MHfc2YDi7MM7yT5KoxL+Xv30n1wtbRIWyfJaVuYqnkuhBG6r8vlcgZMY97+NoVLXCoKj9jNiVBcEEvbhBB/NzTnmNcqbr1SOsVGP2jFKe24SGkFQMzk0ZCDiD6iRKHM0rDyJegGF5aoJTr7kqVgpVC+Pgad5ZRfbEgg9qraLR3Np9Uywm+PcleuafMim3lz3c4ue0wVaABl+M1PmVn5/f8WTLHxTtC3oj/xLp0OC1UbOZjWPM4ItBD3hvGMZSFdj+TstlYPwxgy9aPxwdX/j07XAkl6c9SAHJwBE2QH+qHwcwLyIm7Lm9fA== X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02eeb2a6-7620-4493-de2a-08da5b9793a0 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 19:26:20.3204 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0fRRjYzPAn7uamLqi3oG48ev0ixszY7kQldZndYgEKudM1MWHmTAaQXbkcCVEU2F4dAfWb36GtE3uqXFxF3mn5WtoifDjnpsWE0Zafx98sQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1001MB2230 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220701_122628_625477_BDC42339 X-CRM114-Status: GOOD ( 16.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There are a few Ocelot chips that contain the logic for this bus, but are controlled externally. Specifically the VSC7511, 7512, 7513, and 7514. In the externally controlled configurations these registers are not memory-mapped. Add support for these non-memory-mapped configurations. Signed-off-by: Colin Foster --- drivers/net/mdio/mdio-mscc-miim.c | 34 ++++++++----------------------- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/drivers/net/mdio/mdio-mscc-miim.c b/drivers/net/mdio/mdio-mscc-miim.c index 08541007b18a..c23a9fb5238c 100644 --- a/drivers/net/mdio/mdio-mscc-miim.c +++ b/drivers/net/mdio/mdio-mscc-miim.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -270,43 +271,26 @@ static int mscc_miim_clk_set(struct mii_bus *bus) static int mscc_miim_probe(struct platform_device *pdev) { - struct regmap *mii_regmap, *phy_regmap = NULL; struct device_node *np = pdev->dev.of_node; + struct regmap *mii_regmap, *phy_regmap; struct device *dev = &pdev->dev; - void __iomem *regs, *phy_regs; struct mscc_miim_dev *miim; - struct resource *res; struct mii_bus *bus; int ret; - regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); - if (IS_ERR(regs)) { - dev_err(dev, "Unable to map MIIM registers\n"); - return PTR_ERR(regs); - } - - mii_regmap = devm_regmap_init_mmio(dev, regs, &mscc_miim_regmap_config); - + mii_regmap = ocelot_regmap_from_resource(pdev, 0, + &mscc_miim_regmap_config); if (IS_ERR(mii_regmap)) { dev_err(dev, "Unable to create MIIM regmap\n"); return PTR_ERR(mii_regmap); } /* This resource is optional */ - res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - if (res) { - phy_regs = devm_ioremap_resource(dev, res); - if (IS_ERR(phy_regs)) { - dev_err(dev, "Unable to map internal phy registers\n"); - return PTR_ERR(phy_regs); - } - - phy_regmap = devm_regmap_init_mmio(dev, phy_regs, - &mscc_miim_phy_regmap_config); - if (IS_ERR(phy_regmap)) { - dev_err(dev, "Unable to create phy register regmap\n"); - return PTR_ERR(phy_regmap); - } + phy_regmap = ocelot_regmap_from_resource_optional(pdev, 1, + &mscc_miim_phy_regmap_config); + if (IS_ERR(phy_regmap)) { + dev_err(dev, "Unable to create phy register regmap\n"); + return PTR_ERR(phy_regmap); } ret = mscc_miim_setup(dev, &bus, "mscc_miim", mii_regmap, 0);