| Message ID | 20220712214427.544860-1-nfraprado@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iommu/mediatek: Log with dev_err_probe when failing to parse dts | expand |
Il 12/07/22 23:44, Nícolas F. R. A. Prado ha scritto: > mtk_iommu_mm_dts_parse() can fail with EPROBE_DEFER if not all larbs > have probed yet, so use dev_err_probe() to avoid logging as an error in > that case. Also drop the return value from the message since it's > already printed by dev_err_probe(), and add the missing newline at the > end. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Tue, Jul 12, 2022 at 05:44:27PM -0400, Nícolas F. R. A. Prado wrote: > mtk_iommu_mm_dts_parse() can fail with EPROBE_DEFER if not all larbs > have probed yet, so use dev_err_probe() to avoid logging as an error in > that case. Also drop the return value from the message since it's > already printed by dev_err_probe(), and add the missing newline at the > end. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Applied, thanks.
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index b2ae84046249..3d23409bf108 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -1214,7 +1214,7 @@ static int mtk_iommu_probe(struct platform_device *pdev) if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_MM)) { ret = mtk_iommu_mm_dts_parse(dev, &match, data); if (ret) { - dev_err(dev, "mm dts parse fail(%d).", ret); + dev_err_probe(dev, ret, "mm dts parse fail\n"); goto out_runtime_disable; } } else if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_INFRA)) {
mtk_iommu_mm_dts_parse() can fail with EPROBE_DEFER if not all larbs have probed yet, so use dev_err_probe() to avoid logging as an error in that case. Also drop the return value from the message since it's already printed by dev_err_probe(), and add the missing newline at the end. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- drivers/iommu/mtk_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)