| Message ID | 20220726141653.177948-4-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: mediatek: Cleanups for MediaTek SVS driver | expand |
On 26/07/2022 16:16, AngeloGioacchino Del Regno wrote: > The interrupt flags are specified in devicetree: forcing them into > the driver is suboptimal and not very useful. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Applied, thanks > --- > drivers/soc/mediatek/mtk-svs.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c > index ee990acfc2d5..fcf246a6bb07 100644 > --- a/drivers/soc/mediatek/mtk-svs.c > +++ b/drivers/soc/mediatek/mtk-svs.c > @@ -262,7 +262,6 @@ static const u32 svs_regs_v2[] = { > * @rst: svs platform reset control > * @efuse_parsing: svs platform efuse parsing function pointer > * @probe: svs platform probe function pointer > - * @irqflags: svs platform irq settings flags > * @efuse_max: total number of svs efuse > * @tefuse_max: total number of thermal efuse > * @regs: svs platform registers map > @@ -280,7 +279,6 @@ struct svs_platform { > struct reset_control *rst; > bool (*efuse_parsing)(struct svs_platform *svsp); > int (*probe)(struct svs_platform *svsp); > - unsigned long irqflags; > size_t efuse_max; > size_t tefuse_max; > const u32 *regs; > @@ -294,7 +292,6 @@ struct svs_platform_data { > struct svs_bank *banks; > bool (*efuse_parsing)(struct svs_platform *svsp); > int (*probe)(struct svs_platform *svsp); > - unsigned long irqflags; > const u32 *regs; > u32 bank_max; > }; > @@ -2680,7 +2677,6 @@ static const struct svs_platform_data svs_mt8192_platform_data = { > .banks = svs_mt8192_banks, > .efuse_parsing = svs_mt8192_efuse_parsing, > .probe = svs_mt8192_platform_probe, > - .irqflags = IRQF_TRIGGER_HIGH, > .regs = svs_regs_v2, > .bank_max = ARRAY_SIZE(svs_mt8192_banks), > }; > @@ -2699,7 +2695,6 @@ static const struct svs_platform_data svs_mt8183_platform_data = { > .banks = svs_mt8183_banks, > .efuse_parsing = svs_mt8183_efuse_parsing, > .probe = svs_mt8183_platform_probe, > - .irqflags = IRQF_TRIGGER_LOW, > .regs = svs_regs_v2, > .bank_max = ARRAY_SIZE(svs_mt8183_banks), > }; > @@ -2743,7 +2738,6 @@ static struct svs_platform *svs_platform_probe(struct platform_device *pdev) > svsp->banks = svsp_data->banks; > svsp->efuse_parsing = svsp_data->efuse_parsing; > svsp->probe = svsp_data->probe; > - svsp->irqflags = svsp_data->irqflags; > svsp->regs = svsp_data->regs; > svsp->bank_max = svsp_data->bank_max; > > @@ -2782,8 +2776,7 @@ static int svs_probe(struct platform_device *pdev) > } > > ret = devm_request_threaded_irq(svsp->dev, svsp_irq, NULL, svs_isr, > - svsp->irqflags | IRQF_ONESHOT, > - svsp->name, svsp); > + IRQF_ONESHOT, svsp->name, svsp); > if (ret) { > dev_err(svsp->dev, "register irq(%d) failed: %d\n", > svsp_irq, ret);
diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c index ee990acfc2d5..fcf246a6bb07 100644 --- a/drivers/soc/mediatek/mtk-svs.c +++ b/drivers/soc/mediatek/mtk-svs.c @@ -262,7 +262,6 @@ static const u32 svs_regs_v2[] = { * @rst: svs platform reset control * @efuse_parsing: svs platform efuse parsing function pointer * @probe: svs platform probe function pointer - * @irqflags: svs platform irq settings flags * @efuse_max: total number of svs efuse * @tefuse_max: total number of thermal efuse * @regs: svs platform registers map @@ -280,7 +279,6 @@ struct svs_platform { struct reset_control *rst; bool (*efuse_parsing)(struct svs_platform *svsp); int (*probe)(struct svs_platform *svsp); - unsigned long irqflags; size_t efuse_max; size_t tefuse_max; const u32 *regs; @@ -294,7 +292,6 @@ struct svs_platform_data { struct svs_bank *banks; bool (*efuse_parsing)(struct svs_platform *svsp); int (*probe)(struct svs_platform *svsp); - unsigned long irqflags; const u32 *regs; u32 bank_max; }; @@ -2680,7 +2677,6 @@ static const struct svs_platform_data svs_mt8192_platform_data = { .banks = svs_mt8192_banks, .efuse_parsing = svs_mt8192_efuse_parsing, .probe = svs_mt8192_platform_probe, - .irqflags = IRQF_TRIGGER_HIGH, .regs = svs_regs_v2, .bank_max = ARRAY_SIZE(svs_mt8192_banks), }; @@ -2699,7 +2695,6 @@ static const struct svs_platform_data svs_mt8183_platform_data = { .banks = svs_mt8183_banks, .efuse_parsing = svs_mt8183_efuse_parsing, .probe = svs_mt8183_platform_probe, - .irqflags = IRQF_TRIGGER_LOW, .regs = svs_regs_v2, .bank_max = ARRAY_SIZE(svs_mt8183_banks), }; @@ -2743,7 +2738,6 @@ static struct svs_platform *svs_platform_probe(struct platform_device *pdev) svsp->banks = svsp_data->banks; svsp->efuse_parsing = svsp_data->efuse_parsing; svsp->probe = svsp_data->probe; - svsp->irqflags = svsp_data->irqflags; svsp->regs = svsp_data->regs; svsp->bank_max = svsp_data->bank_max; @@ -2782,8 +2776,7 @@ static int svs_probe(struct platform_device *pdev) } ret = devm_request_threaded_irq(svsp->dev, svsp_irq, NULL, svs_isr, - svsp->irqflags | IRQF_ONESHOT, - svsp->name, svsp); + IRQF_ONESHOT, svsp->name, svsp); if (ret) { dev_err(svsp->dev, "register irq(%d) failed: %d\n", svsp_irq, ret);
The interrupt flags are specified in devicetree: forcing them into the driver is suboptimal and not very useful. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- drivers/soc/mediatek/mtk-svs.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)